spec: https://fed500.fedorapeople.org/python-bytecode.spec srpm: https://fed500.fedorapeople.org/python-bytecode-0.17.0-1.fc43.src.rpm description: bytecode is a Python module to generate and modify bytecode. fas: fed500 Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/10065214 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2432752-python-bytecode/fedora-rawhide-x86_64/10065214-python-bytecode/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License [generated file]". 55 files have unknown license. Detailed output of licensecheck in /home/gwyn/2432752-python- bytecode/licensecheck.txt [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.14/site- packages, /usr/lib/python3.14 [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/help/en(python- slixmpp-doc, python3-junitparser, profanity-doc, novelwriter-doc, python3-sphinxcontrib-chapeldomain, manifold-doc, python3-tablib, python-backcall-doc, libstrophe-doc, python-x3dh-docs, rauc-doc, python3-colorspacious, thorvg-doc, python3-questionary, python3-doubleratchet, python3-cobalt, bstring-doc, python3-xeddsa, python3-androguard) [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2113 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep Check out the directory ownership, otherwise this looks good.
(In reply to Gwyn Ciesla from comment #2) > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/lib/python3.14/site- > packages, /usr/lib/python3.14 This seems to be a known bug in Fedora-review as these are owned by python3-libs, but have added a Requires: python3-libs to the spec file. > [!]: Package does not own files or directories owned by other packages. > Note: Dirs in package are owned also by: /usr/share/help/en(python- > slixmpp-doc, python3-junitparser, profanity-doc, novelwriter-doc, > python3-sphinxcontrib-chapeldomain, manifold-doc, python3-tablib, > python-backcall-doc, libstrophe-doc, python-x3dh-docs, rauc-doc, > python3-colorspacious, thorvg-doc, python3-questionary, > python3-doubleratchet, python3-cobalt, bstring-doc, python3-xeddsa, > python3-androguard) The directory /usr/share/help/en is co-owned, all the above listed packages have their own subdirectories in /usr/share/help/en > > > Check out the directory ownership, otherwise this looks good. spec: https://fed500.fedorapeople.org/python-bytecode.spec srpm: https://fed500.fedorapeople.org/python-bytecode-0.17.0-1.fc43.src.rpm
Got it, thanks! APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-bytecode
FEDORA-2026-845100f4df (python-bytecode-0.17.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2026-845100f4df
FEDORA-2026-a74b8a26e4 (python-bytecode-0.17.0-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-a74b8a26e4
Thanks for the review. https://release-monitoring.org/project/50541/
FEDORA-2026-a74b8a26e4 has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-a74b8a26e4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-a74b8a26e4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-845100f4df has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-845100f4df \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-845100f4df See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-a74b8a26e4 (python-bytecode-0.17.0-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-845100f4df (python-bytecode-0.17.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.