Fedora Account System
Red Hat Associate
Red Hat Customer
SRPM:https://fedorapeople.org/~limb/review/rust-change-case/rust-change-case-0.2.0-1.fc44.src.rpm SPEC:https://fedorapeople.org/~limb/review/rust-change-case/rust-change-case.spec Description: Transform a string between camelCase, PascalCase, Capital Case, snake_case, param-case, CONSTANT_CASE and others.
There seems to be some problem with the following file. SRPM URL: https://fedorapeople.org/~limb/review/rust-change-case/rust-change-case-0.2.0-1.fc44.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
# FIXME: no license files detected %doc %{crate_instdir}/README.md This does have to be fixed, per https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text. The upstream repository https://github.com/sigoden/change-case/blob/master/Cargo.toml is archived, and the author recommends using https://crates.io/crates/convert_case instead. I suggested switching to convert_case upstream in https://github.com/Cisco-Talos/clamav-signature-util/pull/12. Maybe you can do the same thing downstream and avoid packaging rust-change-case at all. You would have to coordinate an update of the existing rust-convert_case package, now at 0.8.0, in order to use the ccase!() macro as I did. The sole existing dependent package is rust-libspa, and it’s likely that it can be made to work with the latest rust-convert_case by simply patching its version bounds. Upstream for rust-libspa dropped the convert_case dependency altogether in https://gitlab.freedesktop.org/pipewire/pipewire-rs/-/commit/a8f365faf5292835650f9a49083e0c26c3de0bde, but that hasn’t been released yet.
Interesting. I've added myself to the PR, and I'll see where that goes. Thank you.
(In reply to Gwyn Ciesla from comment #3) > Interesting. I've added myself to the PR, and I'll see where that goes. > Thank you. Since upstream merged the PR, is this review still needed? There hasn’t been a new upstream release of clamav-signature-util, but the PR would be a straightforward downstream patch, especially now that rust-convert_case has been updated to 0.10.0, which does have the ccase macro[1]. [1] https://docs.rs/convert_case/0.10.0/convert_case/macro.ccase.html
It is not. thank you!