woops...

Spec URL: http://glive.tuxfamily.org/fedora/gnome-specimen/gnome-specimen.spec
SRPM URL:
http://glive.tuxfamily.org/fedora/gnome-specimen/gnome-specimen-0.2-1.fc8.src.rpm

Just a vew comments:

Does this package actually need to be arch-specific?  It just seems to contain
python code to me, and so elicits
  E: gnome-specimen no-binary
from rpmlint, which also dislikes the desktop file:
  E: gnome-specimen invalid-desktopfile 
   //usr/share/applications/gnome-specimen.desktop
(the doubled slash seems to come from rpmlint).

desktop-file-validate says:
gnome-specimen.desktop: warning: key "Encoding" in group "Desktop Entry" is
deprecated
gnome-specimen.desktop: error: value "GTK;GNOME;Application;Graphics" for string
list key "Categories" in group "Desktop Entry" does not have a semicolon (';')
as trailing character

ping Damien

Created attachment 157171 [details]
patch: fix wrong entries from desktop file

note that your spec file need some improvment too.

1. move your desktop-file-install command in %%install stage
2. set your package as noarch package, its only contains code, no binaries.
--> in this case your python directory install need to be change to
%{python_sitelibs}
3. your package own other directories owned by other packages.

Fixed

Spec URL: http://glive.tuxfamily.org/fedora/gnome-specimen/gnome-specimen.spec
SRPM URL:
http://glive.tuxfamily.org/fedora/gnome-specimen/gnome-specimen-0.2-2.fc8.src.rpm

Some issue are still not fixed.

1. and 3. from [comment #4]


== additionnal comment: ==

*From desktop-file-install command:

$RPM_BUILD_ROOT%{_datadir}/applications//%{name}.desktop
instead of
$RPM_BUILD_ROOT/%{_datadir}/applications/%{name}.desktop


* Your BR line is too long, paste it to two lines (at least)

oops typo:

s|applications//%{name}|applications/%{name}|

ping !

* Wed Jun 27 2007 Damien Durand <splinux> - 0.2-3
- Fix owned directories

Spec URL: http://glive.tuxfamily.org/fedora/gnome-specimen/gnome-specimen.spec
SRPM URL:
http://glive.tuxfamily.org/fedora/gnome-specimen/gnome-specimen-0.2-3.fc8.src.rpm

Just a typo:

* From desktop-file-install command:
It's $RPM_BUILD_ROOT%{_datadir}/applications//%{name}.desktop
instead of
$RPM_BUILD_ROOT%/{_datadir}/applications//%{name}.desktop

that make mock fails to build.

Also, the %clean sectio should be only use to clean the temp directory.
Did you uploaded the right spec files ?

sorry, need fix before approve it.

Fixed

SPEC url: http://glive.tuxfamily.org/fedora/gnome-specimen/gnome-specimen.spec
SRPMS url:
http://glive.tuxfamily.org/fedora/gnome-specimen/gnome-specimen-0.2-4.fc8.src.rpm

=== REQUIRED ITEMS ===
 [ OK ] Package is named according to the Package Naming Guidelines.
 [ OK ] Spec file name must match the base package.
 [ OK ] Package meets the Packaging Guidelines.
 [ OK ] Package successfully compiles and builds:
 [ OK ] Mock: built on FC-devel [noarch package]
 [ OK ] Package is not relocatable.
 [ OK ] Buildroot is correct
 [ OK ] Package is licensed with an open-source compatible license.
 [ OK ] License field in the package spec file matches the actual license.
 [ Ok ] License type: GPL
 [ OK ] The source package includes the text of the license(s) in %doc.
 [ OK ] Spec file is legible and written in American English.
 [ OK ] Package is not known to require ExcludeArch
 [ OK ] All build dependencies are listed in BuildRequires.
 [ OK ] The spec file handles locales properly.
 [ SKIP ] ldconfig called in %post and %postun if required.
 [ OK ] Package must own all directories that it creates.
 [ OK ] Package requires other packages for directories it uses.
 [ OK ] Package does not contain duplicates in %files.
 [ OK ] Permissions on files are set properly.
 [ OK ] Package has a %clean section.
 [ OK ] Package consistently uses macros.
 [ CHECK ] Package contains code, or permissable content.
 [ SKIP ] Large documentation files are in a -doc subpackage, if required.
 [ OK ] Package uses nothing in %doc for runtime.
 [ SKIP ] Header files in -devel subpackage, if present.
 [ SKIP ] Static libraries in -devel subpackage, if present.
 [ SKIP ] Package requires pkgconfig, if .pc files are present.
 [ SKIP] Development .so files in -devel subpackage, if present.
 [ SKIP] Fully versioned dependency in subpackages, if present.
 [ OK ] Package does not contain any libtool archives (.la).
 [ OK ] Package contains a properly installed %{name}.desktop file.
 [ OK ] Package does not own files or directories owned by other packages.

 [ OK ] Rpmlint output: Silent on both SRPM and RPM.
    	


==========
*APPROVED*
==========

Follow http://fedoraproject.org/wiki/CVSAdminProcedure for the CVS Request
procedure.

New Package CVS Request
=======================
Package Name: gnome-specimen
Short Description: A simple tool to view and compare fonts installed on your system
Owners: splinux
Branches: FC-6 F-7

cvs done