Bug 2435439 - Review Request: rust-sys-mount - High level FFI binding around the sys mount & umount2 calls
Summary: Review Request: rust-sys-mount - High level FFI binding around the sys mount ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: gmankab
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/sys-mount
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-01-30 03:49 UTC by Sam Day
Modified: 2026-03-16 22:24 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-03-16 22:24:47 UTC
Type: ---
Embargoed:
gmankab: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 10082118 to 10181817 (977 bytes, patch)
2026-03-02 02:11 UTC, Fedora Review Service
no flags Details | Diff

Description Sam Day 2026-01-30 03:49:03 UTC
Spec URL: https://samcday.fedorapeople.org/rust-sys-mount.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/samcday/droid-juicer/fedora-rawhide-x86_64/10077289-rust-sys-mount/rust-sys-mount-3.1.0-1.fc44.src.rpm
Description: High level FFI binding around the sys mount & umount2 calls.
Fedora Account System Username: samcday

This was generated using `rust2rpm sys-mount.0 -t fedora -s`

I am packaging this crate in order to package the "droid-juicer" project.

Comment 1 Fedora Review Service 2026-01-31 01:43:26 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10082118
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2435439-rust-sys-mount/fedora-rawhide-x86_64/10082118-rust-sys-mount/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Ben Beasley 2026-02-22 14:17:21 UTC
The license is “MIT OR Apache-2.0,” but the LICENSE file contains only the MIT license text. The Apache-2.0 license option requires license text to be distributed; see https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text. The upstream repository https://github.com/pop-os/sys-mount doesn’t contain Apache-2.0 license text, either. Please begin by raising the issue upstream.

Comment 3 Sam Day 2026-02-23 23:55:28 UTC
Hello music,

Thanks, I've gotten the ball rolling upstream: https://github.com/pop-os/sys-mount/pull/41

Comment 4 Sam Day 2026-03-02 02:03:52 UTC
Now using this rust2rpm.toml:

```
[package]
license-files = { include = ["LICENSE-Apache-2.0.txt"] }

[[package.extra-sources]]
number = 2
file = "https://www.apache.org/licenses/LICENSE-2.0.txt"

[scripts.prep]
pre = ["cp %{SOURCE2} LICENSE-Apache-2.0.txt"]
```


Spec URL: https://download.copr.fedorainfracloud.org/results/samcday/droid-juicer/fedora-rawhide-x86_64/10181808-rust-sys-mount/rust-sys-mount.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/samcday/droid-juicer/fedora-rawhide-x86_64/10181808-rust-sys-mount/rust-sys-mount-3.1.0-1.fc45.src.rpm

Comment 5 Fedora Review Service 2026-03-02 02:11:34 UTC
Created attachment 2131574 [details]
The .spec file difference from Copr build 10082118 to 10181817

Comment 6 Fedora Review Service 2026-03-02 02:11:36 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10181817
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2435439-rust-sys-mount/fedora-rawhide-x86_64/10181817-rust-sys-mount/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 gmankab 2026-03-02 03:27:12 UTC
thanks, looks fine!

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Comment 9 Fedora Admin user for bugzilla script actions 2026-03-16 21:30:58 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-sys-mount

Comment 10 Fedora Update System 2026-03-16 22:20:20 UTC
FEDORA-2026-ec8a9c6575 (rust-sys-mount-3.1.0-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-ec8a9c6575

Comment 11 Fedora Update System 2026-03-16 22:24:47 UTC
FEDORA-2026-ec8a9c6575 (rust-sys-mount-3.1.0-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.