Spec URL: https://deamn.fedorapeople.org/mbpoll.spec SRPM URL: https://deamn.fedorapeople.org/mbpoll-1.5.2-1.fc44.src.rpm Description: mbpoll is a command-line utility used to communicate with ModBus slave devices over RTU or TCP. It supports reading discrete inputs, binary outputs (coils), input registers, and holding registers, with values expressed in decimal, hexadecimal, or single‑precision floating‑point formats. The tool is compatible with libmodbus and provides functionality similar to the original modpoll program while being fully independent and open source. Fedora Account System Username: deamn
Copr build: https://copr.fedorainfracloud.org/coprs/build/10082122 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2435517-mbpoll/fedora-rawhide-x86_64/10082122-mbpoll/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Are you sure its GPL-3.0-only and not GPL-3.0-or-later ? All the license headers in src/ are or-later
I updated the licence, it's GPL-3.0-or-later. Spec URL: https://deamn.fedorapeople.org/mbpoll.spec SRPM URL: https://deamn.fedorapeople.org/mbpoll-1.5.2-1.fc45.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License", "GNU General Public License v3.0 or later", "CeCILL License", "*No copyright* GNU Lesser General Public License", "*No copyright* GNU Lesser General Public License, Version 3". 12 files have unknown license. Detailed output of licensecheck in /tmp/review/2435517-mbpoll/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10193 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: mbpoll-1.5.2-1.fc44.x86_64.rpm mbpoll-1.5.2-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp8mp9b_5y')] checks: 32, packages: 2 mbpoll.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/mbpoll/AUTHORS mbpoll.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/mbpoll/README.md mbpoll.src: W: strange-permission mbpoll-1.5.2.tar.gz 777 mbpoll.src: W: strange-permission mbpoll.spec 777 mbpoll.src: E: spelling-error ('libmodbus', '%description -l en_US libmodbus -> libidinous') mbpoll.src: E: spelling-error ('modpoll', '%description -l en_US modpoll -> mod poll, mod-poll, monopoly') mbpoll.x86_64: E: spelling-error ('libmodbus', '%description -l en_US libmodbus -> libidinous') mbpoll.x86_64: E: spelling-error ('modpoll', '%description -l en_US modpoll -> mod poll, mod-poll, monopoly') mbpoll.x86_64: W: no-manual-page-for-binary mbpoll mbpoll.spec: W: no-%check-section 2 packages and 0 specfiles checked; 4 errors, 6 warnings, 7 filtered, 4 badness; has taken 0.4 s Rpmlint (debuginfo) ------------------- Checking: mbpoll-debuginfo-1.5.2-1.fc44.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpembge96c')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 mbpoll.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/mbpoll/AUTHORS mbpoll.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/mbpoll/README.md mbpoll.x86_64: E: spelling-error ('libmodbus', '%description -l en_US libmodbus -> libidinous') mbpoll.x86_64: E: spelling-error ('modpoll', '%description -l en_US modpoll -> mod poll, mod-poll, monopoly') mbpoll.x86_64: W: no-manual-page-for-binary mbpoll 2 packages and 0 specfiles checked; 2 errors, 3 warnings, 9 filtered, 2 badness; has taken 0.5 s Source checksums ---------------- https://github.com/epsilonrt/mbpoll/archive/v1.5.2/mbpoll-1.5.2.tar.gz : CHECKSUM(SHA256) this package : 7d960cd4459b5f7c2412abc51aba93a20b6114fd75d1de412b1e540cfb63bfec CHECKSUM(SHA256) upstream package : 7d960cd4459b5f7c2412abc51aba93a20b6114fd75d1de412b1e540cfb63bfec Requires -------- mbpoll (rpmlib, GLIBC filtered): libc.so.6()(64bit) libmodbus.so.5()(64bit) rtld(GNU_HASH) Provides -------- mbpoll: mbpoll mbpoll(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /tmp/review/2435517-mbpoll/srpm/mbpoll.spec 2026-02-06 20:33:07.995067199 +0200 +++ /tmp/review/2435517-mbpoll/srpm-unpacked/mbpoll.spec 2026-02-06 02:00:00.000000000 +0200 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.3) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global forgeurl https://github.com/epsilonrt/mbpoll @@ -41,3 +51,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Fri Feb 06 2026 John Doe <packager> - 1.5.2-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2435517 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: SugarActivity, fonts, PHP, Java, R, Perl, Ocaml, Python, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Marking this approved but before you import the package: - Number the sources, i.e. change `Source:` to `Source0:`. - If you don't plan to build this for EPEL 9 or older, then consider moving `%cmake` to `%conf` section; the Packaging Guidelines example for CMake [1] will be soon updated [2] to account that. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/#_example_usage [2] https://pagure.io/packaging-committee/pull-request/1524
The Pagure repository was created at https://src.fedoraproject.org/rpms/mbpoll
FEDORA-2026-07e1fc846a (mbpoll-1.5.2-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-07e1fc846a
FEDORA-2026-fc3482529f (mbpoll-1.5.2-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-fc3482529f
FEDORA-2026-07e1fc846a (mbpoll-1.5.2-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-fc3482529f (mbpoll-1.5.2-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.