Hide Forgot
Spec URL: http://www.thatfleminggent.com/fedorasubs/innotop.spec SRPM URL: http://www.thatfleminggent.com/fedorasubs/innotop-1.4.2-1.fc7.mf.src.rpm Description: innotop connects to a MySQL database server and retrieves information from it, then displays it in a manner similar to the UNIX top program. innotop uses the data from SHOW VARIABLES, SHOW GLOBAL STATUS, SHOW FULL PROCESSLIST, and SHOW ENGINE INNODB STATUS, among other things. (Note: Taken directly from my own repo, will clean up dist and changelog as needed ;-))
Hi Michael, Review for release 1.fc7.mf: * RPM name is OK * Source innotop-1.4.2.tar.gz is the same as upstream * This is the latest version * Builds fine in mock Needs work: * BuildRequires: perl should not be included (wiki: PackagingGuidelines#Exceptions)
Cheers for that (you might want to assign yourself the bug if you are reviewing it by the way.) Spec URL: http://www.thatfleminggent.com/fedorasubs/innotop.spec SRPM URL: http://www.thatfleminggent.com/fedorasubs/innotop-1.4.2-2.fc7.mf.src.rpm - Fixed up BR (removed perl, used the perl(Foo::Bar) symbols method for prerequisites. Built locally in mock for FC5-6 and F7.
Thanks Michael. > you might want to assign yourself the bug if you are reviewing > it by the way I did. One other issue: missing Requires on Term::Readkey and DBD:MySQL [ruben@odin reports]$ innotop Can't locate Term/ReadKey.pm in @INC
Oh, crap - RPMs dependency parser didn't pick these up. I'll add them as explicit Requires in my next iteration.
Yeah, but it's not a bug, it's a feature ;-) from /usr/lib/rpm/perl.req: # we only consider require statements that are flush against # the left edge. any other require statements give too many # false positives, as they are usually inside of an if statement # as a fallback module or a rarely used option
These *should* be sorted out now. Built locally and works for me :-) http://www.thatfleminggent.com/fedorasubs/innotop.spec http://www.thatfleminggent.com/fedorasubs/innotop-1.4.2-3.fc7.mf.src.rpm
Approved. Don't forget to clean up your disttag and changelog before importing.
New Package CVS Request ======================= Package Name: innotop Short Description: Console MySQL Monitor Owners: mfleming+rpm@enlartenment.com Branches: FC-6 F-7 EL-4 EL-5 InitialCC:
cvs done.
Imported and built successfully on Fedora branches (EL branches are a WOP ;-))