Bug 2437480 - Review Request: rust-jsonrpcmsg - Rust library to serialize and deserialize JSON-RPC
Summary: Review Request: rust-jsonrpcmsg - Rust library to serialize and deserialize J...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-Legal
TreeView+ depends on / blocked
 
Reported: 2026-02-07 02:07 UTC by Rodolfo Olivieri
Modified: 2026-02-23 13:25 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-02-23 13:25:06 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Comment 1 Ben Beasley 2026-02-14 11:22:11 UTC
The crate contains JSONRPC standards documents in Markdown format that carry licenses I don’t recognize as approved for distribution in Fedora.


docs/jsonprc2.0_official_spec.md

Copyright (C) 2007-2010 by the JSON-RPC Working Group

This document and translations of it may be used to implement JSON-RPC, it may be copied and furnished to others, and derivative works that comment on or otherwise explain it or assist in its implementation may be prepared, copied, published and distributed, in whole or in part, without restriction of any kind, provided that the above copyright notice and this paragraph are included on all such copies and derivative works. However, this document itself may not bemodified in any way.

The limited permissions granted above are perpetual and will not be revoked.

This document and the information contained herein is provided "AS IS" and ALL WARRANTIES, EXPRESS OR IMPLIED are DISCLAIMED, INCLUDING BUT NOT LIMITED TO ANY WARRANTY THAT THE USE OF THE INFORMATION HEREIN WILL NOT INFRINGE ANY RIGHTS OR ANY IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE.


docs/jsonrpc1.0_official_spec.md

Copyright (C) 2005 JSON-RPC.ORG

This document and translations of it may be used to implement JSON-RPC, it may be copied and furnished to others, and derivative works that comment on or otherwise explain it or assist in its implementation may be prepared, copied, published and distributed, in whole or in part, without restriction of any kind, provided that the above copyright notice and this paragraph are included on all such copies and derivative works. However, this document itself may not be modified in any way.

The limited permissions granted above are perpetual and will not be revoked by JSON-RPC.org.

This document and the information contained herein is provided on an "AS IS" basis and json-rpc.org DISCLAIMS ALL WARRANTIES, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO ANY WARRANTY THAT THE USE OF THE INFORMATION HEREIN WILL NOT INFRINGE ANY RIGHTS OR ANY IMPLIED WARRANTIES OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE.


docs/jsonrpc2.0_specifications.md

License text missing, but is likely intended to be very similar considering https://www.jsonrpc.org/specification.


docs/json-rpc-Koebler-2008.md

No clear license attached.


The licenses of the first two could likely be acceptable for documentation in Fedora, but would need to be submitted and approved via https://gitlab.com/fedora/legal/fedora-license-data/-/issues. However, I am concerned that these Markdown documents don’t have clear “upstream” sources, and that they may in fact be modified in some way from the original documents, even if just by translating to Markdown – something their licenses expressly prohibit.

The third document is a little worse, because the license text is missing.

The fourth document is worse still, because it’s not clear that it *has* a license that allows redistribution.


Your best bet is probably to work with upstream and ask them to make a new release with the contents of docs/ excluded so you don’t have to worry about these files. Failing that, you could do something similar to https://src.fedoraproject.org/rpms/rust-fiat-crypto/blob/426eb67ee434e9563467e17fecf20892ff6e9b1c/f/gen_clean_tarball.sh to produce a modified crate archive and upload that to the lookaside cache instead.


Another issue I noticed is that license.txt contains the following:


Copyright 2025 David Heurtevent

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.


However, section 4.a of the Apache-2.0 license says,

You must give any other recipients of the Work or Derivative Works a copy of this License

which would seem to imply that the entire Apache-2.0 license text needs to be distributed in the crate. See also https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text.

Comment 2 Rodolfo Olivieri 2026-02-23 13:25:06 UTC
Hi, music! 

Sorry for this, but the package that required this dependency got updated and this is no longer needed (at least, for now). I will close this one. 

I appreciate the details in your review and for sure I learned something from it, so, thanks a lot for taking your time.


Note You need to log in before you can comment on or make changes to this bug.