Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://decathorpe.fedorapeople.org/rust-dtor.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-dtor-0.0.6-1.fc43.src.rpm Upstream URL: https://crates.io/crates/dtor Description: __attribute__((destructor)) for Rust. Fedora Account System Username: decathorpe
This is intentionally not the latest version: ctor v0.4.3 (required by bear, not the latest version) requires dtor v0.0.6 (not the latest version).
Note: LICENSE-* files are included in published crates starting in the version *after* the one targeted here.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10115236 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2438770-rust-dtor/fedora-rawhide-x86_64/10115236-rust-dtor/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is generated by rust2rpm, simplifying the review. The only changes are to handle missing license files in the published crate, which is correctly implemented, and to disable tests, which is adequately justified (a dependency is not packaged, and there are no tests in the published crate anyway). Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/dtor-0.0.6/LICENSE-APACHE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files OK: not a serious problem, due to reasonable rust2rpm design decisions ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 8 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2438770-rust- dtor/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Missing license files are already fixed upstream in a later release. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- dtor-devel , rust-dtor+default-devel , rust- dtor+__no_warn_on_missing_unsafe-devel , rust-dtor+proc_macro-devel , rust-dtor+used_linker-devel [?]: Package functions as described. No tests are included. [!]: Latest version is packaged. An older version is packaged to satisfy the dependencies of bear, which is a reasonable justification. [-]: Package does not include license text files separate from upstream. Upstream’s own license texts from GitHub are correctly and necessarily added. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=142249165 [!]: %check is present and all tests pass. Tests are disabled due to an unpackaged dependency, but there are no usable tests in the crate anyway. This is unfortunate, but the justification is adequate. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-dtor-devel-0.0.6-1.fc45.noarch.rpm rust-dtor+default-devel-0.0.6-1.fc45.noarch.rpm rust-dtor+__no_warn_on_missing_unsafe-devel-0.0.6-1.fc45.noarch.rpm rust-dtor+proc_macro-devel-0.0.6-1.fc45.noarch.rpm rust-dtor+used_linker-devel-0.0.6-1.fc45.noarch.rpm rust-dtor-0.0.6-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpw765q570')] checks: 32, packages: 6 rust-dtor+__no_warn_on_missing_unsafe-devel.noarch: E: spelling-error ('destructor', 'Summary(en_US) destructor -> destruct or, destruct-or, destruction') rust-dtor+__no_warn_on_missing_unsafe-devel.noarch: E: spelling-error ('destructor', '%description -l en_US destructor -> destruct or, destruct-or, destruction') rust-dtor+default-devel.noarch: E: spelling-error ('destructor', 'Summary(en_US) destructor -> destruct or, destruct-or, destruction') rust-dtor+default-devel.noarch: E: spelling-error ('destructor', '%description -l en_US destructor -> destruct or, destruct-or, destruction') rust-dtor+proc_macro-devel.noarch: E: spelling-error ('destructor', 'Summary(en_US) destructor -> destruct or, destruct-or, destruction') rust-dtor+proc_macro-devel.noarch: E: spelling-error ('destructor', '%description -l en_US destructor -> destruct or, destruct-or, destruction') rust-dtor+used_linker-devel.noarch: E: spelling-error ('destructor', 'Summary(en_US) destructor -> destruct or, destruct-or, destruction') rust-dtor+used_linker-devel.noarch: E: spelling-error ('destructor', '%description -l en_US destructor -> destruct or, destruct-or, destruction') rust-dtor.src: E: spelling-error ('destructor', 'Summary(en_US) destructor -> destruct or, destruct-or, destruction') rust-dtor.src: E: spelling-error ('destructor', '%description -l en_US destructor -> destruct or, destruct-or, destruction') rust-dtor-devel.noarch: E: spelling-error ('destructor', 'Summary(en_US) destructor -> destruct or, destruct-or, destruction') rust-dtor-devel.noarch: E: spelling-error ('destructor', '%description -l en_US destructor -> destruct or, destruct-or, destruction') 6 packages and 0 specfiles checked; 12 errors, 0 warnings, 31 filtered, 12 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 rust-dtor+default-devel.noarch: E: spelling-error ('destructor', 'Summary(en_US) destructor -> destruct or, destruct-or, destruction') rust-dtor+default-devel.noarch: E: spelling-error ('destructor', '%description -l en_US destructor -> destruct or, destruct-or, destruction') rust-dtor+proc_macro-devel.noarch: E: spelling-error ('destructor', 'Summary(en_US) destructor -> destruct or, destruct-or, destruction') rust-dtor+proc_macro-devel.noarch: E: spelling-error ('destructor', '%description -l en_US destructor -> destruct or, destruct-or, destruction') rust-dtor-devel.noarch: E: spelling-error ('destructor', 'Summary(en_US) destructor -> destruct or, destruct-or, destruction') rust-dtor-devel.noarch: E: spelling-error ('destructor', '%description -l en_US destructor -> destruct or, destruct-or, destruction') rust-dtor+__no_warn_on_missing_unsafe-devel.noarch: E: spelling-error ('destructor', 'Summary(en_US) destructor -> destruct or, destruct-or, destruction') rust-dtor+__no_warn_on_missing_unsafe-devel.noarch: E: spelling-error ('destructor', '%description -l en_US destructor -> destruct or, destruct-or, destruction') rust-dtor+used_linker-devel.noarch: E: spelling-error ('destructor', 'Summary(en_US) destructor -> destruct or, destruct-or, destruction') rust-dtor+used_linker-devel.noarch: E: spelling-error ('destructor', '%description -l en_US destructor -> destruct or, destruct-or, destruction') 5 packages and 0 specfiles checked; 10 errors, 0 warnings, 27 filtered, 10 badness; has taken 0.1 s Source checksums ---------------- https://crates.io/api/v1/crates/dtor/0.0.6/download#/dtor-0.0.6.crate : CHECKSUM(SHA256) this package : 97cbdf2ad6846025e8e25df05171abfb30e3ababa12ee0a0e44b9bbe570633a8 CHECKSUM(SHA256) upstream package : 97cbdf2ad6846025e8e25df05171abfb30e3ababa12ee0a0e44b9bbe570633a8 https://github.com/mmastrac/rust-ctor/raw/117b4d1/LICENSE-APACHE : CHECKSUM(SHA256) this package : a8ad31b1c3f40dca5a84119351b8fa8ddc868edd77fad8a8ebf6d8f2d16fa4ae CHECKSUM(SHA256) upstream package : a8ad31b1c3f40dca5a84119351b8fa8ddc868edd77fad8a8ebf6d8f2d16fa4ae https://github.com/mmastrac/rust-ctor/raw/117b4d1/LICENSE-MIT : CHECKSUM(SHA256) this package : bccaa8b6c09f94e81f06696e179dbe058464bbdfbc823b6d49cada1d71e84ac3 CHECKSUM(SHA256) upstream package : bccaa8b6c09f94e81f06696e179dbe058464bbdfbc823b6d49cada1d71e84ac3 Requires -------- rust-dtor-devel (rpmlib, GLIBC filtered): cargo rust-dtor+default-devel (rpmlib, GLIBC filtered): cargo crate(dtor) crate(dtor/__no_warn_on_missing_unsafe) crate(dtor/proc_macro) rust-dtor+__no_warn_on_missing_unsafe-devel (rpmlib, GLIBC filtered): cargo crate(dtor) rust-dtor+proc_macro-devel (rpmlib, GLIBC filtered): cargo crate(dtor) crate(dtor-proc-macro/default) rust-dtor+used_linker-devel (rpmlib, GLIBC filtered): cargo crate(dtor) Provides -------- rust-dtor-devel: crate(dtor) rust-dtor-devel rust-dtor+default-devel: crate(dtor/default) rust-dtor+default-devel rust-dtor+__no_warn_on_missing_unsafe-devel: crate(dtor/__no_warn_on_missing_unsafe) rust-dtor+__no_warn_on_missing_unsafe-devel rust-dtor+proc_macro-devel: crate(dtor/proc_macro) rust-dtor+proc_macro-devel rust-dtor+used_linker-devel: crate(dtor/used_linker) rust-dtor+used_linker-devel Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2438770 --mock-options=--enablerepo=local Buildroot used: fedora-rawhide-aarch64 Active plugins: Shell-api, Generic Disabled plugins: R, Python, Haskell, Java, SugarActivity, Perl, fonts, PHP, Ocaml, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thank you for the review!
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-dtor
Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2026-d9073ec8d5