Bug 2439825 - Review Request: rootlesskit - Linux-native "fake root" for implementing rootless containers
Summary: Review Request: rootlesskit - Linux-native "fake root" for implementing rootl...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Maxwell G
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-02-14 07:13 UTC by Gordon Messmer
Modified: 2026-02-26 02:16 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-02-25 22:45:47 UTC
Type: ---
Embargoed:
maxwell: fedora-review+


Attachments (Terms of Use)

Description Gordon Messmer 2026-02-14 07:13:24 UTC
Spec URL: https://src.fedoraproject.org/fork/gordonmessmer/rpms/golang-github-rootless-containers-rootlesskit/raw/rawhide/f/rootlesskit.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/7275/142227275/rootlesskit-2.3.6-6.fc43.src.rpm
Description: Linux-native "fake root" for implementing rootless containers
Fedora Account System Username: gordonmessmer

This is a re-review request for a package rename. The existing package is golang-github-rootless-containers-rootlesskit

I am not the owner of the existing package, so either alexsaezm or someone from @go-sig should approve the renaming process, but I'd like to help it along.

The spec was generated by "go2rpm --profile=vendor --name=rootlesskit -v 2.3.6 github.com/rootless-containers/rootlesskit", with updates to goipath, %gotest, and the Provides and Obsoletes macros to support the rename.

Comment 1 Maxwell G 2026-02-25 19:47:01 UTC
Vendored Go Package Review
==============

Thank you for handling the renaming/conversion!

This package was generated using go2rpm and Go Vendor Tools, which simplifies the review. Please note the post-import steps below.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The specfile is legible.
- [x] The SRPM contains a valid `go-vendor-tools.toml`.
    - The default `detector = "askalono"` is included unless there is
      justification.
    - Manual license overrides are correct.
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [x] There are no broad glob patterns in %files (e.g., `%{_bindir}/*`).
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the rest of the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org.
- [ ] Give go-sig privileges (at least commit) on the package. (https://docs.fedoraproject.org/en-US/fesco/SIG_policy/#_go_sig)
- [ ] Please also give @gotmax23 (me), @buckaroogeek (the other docker stack maintainer), and @alexsaezm (current golang-github-rootless-containers-rootlesskitx maintainer) admin privs on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Build the package for all Fedora branches.
- [ ] I will take care of retiring the old package on rawhide and branched/f44. Please ping me on Matrix when the package has been imported and built.

Thanks!

Source: <https://git.sr.ht/~gotmax23/fedora-scripts/tree/main/item/go-sig/vendored_review_template.md>

Comment 2 Gordon Messmer 2026-02-25 20:26:59 UTC
The Rename Policy requires the reviewer to explicitly state that they checked "proper Obsoletes and Provides". Could you reply with such an ack to ensure approval of the new repo?

Comment 3 Fedora Admin user for bugzilla script actions 2026-02-25 21:05:53 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rootlesskit

Comment 4 Maxwell G 2026-02-25 21:15:55 UTC
As for the Provides and Obsoletes, I did check them when I originally reviewed the PR, but looking again, I'd maybe make Obsoletes more constrained

```
Obsoletes: golang-github-rootless-containers-rootlesskit < 1.0.1-15
```

as the last EVR of the original package was 1.0.1-14 (https://src.fedoraproject.org/rpms/golang-github-rootless-containers-rootlesskit/c/a978924e5610f0d7ef8169b92792cf12921dae13?branch=rawhide).

Comment 5 Fedora Update System 2026-02-25 22:43:12 UTC
FEDORA-2026-414172a161 (rootlesskit-2.3.6-2.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-414172a161

Comment 6 Fedora Update System 2026-02-25 22:45:47 UTC
FEDORA-2026-414172a161 (rootlesskit-2.3.6-2.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2026-02-25 23:06:03 UTC
FEDORA-2026-fc83e1d514 (rootlesskit-2.3.6-2.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-fc83e1d514

Comment 8 Fedora Update System 2026-02-25 23:16:45 UTC
FEDORA-2026-56d52e9e8e (rootlesskit-2.3.6-2.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-56d52e9e8e

Comment 9 Fedora Update System 2026-02-25 23:17:21 UTC
FEDORA-2026-c287bd6026 (rootlesskit-2.3.6-2.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-c287bd6026

Comment 10 Gordon Messmer 2026-02-25 23:18:23 UTC
- [x] Add the package to release-monitoring.org.
- [x] Give go-sig privileges (at least commit) on the package. (https://docs.fedoraproject.org/en-US/fesco/SIG_policy/#_go_sig)
- [x] Please also give @gotmax23 (me), @buckaroogeek (the other docker stack maintainer), and @alexsaezm (current golang-github-rootless-containers-rootlesskitx maintainer) admin privs on the package
- [x] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [x] Build the package for all Fedora branches.

Comment 11 Fedora Update System 2026-02-26 01:37:57 UTC
FEDORA-2026-56d52e9e8e has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-56d52e9e8e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-56d52e9e8e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2026-02-26 01:53:10 UTC
FEDORA-2026-fc83e1d514 has been pushed to the Fedora 44 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-fc83e1d514 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-fc83e1d514

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2026-02-26 02:16:22 UTC
FEDORA-2026-c287bd6026 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-c287bd6026 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-c287bd6026

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.


Note You need to log in before you can comment on or make changes to this bug.