Spec URL: https://decathorpe.fedorapeople.org/rust-xcb.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-xcb-1.6.0-1.fc43.src.rpm Upstream URL: https://crates.io/crates/xcb Description: Rust safe bindings for XCB. Fedora Account System Username: decathorpe
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=142506720
This is a re-review request, the package was previously packaged for Fedora but was retired. It is a dependency of xwayland-satellite (via xcb-util-cursor and xcb-util-cursor-sys) and I'm working on un-vendoring its dependencies. I have chosen to package v1.6.0 on purpose despite it not being the latest release, because 1.7.0 introduces dependencies that are not (yet) satisfiable from Fedora repositories.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10154255 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2441037-rust-xcb/fedora-rawhide-x86_64/10154255-rust-xcb/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-xcb Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This looks basically sensible, but you can actually run the tests without going to unreasonable extremes: - patch out the “gl” dev-dependency and the “opengl_window” example that requires it - skip the “test_dynbuf_from_data_panic” test since it doesn’t panic in release mode - enable the “xkb” and “xinput” features since some of the doctests require them
Good catch! I've applied your suggestions: Spec URL: https://decathorpe.fedorapeople.org/rust-xcb.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-xcb-1.6.0-1.fc43.src.rpm rust2rpm.toml configuration: ``` [package] cargo-toml-patch-comments = [ "bump quick-xml build-dependency from v0.30 to v0.31", "drop example program that pulls in the \"gl\" dev-dependency", ] [requires] build = ["libxcb-devel"] lib = ["libxcb-devel"] [features] # enable features that are required by some doctests enable = ["xkb", "xinput"] [tests] skip = ["test::test_dynbuf_from_data_panic"] skip-exact = true comments = ["skip one test that does not panic as expected in release mode"] ```
Created attachment 2130815 [details] The .spec file difference from Copr build 10154255 to 10164919
Copr build: https://copr.fedorainfracloud.org/coprs/build/10164919 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2441037-rust-xcb/fedora-rawhide-x86_64/10164919-rust-xcb/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-xcb Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This looks great except for some unaccounted-for licenses in the XML files. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is exactly as generated by rust2rpm with the configuration file given in https://bugzilla.redhat.com/show_bug.cgi?id=2441037#c5, greatly simplifying the review. I acknowledge that this is a re-review for unretirement. Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/xcb-1.6.0/CHANGELOG.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files OK: not a serious problem; due to reasonable rust2rpm design decisions - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-xcb See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names OK: this is a review for unretirement. - The source files xml/*.xml are under a variety of licenses that are not necessarily the same as the “overall” MIT license of the crate. These need to be accounted for. Most of the xml/*.xml files appear to be under the (SPDX) X11 license. The exceptions are: - xml/dri3.xml and xml/present.xml appear to be HPND-sell-variant. - xml/render.xml, xml/sync.xml, and xml/xc_misc.xml say “See the file COPYING in this directory for licensing information,” but there is no such file. Looking upstream at https://cgit.freedesktop.org/xcb/proto/tree/src, there is no such file either, but one may probably safely assume that the root-level COPYING file is intended. This appears to be X11 license text, like most of the other XML files. Both X11 and HPND-sell-variant are allowed in Fedora. Please: - Point this out upstream - Suggest changing the SPDX expression for the crate from “MIT” to “MIT AND X11 AND HPND-sell-variant” in order to accurately reflect all of the source licenses. - Patch the license expression downstream One could probably make a case for collecting all of the license texts with their various copyright statements into a LICENSE-XML file or similar, but I don’t think this should be required for approval. The license texts are at least included with the “binary” packages, even if they are attached to the XML “sources.” ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "Historical Permission Notice and Disclaimer - sell variant and/or NTP License (legal disclaimer)", "*No copyright* MIT License". 57 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/20260224/2441037-rust-xcb/licensecheck.txt XML files are not MIT-licensed. See Issues. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. You might consider suggesting to upstream that they collect the XML license texts, including their various copyright statements, into a single file. This would likely be helpful for some users. I don’t consider this to be required for approval. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- xcb-devel , rust-xcb+default-devel , rust-xcb+as-raw-xcb-connection- devel , rust-xcb+composite-devel , rust-xcb+damage-devel , rust- xcb+debug_atom_names-devel , rust-xcb+dpms-devel , rust-xcb+dri2-devel , rust-xcb+dri3-devel , rust-xcb+ge-devel , rust-xcb+glx-devel , rust- xcb+libxcb_v1_14-devel , rust-xcb+present-devel , rust-xcb+randr-devel , rust-xcb+record-devel , rust-xcb+render-devel , rust-xcb+res-devel , rust-xcb+screensaver-devel , rust-xcb+shape-devel , rust-xcb+shm-devel , rust-xcb+sync-devel , rust-xcb+x11-devel , rust-xcb+xevie-devel , rust-xcb+xf86dri-devel , rust-xcb+xf86vidmode-devel , rust-xcb+xfixes- devel , rust-xcb+xinerama-devel , rust-xcb+xinput-devel , rust- xcb+xkb-devel , rust-xcb+xlib_xcb-devel , rust-xcb+xprint-devel , rust-xcb+xselinux-devel , rust-xcb+xtest-devel , rust-xcb+xv-devel , rust-xcb+xvmc-devel [x]: Package functions as described. (available tests pass) [!]: Latest version is packaged. Packaging a slightly older version is adequately justified in https://bugzilla.redhat.com/show_bug.cgi?id=2441037#c2. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=142736740 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-xcb-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+default-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+as-raw-xcb-connection-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+composite-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+damage-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+debug_atom_names-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+dpms-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+dri2-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+dri3-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+ge-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+glx-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+libxcb_v1_14-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+present-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+randr-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+record-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+render-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+res-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+screensaver-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+shape-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+shm-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+sync-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+x11-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+xevie-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+xf86dri-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+xf86vidmode-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+xfixes-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+xinerama-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+xinput-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+xkb-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+xlib_xcb-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+xprint-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+xselinux-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+xtest-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+xv-devel-1.6.0-1.fc45.noarch.rpm rust-xcb+xvmc-devel-1.6.0-1.fc45.noarch.rpm rust-xcb-1.6.0-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpod_aej1x')] checks: 32, packages: 36 36 packages and 0 specfiles checked; 0 errors, 0 warnings, 212 filtered, 0 badness; has taken 1.0 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 35 35 packages and 0 specfiles checked; 0 errors, 0 warnings, 207 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://crates.io/api/v1/crates/xcb/1.6.0/download#/xcb-1.6.0.crate : CHECKSUM(SHA256) this package : f07c123b796139bfe0603e654eaf08e132e52387ba95b252c78bad3640ba37ea CHECKSUM(SHA256) upstream package : f07c123b796139bfe0603e654eaf08e132e52387ba95b252c78bad3640ba37ea Requires -------- rust-xcb-devel (rpmlib, GLIBC filtered): (crate(bitflags/default) >= 1.3.2 with crate(bitflags/default) < 2.0.0~) (crate(libc/default) >= 0.2.102 with crate(libc/default) < 0.3.0~) (crate(quick-xml/default) >= 0.31.0 with crate(quick-xml/default) < 0.32.0~) /usr/bin/bash cargo libxcb-devel rust-xcb+default-devel (rpmlib, GLIBC filtered): cargo crate(xcb) crate(xcb/libxcb_v1_14) rust-xcb+as-raw-xcb-connection-devel (rpmlib, GLIBC filtered): (crate(as-raw-xcb-connection/default) >= 1.0.0 with crate(as-raw-xcb-connection/default) < 2.0.0~) cargo crate(xcb) rust-xcb+composite-devel (rpmlib, GLIBC filtered): cargo crate(xcb) crate(xcb/xfixes) rust-xcb+damage-devel (rpmlib, GLIBC filtered): cargo crate(xcb) crate(xcb/xfixes) rust-xcb+debug_atom_names-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+dpms-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+dri2-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+dri3-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+ge-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+glx-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+libxcb_v1_14-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+present-devel (rpmlib, GLIBC filtered): cargo crate(xcb) crate(xcb/render) crate(xcb/sync) crate(xcb/xfixes) rust-xcb+randr-devel (rpmlib, GLIBC filtered): cargo crate(xcb) crate(xcb/render) rust-xcb+record-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+render-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+res-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+screensaver-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+shape-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+shm-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+sync-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+x11-devel (rpmlib, GLIBC filtered): (crate(x11/default) >= 2.19.0 with crate(x11/default) < 3.0.0~) (crate(x11/xlib) >= 2.19.0 with crate(x11/xlib) < 3.0.0~) cargo crate(xcb) rust-xcb+xevie-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+xf86dri-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+xf86vidmode-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+xfixes-devel (rpmlib, GLIBC filtered): cargo crate(xcb) crate(xcb/render) crate(xcb/shape) rust-xcb+xinerama-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+xinput-devel (rpmlib, GLIBC filtered): cargo crate(xcb) crate(xcb/xfixes) rust-xcb+xkb-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+xlib_xcb-devel (rpmlib, GLIBC filtered): (crate(x11/default) >= 2.19.0 with crate(x11/default) < 3.0.0~) (crate(x11/xlib) >= 2.19.0 with crate(x11/xlib) < 3.0.0~) cargo crate(xcb) rust-xcb+xprint-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+xselinux-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+xtest-devel (rpmlib, GLIBC filtered): cargo crate(xcb) rust-xcb+xv-devel (rpmlib, GLIBC filtered): cargo crate(xcb) crate(xcb/shm) rust-xcb+xvmc-devel (rpmlib, GLIBC filtered): cargo crate(xcb) crate(xcb/xv) Provides -------- rust-xcb-devel: crate(xcb) rust-xcb-devel rust-xcb+default-devel: crate(xcb/default) rust-xcb+default-devel rust-xcb+as-raw-xcb-connection-devel: crate(xcb/as-raw-xcb-connection) rust-xcb+as-raw-xcb-connection-devel rust-xcb+composite-devel: crate(xcb/composite) rust-xcb+composite-devel rust-xcb+damage-devel: crate(xcb/damage) rust-xcb+damage-devel rust-xcb+debug_atom_names-devel: crate(xcb/debug_atom_names) rust-xcb+debug_atom_names-devel rust-xcb+dpms-devel: crate(xcb/dpms) rust-xcb+dpms-devel rust-xcb+dri2-devel: crate(xcb/dri2) rust-xcb+dri2-devel rust-xcb+dri3-devel: crate(xcb/dri3) rust-xcb+dri3-devel rust-xcb+ge-devel: crate(xcb/ge) rust-xcb+ge-devel rust-xcb+glx-devel: crate(xcb/glx) rust-xcb+glx-devel rust-xcb+libxcb_v1_14-devel: crate(xcb/libxcb_v1_14) rust-xcb+libxcb_v1_14-devel rust-xcb+present-devel: crate(xcb/present) rust-xcb+present-devel rust-xcb+randr-devel: crate(xcb/randr) rust-xcb+randr-devel rust-xcb+record-devel: crate(xcb/record) rust-xcb+record-devel rust-xcb+render-devel: crate(xcb/render) rust-xcb+render-devel rust-xcb+res-devel: crate(xcb/res) rust-xcb+res-devel rust-xcb+screensaver-devel: crate(xcb/screensaver) rust-xcb+screensaver-devel rust-xcb+shape-devel: crate(xcb/shape) rust-xcb+shape-devel rust-xcb+shm-devel: crate(xcb/shm) rust-xcb+shm-devel rust-xcb+sync-devel: crate(xcb/sync) rust-xcb+sync-devel rust-xcb+x11-devel: crate(xcb/x11) rust-xcb+x11-devel rust-xcb+xevie-devel: crate(xcb/xevie) rust-xcb+xevie-devel rust-xcb+xf86dri-devel: crate(xcb/xf86dri) rust-xcb+xf86dri-devel rust-xcb+xf86vidmode-devel: crate(xcb/xf86vidmode) rust-xcb+xf86vidmode-devel rust-xcb+xfixes-devel: crate(xcb/xfixes) rust-xcb+xfixes-devel rust-xcb+xinerama-devel: crate(xcb/xinerama) rust-xcb+xinerama-devel rust-xcb+xinput-devel: crate(xcb/xinput) rust-xcb+xinput-devel rust-xcb+xkb-devel: crate(xcb/xkb) rust-xcb+xkb-devel rust-xcb+xlib_xcb-devel: crate(xcb/xlib_xcb) rust-xcb+xlib_xcb-devel rust-xcb+xprint-devel: crate(xcb/xprint) rust-xcb+xprint-devel rust-xcb+xselinux-devel: crate(xcb/xselinux) rust-xcb+xselinux-devel rust-xcb+xtest-devel: crate(xcb/xtest) rust-xcb+xtest-devel rust-xcb+xv-devel: crate(xcb/xv) rust-xcb+xv-devel rust-xcb+xvmc-devel: crate(xcb/xvmc) rust-xcb+xvmc-devel Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2441037 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Perl, fonts, Ocaml, PHP, Python, C/C++, Haskell, SugarActivity, Java, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
I just noticed that there is a dependency on /usr/bin/bash due to gen.sh. That file says, # This is a script that runs the code generation and export a copy of it under gen/$1. # This is NOT the main code generation script, but a tool to help looking at the generated code # (which is otherwise lost somewhere under target/) and performing diffs with previous versions. so you can and should exclude gen.sh to avoid the bash dependency.