Spec URL: https://decathorpe.fedorapeople.org/rust-hecs-macros.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-hecs-macros-0.10.0-1.fc43.src.rpm Upstream URL: https://crates.io/crates/hecs-macros Description: Procedural macro definitions for hecs. Fedora Account System Username: decathorpe
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=142507003
Copr build: https://copr.fedorainfracloud.org/coprs/build/10154257 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2441039-rust-hecs-macros/fedora-rawhide-x86_64/10154257-rust-hecs-macros/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
APPROVED Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is generated with rust2rpm, simplifying the review. Upstream’s license texts were correctly and necessarily patched in, and https://github.com/Ralith/hecs/pull/433 will fix this for future releases. The latest version is not packaged, but this is justified in https://bugzilla.redhat.com/show_bug.cgi?id=2441041#c1. Tests are disabled, with adequate justification. The crate does not contain any tests anyway. Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/hecs- macros-0.10.0/LICENSE-APACHE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files OK: not a serious problem; due to reasonable rust2rpm design decisions. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0". 7 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2441039-rust-hecs-macros/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. https://github.com/Ralith/hecs/pull/433 [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- hecs-macros-devel , rust-hecs-macros+default-devel [?]: Package functions as described. Tests are disabled, with adequate justification. The crate does not contain any tests anyway. [!]: Latest version is packaged. The latest version is not packaged, but this is justified in https://bugzilla.redhat.com/show_bug.cgi?id=2441041#c1. [-]: Package does not include license text files separate from upstream. Upstream’s license files are correctly and necessarily patched in. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=142507003 [!]: %check is present and all tests pass. Tests are disabled, with adequate justification. The crate does not contain any tests anyway. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-hecs-macros-devel-0.10.0-1.fc45.noarch.rpm rust-hecs-macros+default-devel-0.10.0-1.fc45.noarch.rpm rust-hecs-macros-0.10.0-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0kr2aaj2')] checks: 32, packages: 3 rust-hecs-macros-devel.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 13 filtered, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 rust-hecs-macros-devel.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 9 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/hecs-macros/0.10.0/download#/hecs-macros-0.10.0.crate : CHECKSUM(SHA256) this package : 052fc25b12dc326082605cd2098eb76050a72fa0c0e9ea7faaa3f58b565fc970 CHECKSUM(SHA256) upstream package : 052fc25b12dc326082605cd2098eb76050a72fa0c0e9ea7faaa3f58b565fc970 https://github.com/Ralith/hecs/raw/refs/tags/v0.10.5/LICENSE-APACHE : CHECKSUM(SHA256) this package : cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30 CHECKSUM(SHA256) upstream package : cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30 https://github.com/Ralith/hecs/raw/refs/tags/v0.10.5/LICENSE-MIT : CHECKSUM(SHA256) this package : 10e619056312012c40e4900844f3f892551ee716bbd44eeecb7d6ba2682b6dec CHECKSUM(SHA256) upstream package : 10e619056312012c40e4900844f3f892551ee716bbd44eeecb7d6ba2682b6dec Requires -------- rust-hecs-macros-devel (rpmlib, GLIBC filtered): (crate(proc-macro2/default) >= 1.0.1 with crate(proc-macro2/default) < 2.0.0~) (crate(quote/default) >= 1.0.3 with crate(quote/default) < 2.0.0~) (crate(syn) >= 2.0.0 with crate(syn) < 3.0.0~) (crate(syn/clone-impls) >= 2.0.0 with crate(syn/clone-impls) < 3.0.0~) (crate(syn/derive) >= 2.0.0 with crate(syn/derive) < 3.0.0~) (crate(syn/parsing) >= 2.0.0 with crate(syn/parsing) < 3.0.0~) (crate(syn/printing) >= 2.0.0 with crate(syn/printing) < 3.0.0~) (crate(syn/proc-macro) >= 2.0.0 with crate(syn/proc-macro) < 3.0.0~) (crate(syn/visit-mut) >= 2.0.0 with crate(syn/visit-mut) < 3.0.0~) cargo rust-hecs-macros+default-devel (rpmlib, GLIBC filtered): cargo crate(hecs-macros) Provides -------- rust-hecs-macros-devel: crate(hecs-macros) rust-hecs-macros-devel rust-hecs-macros+default-devel: crate(hecs-macros/default) rust-hecs-macros+default-devel Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2441039 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: SugarActivity, R, fonts, Python, Java, PHP, C/C++, Ocaml, Haskell, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thanks for the review!
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-hecs-macros
FEDORA-2026-52687ebbef (rust-hecs-0.10.5-1.fc45 and rust-hecs-macros-0.10.0-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-52687ebbef
FEDORA-2026-52687ebbef (rust-hecs-0.10.5-1.fc45 and rust-hecs-macros-0.10.0-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.