Fedora Account System
Red Hat Associate
Red Hat Customer
Description: Popout3D lets you create stereoscopic images from ordinary photographs. Fedora Account System Username: popoutapps Spec URL: https://github.com/PopoutApps/RPM/blob/main/popout3d.spec SRPM URL: https://github.com/PopoutApps/popout3d/releases/download/v1.6.45/popout3d-1.6.45-1.fc43.src.rpm Reproducible: Always Steps to Reproduce: N/A Actual Results: N/A Expected Results: N/A Additional Information: N/A
The ticket summary is not in the correct format. Expected: Review Request: <main package name here> - <short summary here> Found: Review Request: Popout3D 3D image creator and viewer As a consequence, the package name cannot be parsed and submitted to be automatically build. Please modify the ticket summary and trigger a build by typing [fedora-review-service-build]. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/10179949 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2441967-popout3d/fedora-rawhide-x86_64/10179949-popout3d/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Links need to be to raw files that can be downloaded using wget. Consider creating a repository in https://copr.fedorainfracloud.org to test builds on different architectures.
Spec URL: https://raw.githubusercontent.com/PopoutApps/RPM/main/popout3d.spec SRPM URL: https://github.com/PopoutApps/popout3d/releases/download/v1.6.45/popout3d-1.6.45-1.fc43.src.rpm [fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/10189677 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2441967-popout3d/fedora-rawhide-x86_64/10189677-popout3d/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10189690 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2441967-popout3d/fedora-rawhide-x86_64/10189690-popout3d/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://raw.githubusercontent.com/PopoutApps/RPM/main/popout3d.spec SRPM URL: https://github.com/PopoutApps/popout3d/releases/download/v1.6.47/popout3d-1.6.47-1.fc43.src.rpm [fedora-review-service-build]
Created attachment 2132248 [details] The .spec file difference from Copr build 10189690 to 10195009
Copr build: https://copr.fedorainfracloud.org/coprs/build/10195009 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2441967-popout3d/fedora-rawhide-x86_64/10195009-popout3d/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The "Requires: hugin" is because the Python script uses Hugin's align_image_stack. [fedora-review-service-build]
Comment removed on request as it was posted in error.
> # Python so nothing to compile. > %global debug_package %{nil} If this is a pure-python package, this is probably not needed. rpmbuild should figure out that no new executables are created, hence no debuginfo. > %{_datadir}/applications/popout3d.desktop > %{_datadir}/metainfo/popout3d.metainfo.xml These should be ran through "desktop-file-validate" and "appstream-util validate-relax --nonet". https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ > %post > update-desktop-database&> /dev/null || : > %postun > update-desktop-database&> /dev/null || : These aren't needed since at least Fedora 30.
Thanks Artur, I've removed the lines you remarked upon and run those checks again. No problems. I don't think I need to rebuild this and upload it to GitHub for those. Let me know if I do.
Obviously I'll upload it when there are no more problems.
Lines removed and committed on GitHub.
> Source0: popout3d-%{version}.tar.gz This should ideally be a downloadable URL. As the main source is on GitHub, you can use: "https://github.com/PopoutApps/popout3d/archive/v%{version}/popout3d-%{version}.tar.gz" > ...and run those checks again. No problems. I haven't worded this clearly enough - the files should be validated *during the package build*. %check is arguably the best place to do that.
Thanks Artur. "As the main source is on GitHub" The spec now has: Source0: https://github.com/PopoutApps/popout3d/archive/v%{version}/popout3d-%{version}.tar.gz "%check is arguably the best place to do that." The spec now has: %check desktop-file-validate popout3d.desktop appstream-util validate-relax --nonet popout3d.metainfo.xml I'm assuming that at this stage, the files have been unpacked so don't need a URL.
You need to validate the *installed* files. Move the %check section after %install and validate the files inside %{buildroot}.
I have done as you suggested.
Artur I have done this "Move the %check section after %install and validate the files inside %{buildroot}." I have also reduced the requirement for hugin to hugin-base and uploaded the new spec file. I'm testing this on a clean machine, I've spotted that a directory was not being created and fixed the script. Can I leave off creating another release until I get some more feedback and probably have to make more corrections?
Have created a new release for this.