Spec URL: https://gotmax23.fedorapeople.org/reviews/python-multiregex/python-multiregex.spec SRPM URL: https://gotmax23.fedorapeople.org/reviews/python-multiregex/python-multiregex-2.0.3-1.fc42.src.rpm Description: Quickly match many regexes against a string. Provides 2-10x speedups over naïve regex matching. Fedora Account System Username: gotmax23
Spec URL: https://gotmax23.fedorapeople.org/reviews/python-multiregex/python-multiregex.spec SRPM URL: https://gotmax23.fedorapeople.org/reviews/python-multiregex/python-multiregex-2.0.3-1.fc45.src.rpm Upstream patches
Spec URL: https://gotmax23.fedorapeople.org/reviews/python-multiregex/python-multiregex.spec SRPM URL: https://gotmax23.fedorapeople.org/reviews/python-multiregex/python-multiregex-2.0.3-1.fc42.src.rpm Fix rpmautospec-mangled SRPM
I was considering reviewing this, but I see Benson has taken it. That’s great – thanks, Benson! I’ll go ahead and post the findings from my incomplete preliminary review as a supplement for Benson’s pending review. ===== Issues ===== - I’m happy to see that you offered the build-system patch upstream. Please add a comment to the spec file referencing https://github.com/Quantco/multiregex/pull/100 when you import the package. - Consider packaging CHANGELOG.rst as documentation. - Please remove the period at the end of the Summary. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description ===== Notes ===== - You are no longer required to explicitly BR python3-devel when using %pyproject_buildrequires; see https://pagure.io/packaging-committee/pull-request/1379 and https://pagure.io/packaging-committee/pull-request/1384. However, doing so is harmless and is not an error.
Spec URL: https://gotmax23.fedorapeople.org/reviews/python-multiregex/python-multiregex.spec SRPM URL: https://gotmax23.fedorapeople.org/reviews/python-multiregex/python-multiregex-2.0.3-1.fc42.src.rpm Fix summary and %doc
Created attachment 2131076 [details] Enable docs to build
Created attachment 2131077 [details] Spec file that builds docs
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "*No copyright* GNU Lesser General Public License, Version 2.1 and/or MIT License and/or zlib License". 33 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/python- multiregex/2442941-python-multiregex/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.14/site- packages, /usr/lib/python3.14 [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3947 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-multiregex-2.0.3-1.fc45.noarch.rpm python-multiregex-2.0.3-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpuz2m8aje')] checks: 32, packages: 2 python-multiregex.src: W: summary-ended-with-dot Quickly match many regexes against a string. python3-multiregex.noarch: W: summary-ended-with-dot Quickly match many regexes against a string. python-multiregex.src: E: spelling-error ('regexes', "Summary(en_US) regexes -> regexps, regex's, reg exes") python-multiregex.src: E: spelling-error ('regexes', "%description -l en_US regexes -> regexps, regex's, reg exes") python-multiregex.src: E: spelling-error ('naïve', '%description -l en_US naïve -> nave, naive') python3-multiregex.noarch: E: spelling-error ('regexes', "Summary(en_US) regexes -> regexps, regex's, reg exes") python3-multiregex.noarch: E: spelling-error ('regexes', "%description -l en_US regexes -> regexps, regex's, reg exes") python3-multiregex.noarch: E: spelling-error ('naïve', '%description -l en_US naïve -> nave, naive') 2 packages and 0 specfiles checked; 6 errors, 2 warnings, 7 filtered, 6 badness; has taken 0.6 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-multiregex.noarch: W: summary-ended-with-dot Quickly match many regexes against a string. python3-multiregex.noarch: E: spelling-error ('regexes', "Summary(en_US) regexes -> regexps, regex's, reg exes") python3-multiregex.noarch: E: spelling-error ('regexes', "%description -l en_US regexes -> regexps, regex's, reg exes") python3-multiregex.noarch: E: spelling-error ('naïve', '%description -l en_US naïve -> nave, naive') 1 packages and 0 specfiles checked; 3 errors, 1 warnings, 3 filtered, 3 badness; has taken 0.1 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/m/multiregex/multiregex-2.0.3.tar.gz : CHECKSUM(SHA256) this package : 875ecb79cada5ae4c5d26bad1eb3f82f003c3d1d22451363a01c98644a5bf20e CHECKSUM(SHA256) upstream package : 875ecb79cada5ae4c5d26bad1eb3f82f003c3d1d22451363a01c98644a5bf20e Requires -------- python3-multiregex (rpmlib, GLIBC filtered): python(abi) python3.14dist(pyahocorasick) Provides -------- python3-multiregex: python-multiregex python3-multiregex python3.14-multiregex python3.14dist(multiregex) python3dist(multiregex) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2442941 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: R, Haskell, PHP, fonts, SugarActivity, Java, C/C++, Ocaml, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Ignore warning about summary ending with a dot,ran this on the first posted spec file. b) Consider packaging the documentation. An example build: https://koji.fedoraproject.org/koji/taskinfo?taskID=142758319 There are attachments with a patch and spec file modifications to enable this. c) Approved. d) Review of https://bugzilla.redhat.com/show_bug.cgi?id=2440337 would be appreciated if time allows.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-multiregex
FEDORA-2026-7375ce4f6e (python-multiregex-2.0.3-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-7375ce4f6e
FEDORA-2026-7375ce4f6e (python-multiregex-2.0.3-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.