Red Hat Bugzilla – Bug 244356
Review Request: xapian-bindings - Bindings for Xapian
Last modified: 2010-06-11 00:26:20 EDT
Spec URL: http://dev.laptop.org/~marco/xapian-bindings.spec SRPM URL: http://dev.laptop.org/~marco/xapian-bindings-0.9.10.1-2.2.svn8397.src.rpm Description: Xapian is an Open Source Probabilistic Information Retrieval Library. It offers a highly adaptable toolkit that allows developers to easily add advanced indexing and search facilities to applications. This package provides the files needed for scripts which use Xapian.
For the same reasons as for bug#244355, please package Xapian 1.0.1 instead.
Updated to 1.0.1 http://dev.laptop.org/~marco/xapian-bindings.spec http://dev.laptop.org/~marco/xapian-bindings-1.0.1-1.src.rpm
E: xapian-bindings no-binary The package should be of the noarch architecture because it doesn't contain any binaries.
any reason to split docs in xapian-bindings ?? why not to include in in xapian-bindings-python
xapian-bindings also contains bindings for csharp, java, ruby etc. We are not building them right now but we might want to do it in the future. I'd happily do away with the doc only package, just not sure how to do it since the docs are common to all the bindings. About noarch. If I add "BuildArch: noarch" to the main package the build fails because the debug info files are created but not packaged. I can only make it work by adding "BuildArch: i386" to the python subpackage, which obviously is wrong. Suggestions on how to fix it?
As discussed on irc, I moved the docs file to the python package. We are not building the base xapian-bindings package anymore. http://dev.laptop.org/~marco/xapian-bindings.spec http://dev.laptop.org/~marco/xapian-bindings-1.0.1-1.src.rpm
remove Requires: %{name} = %{version} and bump release and update links
Done. http://dev.laptop.org/~marco/xapian-bindings.spec http://dev.laptop.org/~marco/xapian-bindings-1.0.1-2.src.rpm
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPMs. + source files match upstream. 3280974b85acf143d667866a8a4a4d7c xapian-bindings-1.0.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. - dist tag is NOT present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc files are present. + no -devel subpackage exists. + no .la files. + no translations available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets used. APPROVED.
New Package CVS Request ======================= Package Name: xapian-bindings Short Description: Bindings for the Xapian Information Retrieval Library Owners: mpg@redhat.com Branches: OLPC-2 InitialCC: mpg@redhat.com
CVS done.
Package Change Request ====================== Package Name: xapian-bindings New Branches: F-7 Updated Fedora Owners: mpg@redhat.com, adel.gadllah@gmail.com
cvs done.
Package Change Request ====================== Package Name: xapian-bindings New Branches: EL-6 Owners: pbrobinson sdz