Spec URL: https://peter.fedorapeople.org/packages/re-review/erlang-riak_api.spec SRPM URL: https://peter.fedorapeople.org/packages/re-review/erlang-riak_api-3.0.16-1.fc43.src.rpm Description: This OTP application encapsulates services for presenting Riak's public-facing interfaces. Currently this means a generic interface for exposing Protocol Buffers-based services; HTTP services via Webmachine will be moved here at a later time. Fedora Account System Username: peter Koji scratch build for Rawhide: * https://koji.fedoraproject.org/koji/taskinfo?taskID=142851626
You should ask upstream to include the license file and include a link to the SPEC (even if they do not respond). Other than that, the package looks good! Issues: ======= - [Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/erlang-riak_api See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names] Not an issue; this is an unretirement. - You should ask upstream to include the license file: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0". 13 files have unknown license. Detailed output of licensecheck in /home/till/fedora/reviews/2443560-erlang-riak_api/licensecheck.txt [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1337 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: erlang-riak_api-3.0.16-1.fc45.noarch.rpm erlang-riak_api-3.0.16-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_q9z4nkz')] checks: 32, packages: 2 erlang-riak_api.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_api-3.0.16/ebin/riak_api_app.beam /builddir/build/BUILD/erlang-riak_api-3.0.16-build/riak_api-riak_kv-3.0.16/src/riak_api_app.erl erlang-riak_api.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_api-3.0.16/ebin/riak_api_basic_pb_service.beam /builddir/build/BUILD/erlang-riak_api-3.0.16-build/riak_api-riak_kv-3.0.16/src/riak_api_basic_pb_service.erl erlang-riak_api.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_api-3.0.16/ebin/riak_api_pb_frame.beam /builddir/build/BUILD/erlang-riak_api-3.0.16-build/riak_api-riak_kv-3.0.16/src/riak_api_pb_frame.erl erlang-riak_api.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_api-3.0.16/ebin/riak_api_pb_listener.beam /builddir/build/BUILD/erlang-riak_api-3.0.16-build/riak_api-riak_kv-3.0.16/src/riak_api_pb_listener.erl erlang-riak_api.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_api-3.0.16/ebin/riak_api_pb_registrar.beam /builddir/build/BUILD/erlang-riak_api-3.0.16-build/riak_api-riak_kv-3.0.16/src/riak_api_pb_registrar.erl erlang-riak_api.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_api-3.0.16/ebin/riak_api_pb_registration_helper.beam /builddir/build/BUILD/erlang-riak_api-3.0.16-build/riak_api-riak_kv-3.0.16/src/riak_api_pb_registration_helper.erl erlang-riak_api.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_api-3.0.16/ebin/riak_api_pb_server.beam /builddir/build/BUILD/erlang-riak_api-3.0.16-build/riak_api-riak_kv-3.0.16/src/riak_api_pb_server.erl erlang-riak_api.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_api-3.0.16/ebin/riak_api_pb_service.beam /builddir/build/BUILD/erlang-riak_api-3.0.16-build/riak_api-riak_kv-3.0.16/src/riak_api_pb_service.erl erlang-riak_api.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_api-3.0.16/ebin/riak_api_pb_sup.beam /builddir/build/BUILD/erlang-riak_api-3.0.16-build/riak_api-riak_kv-3.0.16/src/riak_api_pb_sup.erl erlang-riak_api.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_api-3.0.16/ebin/riak_api_ssl.beam /builddir/build/BUILD/erlang-riak_api-3.0.16-build/riak_api-riak_kv-3.0.16/src/riak_api_ssl.erl erlang-riak_api.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_api-3.0.16/ebin/riak_api_stat.beam /builddir/build/BUILD/erlang-riak_api-3.0.16-build/riak_api-riak_kv-3.0.16/src/riak_api_stat.erl erlang-riak_api.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_api-3.0.16/ebin/riak_api_sup.beam /builddir/build/BUILD/erlang-riak_api-3.0.16-build/riak_api-riak_kv-3.0.16/src/riak_api_sup.erl erlang-riak_api.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_api-3.0.16/ebin/riak_api_web.beam /builddir/build/BUILD/erlang-riak_api-3.0.16-build/riak_api-riak_kv-3.0.16/src/riak_api_web.erl erlang-riak_api.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_api-3.0.16/ebin/riak_api_web_security.beam /builddir/build/BUILD/erlang-riak_api-3.0.16-build/riak_api-riak_kv-3.0.16/src/riak_api_web_security.erl erlang-riak_api.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_api-3.0.16/ebin/riak_api_wm_urlmap.beam /builddir/build/BUILD/erlang-riak_api-3.0.16-build/riak_api-riak_kv-3.0.16/src/riak_api_wm_urlmap.erl erlang-riak_api.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_api-3.0.16/ebin/riak_core_pb_bucket.beam /builddir/build/BUILD/erlang-riak_api-3.0.16-build/riak_api-riak_kv-3.0.16/src/riak_core_pb_bucket.erl erlang-riak_api.noarch: W: beam-was-not-recompiled /usr/share/erlang/lib/riak_api-3.0.16/ebin/riak_core_pb_bucket_type.beam /builddir/build/BUILD/erlang-riak_api-3.0.16-build/riak_api-riak_kv-3.0.16/src/riak_core_pb_bucket_type.erl 2 packages and 0 specfiles checked; 0 errors, 17 warnings, 7 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 3 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://github.com/basho/riak_api/archive/riak_kv-3.0.16/riak_api-3.0.16.tar.gz : CHECKSUM(SHA256) this package : c5f8340a6beb66744c5669e651b29048bbd845d79fa1caf413d1348aef30d6ae CHECKSUM(SHA256) upstream package : c5f8340a6beb66744c5669e651b29048bbd845d79fa1caf413d1348aef30d6ae Requires -------- erlang-riak_api (rpmlib, GLIBC filtered): erlang-erts(x86-64) erlang-exometer_core erlang-inets(x86-64) erlang-kernel(x86-64) erlang-lager erlang-mochiweb erlang-public_key(x86-64) erlang-riak_core erlang-riak_pb erlang-ssl(x86-64) erlang-stdlib(x86-64) erlang-webmachine Provides -------- erlang-riak_api: erlang-riak_api Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2443560 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: R, SugarActivity, Java, C/C++, fonts, Ocaml, Haskell, Perl, Python, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Copr build: https://copr.fedorainfracloud.org/coprs/build/10179946 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2443560-erlang-riak_api/fedora-rawhide-x86_64/10179946-erlang-riak_api/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Till Hofmann from comment #1) > You should ask upstream to include the license file and include a link to > the SPEC (even if they do not respond). Other than that, the package looks > good! Done. Just opened an issue upstream - https://github.com/OpenRiak/riak_api/issues/1
Package approved! Please add a link to the issue to the SPEC.
FEDORA-2026-c270423bcb (erlang-riak_api-3.0.16-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2026-c270423bcb
FEDORA-2026-4c140d3d49 (erlang-riak_api-3.0.16-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-4c140d3d49
FEDORA-2026-c270423bcb has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-c270423bcb \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-c270423bcb See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-4c140d3d49 has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-4c140d3d49 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-4c140d3d49 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.