Bug 2443709 - Review Request: rust-hfsplus - Read-only HFS+ / HFSX filesystem parser
Summary: Review Request: rust-hfsplus - Read-only HFS+ / HFSX filesystem parser
Keywords:
Status: POST
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-03-01 21:38 UTC by Davide Cavalca
Modified: 2026-08-19 13:00 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2026-03-01 21:38:25 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-hfsplus/rust-hfsplus.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-hfsplus/rust-hfsplus-0.2.3-1.fc45.src.rpm
Upstream URL: https://crates.io/crates/hfsplus

Description:
Read-only HFS+ / HFSX filesystem parser.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2026-03-01 21:38:28 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=142911566

Comment 2 Davide Cavalca 2026-03-01 21:38:42 UTC
$ cat rust2rpm.toml 
[package]
extra-sources = [
  { number = 2, file = "https://github.com/Dil4rd/dpp/raw/refs/tags/v0.3.0/LICENSE", comments = ["https://github.com/Dil4rd/dpp/pull/2"] },
]
license-files = ["LICENSE"]

[scripts]
prep.pre = [
  "cp -p %SOURCE2 .",
]

Comment 3 Fedora Review Service 2026-03-01 21:40:44 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10181462
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2443709-rust-hfsplus/fedora-rawhide-x86_64/10181462-rust-hfsplus/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fabio Valentini 2026-08-19 13:00:16 UTC
Package was generated with rust2rpm, simplifying the review.

Please update to the latest version (v0.2.4) before import, if possible.
It includes the fix for the missing license file, so you can drop the downstream addition.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
🫤 latest version of the crate is packaged:
   version 0.2.3 is packaged here, 0.2.4 is available
✅ license matches upstream specification and is acceptable for Fedora
🫤 license file is included with %license in %files:
   The project license text is temporarily included manually,
   but the latest version includes it in published source tarballs.
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)


Note You need to log in before you can comment on or make changes to this bug.