Spec URL: https://www.techie.net/~talbert/wxWidgets.spec SRPM URL: https://www.techie.net/~talbert/wxWidgets-3.3.2-1.fc45.src.rpm Description: wxWidgets is a C++ cross-platform GUI library, offering classes for all common GUI controls as well as a comprehensive set of helper classes for most common application tasks, ranging from networking to HTML display and image manipulation. Fedora Account System Username: swt2c
Taking this review.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10181754 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2443717-wxwidgets/fedora-rawhide-x86_64/10181754-wxWidgets/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Initial spec review: > BuildRequires: xorg-x11-server-Xvfb Can this be swapped out for "wlheadless-run" or "xwfb-run"? > Requires(post): /usr/sbin/update-alternatives > Requires(postun): /usr/sbin/update-alternatives Can we get rid of alternatives and just make it mutually exclusive packages instead? Some kind of Provides+Conflicts stanza with a virtual name? e.g. Provides: devel(wxWidgets) Conflicts: devel(wxWidgets) Or something else, I guess... > %{_libdir}/libwx_gtk3u_adv-*.so.%{sover}* The soversion glob is too greedy, per https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files Also, some kind of bcond to make it so that if it's the default version, the package provides the unversioned names so it gets pulled in by default. Finally, could we consider switching from Autotools to CMake? It appears to be supported: https://github.com/wxWidgets/wxWidgets/blob/master/docs/doxygen/overviews/cmake.md
(In reply to Neal Gompa from comment #3) > Initial spec review: > > > BuildRequires: xorg-x11-server-Xvfb > > Can this be swapped out for "wlheadless-run" or "xwfb-run"? I've tried that on the wxWidgets 3.2 release and there were a ton more test failures. So, probably not without having to skip a *lot* of tests. Probably need to get upstream support for that. > > Requires(post): /usr/sbin/update-alternatives > > Requires(postun): /usr/sbin/update-alternatives > > Can we get rid of alternatives and just make it mutually exclusive packages > instead? > > Some kind of Provides+Conflicts stanza with a virtual name? e.g. > > Provides: devel(wxWidgets) > Conflicts: devel(wxWidgets) > > Or something else, I guess... Yeah, we could probably do conflicting devel packages. The alternatives setup is just how it has been...forever. > > %{_libdir}/libwx_gtk3u_adv-*.so.%{sover}* > > The soversion glob is too greedy, per > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_listing_shared_library_files > > Also, some kind of bcond to make it so that if it's the default version, the > package provides the unversioned names so it gets pulled in by default. > > Finally, could we consider switching from Autotools to CMake? It appears to > be supported: > https://github.com/wxWidgets/wxWidgets/blob/master/docs/doxygen/overviews/ > cmake.md I did initially try this, but ran into bugs. Autotools is still the main supported build system, so I'd prefer to stick with it for now.