Bug 2444034 - Review Request: rust-cssparser-color - Color implementation based on cssparser
Summary: Review Request: rust-cssparser-color - Color implementation based on cssparser
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: blinxen
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/cssparser-color
Whiteboard:
Depends On:
Blocks: 2393991
TreeView+ depends on / blocked
 
Reported: 2026-03-02 23:01 UTC by Fabio Valentini
Modified: 2026-03-12 00:02 UTC (History)
2 users (show)

Fixed In Version: rust-cssparser-color-0.3.0-1.fc45
Clone Of:
Environment:
Last Closed: 2026-03-12 00:02:08 UTC
Type: ---
Embargoed:
h-k-81: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2026-03-02 23:01:53 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-cssparser-color.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-cssparser-color-0.3.0-1.fc43.src.rpm
Upstream URL: https://crates.io/crates/cssparser-color

Description:
Color implementation based on cssparser.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2026-03-02 23:03:04 UTC
Requires an update of rust-csscolor to version 0.35.0.

rust2rpm.toml configuration:

```
[package]
license-files = ["LICENSE"]

[[package.extra-sources]]
number = 2
file = "https://github.com/servo/rust-cssparser/raw/refs/tags/v0.35.0/LICENSE"
comments = ["https://github.com/servo/rust-cssparser/pull/424"]

[scripts]
prep.post = ["cp -pav %{SOURCE2} ."]

[tests]
run = ["doc"]
comments = ["https://github.com/servo/rust-cssparser/issues/213"]
```

Comment 2 Fedora Review Service 2026-03-03 02:45:45 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10185515
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2444034-rust-cssparser-color/fedora-rawhide-x86_64/10185515-rust-cssparser-color/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2026-03-04 15:08:43 UTC
[fedora-review-service-build]

Dependencies are now available in rawhide.

Comment 4 Fedora Review Service 2026-03-04 15:13:13 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10190554
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2444034-rust-cssparser-color/fedora-rawhide-x86_64/10190554-rust-cssparser-color/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 blinxen 2026-03-11 21:02:29 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass (only doc tests are executed -> reason is documented)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 6 Fabio Valentini 2026-03-11 23:38:25 UTC
Thank you for the review!

Comment 7 Fedora Admin user for bugzilla script actions 2026-03-11 23:38:53 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cssparser-color

Comment 8 Fabio Valentini 2026-03-12 00:02:08 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2026-03b40df0ad


Note You need to log in before you can comment on or make changes to this bug.