Bug 2445637 - Review Request: rust-cmov - Conditional move CPU intrinsics with pure Rust fallback implemenation
Summary: Review Request: rust-cmov - Conditional move CPU intrinsics with pure Rust fa...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: wojnilowicz
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/cmov
Whiteboard:
Depends On:
Blocks: 2445639
TreeView+ depends on / blocked
 
Reported: 2026-03-08 21:59 UTC by Fabio Valentini
Modified: 2026-03-28 19:46 UTC (History)
2 users (show)

Fixed In Version: rust-cmov-0.5.2-1.fc45
Clone Of:
Environment:
Last Closed: 2026-03-28 19:46:38 UTC
Type: ---
Embargoed:
lukasz.wojnilowicz: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2026-03-08 21:59:04 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-cmov.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-cmov-0.5.2-1.fc43.src.rpm
Upstream URL: https://crates.io/crates/cmov

Description:
Conditional move CPU intrinsics which are guaranteed on major platforms
(ARM32/ARM64, x86/x86_64, RISC-V) to execute in constant-time and not be
rewritten as branches by the compiler. Provides wrappers for the CMOV
family of instructions on x86/x86_64 and CSEL on AArch64, along with a
portable "best-effort" pure Rust fallback implementation.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2026-03-08 21:59:07 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=143146211

Comment 2 Fedora Review Service 2026-03-09 08:32:40 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10203048
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2445637-rust-cmov/fedora-rawhide-x86_64/10203048-rust-cmov/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 wojnilowicz 2026-03-21 10:44:53 UTC
Package was generated with rust2rpm, simplifying the review.

Not impacting the approval, but what was the reason to change the rust2rpm summary as below?
-Summary:        Conditional move CPU intrinsics which are guaranteed on major platforms
+Summary:        Conditional move CPU intrinsics with pure Rust fallback implemenation

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

I'm updating wiremix, and need a review at https://bugzilla.redhat.com/show_bug.cgi?id=2449936 Nothing urgent, but if you find some time, then I'll be grateful.

Comment 4 Fabio Valentini 2026-03-28 15:30:57 UTC
Thank you for the review!
The auto-generated summary is nonsense grammar, the changed summary better reflects what the project does.

Comment 5 Fedora Admin user for bugzilla script actions 2026-03-28 15:31:28 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cmov

Comment 6 Fabio Valentini 2026-03-28 19:46:38 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2026-bca9f8fdbc


Note You need to log in before you can comment on or make changes to this bug.