Bug 2447372 - Review Request: rust-bon - Compile-time-checked builder generator
Summary: Review Request: rust-bon - Compile-time-checked builder generator
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/bon
Whiteboard:
Depends On: 2447371
Blocks: 2427321
TreeView+ depends on / blocked
 
Reported: 2026-03-13 17:33 UTC by Fabio Valentini
Modified: 2026-03-17 19:03 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-03-17 19:03:52 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 10224769 to 10231461 (907 bytes, patch)
2026-03-16 17:47 UTC, Fedora Review Service
no flags Details | Diff

Description Fabio Valentini 2026-03-13 17:33:00 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-bon.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-bon-3.9.0-1.fc44.src.rpm
Upstream URL: https://crates.io/crates/bon

Description:
Next-gen compile-time-checked builder generator, named function's
arguments, and more!.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2026-03-13 17:34:47 UTC
rust2rpm configuration:

```
[package]
summary = "Compile-time-checked builder generator"
license-files = ["LICENSE-APACHE", "LICENSE-MIT"]

[[package.extra-sources]]
number = 10
file = "https://github.com/elastio/bon/raw/refs/tags/v3.9.0/LICENSE-APACHE"
comments = ["https://github.com/elastio/bon/issues/375"]

[[package.extra-sources]]
number = 11
file = "https://github.com/elastio/bon/raw/refs/tags/v3.9.0/LICENSE-MIT"
comments = ["https://github.com/elastio/bon/issues/375"]

[scripts]
prep.post = ["cp -pav %{SOURCE10} %{SOURCE11} ."]
check.pre = [
    "# ignore failures in brittle compiler error UI tests",
    "export TRYBUILD=overwrite",
]
```

Comment 2 Fedora Review Service 2026-03-14 05:30:53 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10224769
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2447372-rust-bon/fedora-rawhide-x86_64/10224769-rust-bon/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2026-03-16 17:44:28 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-bon.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-bon-3.9.1-1.fc44.src.rpm

Update to 3.9.1, which now includes the license texts.

Comment 4 Fedora Review Service 2026-03-16 17:47:34 UTC
Created attachment 2133682 [details]
The .spec file difference from Copr build 10224769 to 10231461

Comment 5 Fedora Review Service 2026-03-16 17:47:37 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10231461
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2447372-rust-bon/fedora-rawhide-x86_64/10231461-rust-bon/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Michel Lind 2026-03-16 21:18:19 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 7 Fabio Valentini 2026-03-17 13:16:45 UTC
Thank you for the review!

Comment 8 Fedora Admin user for bugzilla script actions 2026-03-17 13:17:55 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-bon

Comment 9 Fabio Valentini 2026-03-17 19:03:52 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2026-22a3b49092


Note You need to log in before you can comment on or make changes to this bug.