Bug 2447810 - Review Request: rust-vergen-lib - Common code used to support the vergen libraries
Summary: Review Request: rust-vergen-lib - Common code used to support the vergen libr...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ben Beasley
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-03-15 22:11 UTC by Jonathan Steffan
Modified: 2026-05-09 15:32 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-05-09 15:32:13 UTC
Type: ---
Embargoed:
code: fedora-review+


Attachments (Terms of Use)

Description Jonathan Steffan 2026-03-15 22:11:41 UTC
Spec URL: https://jsteffan.fedorapeople.org/xrizer/rust-vergen-lib.spec
SRPM URL: https://jsteffan.fedorapeople.org/xrizer/rust-vergen-lib-0.1.6-1.fc45.src.rpm
Description: Common code used to support the vergen libraries.
Fedora Account System Username: jsteffan

Comment 1 Ben Beasley 2026-03-17 12:19:03 UTC
Is it possible to use the latest version, which is 9.1.0?

https://crates.io/crates/vergen-lib/versions

Comment 3 Ben Beasley 2026-03-29 07:28:40 UTC
If you’re going to disable the tests, you should justify it, something like (in rust2rpm.toml):

  [tests]
  run = false
  comments = [
      "Tests expect to be run in the workspace; they require a test_util crate",
  ]

However, it turns out that you can patch out the import of the test_util workspace crate, which is currently entirely unused for vergen-lib in particular, and run all the included tests after all, something like this:

  diff -Naur vergen-lib-9.1.0-original/src/lib.rs vergen-lib-9.1.0/src/lib.rs
  --- vergen-lib-9.1.0-original/src/lib.rs        2006-07-24 02:21:28.000000000 +0100
  +++ vergen-lib-9.1.0/src/lib.rs 2026-03-29 08:25:03.328066431 +0100
  @@ -241,7 +241,9 @@
   #![cfg_attr(coverage_nightly, feature(coverage_attribute))]
   
   #[cfg(test)]
  -use {temp_env as _, test_util as _};
  +// Downstream patch: the test_util workspace crate dep. is currently unused
  +// use {temp_env as _, test_util as _};
  +use {temp_env as _};
   
   pub mod constants;
   mod emitter;

That would be even better. For an example of tracking a patch in rust2rpm.toml, see https://src.fedoraproject.org/rpms/rust-icu_provider/blob/4e61c9aed99c6e357720128819be78926b664d91/f/rust2rpm.toml#_6.

Comment 5 Fedora Review Service 2026-04-06 14:49:48 UTC
There seems to be some problem with the following file.
SRPM URL: https://jsteffan.fedorapeople.org/xrizer/rust-vergen-lib-9.1.0-1.fc43.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Ben Beasley 2026-05-07 06:51:21 UTC
(In reply to Fedora Review Service from comment #5)
> There seems to be some problem with the following file.
> SRPM URL:
> https://jsteffan.fedorapeople.org/xrizer/rust-vergen-lib-9.1.0-1.fc43.src.rpm
> Fetching it results in a 404 Not Found error.
> Please make sure the URL is correct and publicly available.

If you can fix this, I’ll try to take another look.

Comment 7 Jonathan Steffan 2026-05-07 14:56:27 UTC
Sorry about that. Two issues, infrastructure issues with fedora people, and I uploaded the chroot src.rpms vs the host rpms so the dist tag changed on me. :)

Spec URL: https://fedorapeople.org/~jsteffan/xrizer/rust-vergen-lib.spec
SRPM URL: https://fedorapeople.org/~jsteffan/xrizer/rust-vergen-lib-9.1.0-1.fc45.src.rpm
rust2rpm.toml URL: https://fedorapeople.org/~jsteffan/xrizer/rust-vergen-lib-rust2rpm.toml

Comment 8 Ben Beasley 2026-05-08 11:20:26 UTC
Package APPROVED. Consider hiding the “unstable” feature.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

The spec file is generated with rust2rpm, simplifying the review. The only
manual change is the addition of vergen-lib-9.1.0-remove-test-util.patch, which
is well-documented and reasonable to do downstream-only.

Issues:
=======
- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/share/cargo/registry/vergen-
  lib-9.1.0/LICENSE-APACHE
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_duplicate_files

  OK: not a serious problem; due to reasonable rust2rpm design decisions.

- Consider hiding the “unstable” feature,

    [features]
    hide = ["unstable"]

  until and unless something actually requires it. It would be better if
  nothing in Fedora depends on APIs that may not respect SemVer.

  This doesn’t block approval.

  (See the cautions in the rust2rpm.toml man page about features.hide.)

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Apache License 2.0",
     "MIT License", "Apache License (v2.0) or MIT license". 8 files have
     unknown license. Detailed output of licensecheck in
     /home/ben/fedora/review/2447810-rust-vergen-lib/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
     vergen-lib-devel , rust-vergen-lib+default-devel , rust-vergen-
     lib+build-devel , rust-vergen-lib+cargo-devel , rust-vergen-
     lib+emit_and_set-devel , rust-vergen-lib+git-devel , rust-vergen-
     lib+rustc-devel , rust-vergen-lib+si-devel , rust-vergen-lib+unstable-
     devel
[x]: Package functions as described.

     (Tests pass)

[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.

     https://koji.fedoraproject.org/koji/taskinfo?taskID=145249678
     (s390x tested by emulated local mockbuild due to current builder outage)

[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rust-vergen-lib-devel-9.1.0-1.fc45.noarch.rpm
          rust-vergen-lib+default-devel-9.1.0-1.fc45.noarch.rpm
          rust-vergen-lib+build-devel-9.1.0-1.fc45.noarch.rpm
          rust-vergen-lib+cargo-devel-9.1.0-1.fc45.noarch.rpm
          rust-vergen-lib+emit_and_set-devel-9.1.0-1.fc45.noarch.rpm
          rust-vergen-lib+git-devel-9.1.0-1.fc45.noarch.rpm
          rust-vergen-lib+rustc-devel-9.1.0-1.fc45.noarch.rpm
          rust-vergen-lib+si-devel-9.1.0-1.fc45.noarch.rpm
          rust-vergen-lib+unstable-devel-9.1.0-1.fc45.noarch.rpm
          rust-vergen-lib-9.1.0-1.fc45.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpsbjrv5ns')]
checks: 32, packages: 10

 10 packages and 0 specfiles checked; 0 errors, 0 warnings, 55 filtered, 0 badness; has taken 0.3 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.9.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 9

 9 packages and 0 specfiles checked; 0 errors, 0 warnings, 51 filtered, 0 badness; has taken 0.0 s 



Source checksums
----------------
https://crates.io/api/v1/crates/vergen-lib/9.1.0/download#/vergen-lib-9.1.0.crate :
  CHECKSUM(SHA256) this package     : b34a29ba7e9c59e62f229ae1932fb1b8fb8a6fdcc99215a641913f5f5a59a569
  CHECKSUM(SHA256) upstream package : b34a29ba7e9c59e62f229ae1932fb1b8fb8a6fdcc99215a641913f5f5a59a569


Requires
--------
rust-vergen-lib-devel (rpmlib, GLIBC filtered):
    (crate(anyhow/default) >= 1.0.100 with crate(anyhow/default) < 2.0.0~)
    (crate(derive_builder/default) >= 0.20.2 with crate(derive_builder/default) < 0.21.0~)
    (crate(rustversion/default) >= 1.0.22 with crate(rustversion/default) < 2.0.0~)
    cargo
    rust

rust-vergen-lib+default-devel (rpmlib, GLIBC filtered):
    cargo
    crate(vergen-lib)

rust-vergen-lib+build-devel (rpmlib, GLIBC filtered):
    cargo
    crate(vergen-lib)

rust-vergen-lib+cargo-devel (rpmlib, GLIBC filtered):
    cargo
    crate(vergen-lib)

rust-vergen-lib+emit_and_set-devel (rpmlib, GLIBC filtered):
    cargo
    crate(vergen-lib)

rust-vergen-lib+git-devel (rpmlib, GLIBC filtered):
    cargo
    crate(vergen-lib)

rust-vergen-lib+rustc-devel (rpmlib, GLIBC filtered):
    cargo
    crate(vergen-lib)

rust-vergen-lib+si-devel (rpmlib, GLIBC filtered):
    cargo
    crate(vergen-lib)

rust-vergen-lib+unstable-devel (rpmlib, GLIBC filtered):
    cargo
    crate(vergen-lib)



Provides
--------
rust-vergen-lib-devel:
    crate(vergen-lib)
    rust-vergen-lib-devel

rust-vergen-lib+default-devel:
    crate(vergen-lib/default)
    rust-vergen-lib+default-devel

rust-vergen-lib+build-devel:
    crate(vergen-lib/build)
    rust-vergen-lib+build-devel

rust-vergen-lib+cargo-devel:
    crate(vergen-lib/cargo)
    rust-vergen-lib+cargo-devel

rust-vergen-lib+emit_and_set-devel:
    crate(vergen-lib/emit_and_set)
    rust-vergen-lib+emit_and_set-devel

rust-vergen-lib+git-devel:
    crate(vergen-lib/git)
    rust-vergen-lib+git-devel

rust-vergen-lib+rustc-devel:
    crate(vergen-lib/rustc)
    rust-vergen-lib+rustc-devel

rust-vergen-lib+si-devel:
    crate(vergen-lib/si)
    rust-vergen-lib+si-devel

rust-vergen-lib+unstable-devel:
    crate(vergen-lib/unstable)
    rust-vergen-lib+unstable-devel



Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29
Command line :/usr/bin/fedora-review -b 2447810
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: PHP, R, Perl, Java, fonts, Ocaml, SugarActivity, C/C++, Haskell, Python
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comment 9 Fedora Admin user for bugzilla script actions 2026-05-09 14:29:41 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-vergen-lib
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 10 Fedora Update System 2026-05-09 15:29:41 UTC
FEDORA-2026-419e0dde06 (rust-vergen-lib-9.1.0-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-419e0dde06

Comment 11 Fedora Update System 2026-05-09 15:32:13 UTC
FEDORA-2026-419e0dde06 (rust-vergen-lib-9.1.0-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.