Spec URL: https://salimma.fedorapeople.org/rust-string-interner.spec SRPM URL: https://salimma.fedorapeople.org/rust-string-interner-0.19.0-1.fc45.src.rpm Upstream URL: https://crates.io/crates/string-interner Description: Efficient string interner with minimal memory footprint and fast access to the underlying strings. Fedora Account System Username: salimma
Copr build: https://copr.fedorainfracloud.org/coprs/build/10232109 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2448249-rust-string-interner/fedora-rawhide-x86_64/10232109-rust-string-interner/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks good and straightforward. 99% ready for approval. Remaining 1% is annoying - the project contains only the Apache-2.0 license header in LICENSE-APACHE, not the ... actual Apache-2.0 license text.
(In reply to Fabio Valentini from comment #2) > Looks good and straightforward. 99% ready for approval. > Remaining 1% is annoying - the project contains only the Apache-2.0 license > header in LICENSE-APACHE, not the ... actual Apache-2.0 license text. urgh, how annoying. I'll put up a PR
Fixed: https://github.com/Robbepop/string-interner/pull/98 Spec URL: https://salimma.fedorapeople.org/rust-string-interner.spec SRPM URL: https://salimma.fedorapeople.org/rust-string-interner-0.19.0-1.fc45.src.rpm TOML: [package] # summary too long summary = "Efficient and fast string interner" cargo-toml-patch-comments = [ "drop benchmarking dependencies like criterion", ] [[package.extra-patches]] number = 10 file = "https://github.com/Robbepop/string-interner/pull/98.patch#/string-interner-use-full-apache-license-text.diff" comments = [ "Replace Apache license header with full license text", ]
Created attachment 2133723 [details] The .spec file difference from Copr build 10232109 to 10232192
Copr build: https://copr.fedorainfracloud.org/coprs/build/10232192 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2448249-rust-string-interner/fedora-rawhide-x86_64/10232192-rust-string-interner/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks, looks good to me now! === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora 🫤 license file is included with %license in %files: full canonical license text included by patch, PR submitted upstream ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-string-interner
FEDORA-2026-53cf741e3c (rust-string-interner-0.19.0-2.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-53cf741e3c
FEDORA-2026-53cf741e3c (rust-string-interner-0.19.0-2.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-3f95974b5d (rust-string-interner-0.19.0-2.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-3f95974b5d
FEDORA-2026-3b2874bc35 (rust-string-interner-0.19.0-2.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2026-3b2874bc35
FEDORA-2026-d4c6386c57 (rust-string-interner-0.19.0-2.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2026-d4c6386c57
FEDORA-2026-3f95974b5d has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-3f95974b5d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-3f95974b5d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-d4c6386c57 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-d4c6386c57 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-d4c6386c57 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-3b2874bc35 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-3b2874bc35 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-3b2874bc35 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-3f95974b5d (rust-string-interner-0.19.0-2.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-3b2874bc35 (rust-string-interner-0.19.0-2.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-d4c6386c57 (rust-string-interner-0.19.0-2.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.