Spec URL: https://alebastr.fedorapeople.org/review/python-typelets/python-typelets.spec SRPM URL: https://alebastr.fedorapeople.org/review/python-typelets/python-typelets-1.1-1.fc44.src.rpm Upstream URL: https://typelets.readthedocs.io/ Description: Typelets is a Python typing utility module designed to augment some of the types provided in Python and third-party libraries. Fedora Account System Username: alebastr
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "*No copyright* MIT License", "Unknown or generated". 18 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/python- typelets/2448306-python-typelets/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.14, /usr/lib/python3.14/site-packages [ ]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-typelets-1.1-1.fc45.noarch.rpm python-typelets-1.1-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmps3w652d5')] checks: 32, packages: 2 python3-typelets.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 10 filtered, 0 badness; has taken 0.8 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-typelets.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 6 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/t/typelets/typelets-1.1.tar.gz : CHECKSUM(SHA256) this package : 5fd0a01016402a2f87892ac855241ee2769b7595c7e955acce040c86f71bfb38 CHECKSUM(SHA256) upstream package : 5fd0a01016402a2f87892ac855241ee2769b7595c7e955acce040c86f71bfb38 Requires -------- python3-typelets (rpmlib, GLIBC filtered): python(abi) python3.14dist(typing-extensions) Provides -------- python3-typelets: python-typelets python3-typelets python3.14-typelets python3.14dist(typelets) python3dist(typelets) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2448306 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: fonts, Ocaml, R, PHP, Haskell, Perl, C/C++, SugarActivity, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Please change %files -n python3-typelets -f %{pyproject_files} to %files -n python3-typelets -f %{pyproject_files} %doc README b) python-beanbag-docutils is needed to build documentation, but not packaged in Fedora. Ok to skip documentation, though would be nice to have. c) Please add django as a build dependency. It is listed in the development requirements: https://github.com/beanbaginc/python-typelets/blob/main/dev-requirements.txt change BuildRequires: python3-devel BuildRequires: python3dist(pytest) to BuildRequires: python3-devel BuildRequires: python3dist(pytest) BuildRequires: python3dist(django) then change # We ignore django dependencies, because # - Upstream project decided to not declare extras # - RBTools does not use and should not require django %pyproject_check_import -e 'typelets.django' to # djang.auth test requires setting a DJANGO configuration # and so is not run. %pyproject_check_import -e 'typelets.django.auth' One can then run most of the tests: https://koji.fedoraproject.org/koji/taskinfo?taskID=143577420 The settings that need to be set are documented at: https://docs.djangoproject.com/en/6.0/topics/settings/#envvar-DJANGO_SETTINGS_MODULE but have not dug into how this should be done.
Spec URL: https://alebastr.fedorapeople.org/review/python-typelets/python-typelets.spec SRPM URL: https://alebastr.fedorapeople.org/review/python-typelets/python-typelets-1.1-1.fc44.src.rpm Thanks for the review! >(In reply to Benson Muite from comment #1) > Comments: > a) Please change > %files -n python3-typelets -f %{pyproject_files} > > to > > %files -n python3-typelets -f %{pyproject_files} > %doc README Fixed, thanks! > c) Please add django as a build dependency. It is listed in the > development requirements: I have to disagree with this comment. I intentionally omitted the django BR, because it is not needed for the build (note how %pytest fully passes without it), and must not be a runtime requirement. Also, I need to remind that %pyproject_check_import is NOT a test, and is optional if the upstream test suite can be run instead (see %py3_check_import/%pyproject_check_import in the guidelines). However, it works well for verifying that usable parts of typelets don't import anything unexpected. I hope the updated comment in the spec explains that better. If you're not convinced, I can make a compromise solution: remove 'typelets.django.*' from the package.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10295075 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2448306-python-typelets/fedora-rawhide-x86_64/10295075-python-typelets/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.