Red Hat Bugzilla – Bug 244982
critical patches from Richard Hughes
Last modified: 2007-11-30 17:07:44 EST
Description of problem:
Richard Hughes has created 10 very small and safe patches for
gnome-power-manager that should go into our RHEL5.1 update
Information on these patches:
Here is a list of suggested backports from 2.16.4 for RHEL 5.1:
Description: The allocated memory was stored in a const char variable
which meant that every time the icon changed we leaked
about 15 bytes of memory.
Description: We were not clearing the devices when HAL restarted
resulting in duplicate devices on restart.
Risk: Pretty low
Description: Due to a typo we were not freeing stats memory when
the module was unloaded.
Description: Some batteries are crazy and report themselves charged
at zero percent charge, or momentarily report zero when
the charge status changes (Sony laptops?).
Description: On any non English local the information tool was
crashing as the widget names were partially translated.
Description: Don't segfault if the widget name is not present, which
fixes a bug if an old glade file is loaded.
Description: Allocates device rather than just watches for changes
Risk: Pretty low
Description: Don't show the "your computer failed to hibernate"
when the hibernation period is very long, and the DBUS
request times out.
Description: Emit a signal so the UI knows the battery has been
removed, and can update before a timeout.
Risk: Pretty low
Description: Fix the macbook pro dimming controls; macbook hardware
has an insane number of brightness levels and we have
to step an integer number of these to avoid causing
lots of CPU load every time we change brightness
Description: Add to the string comparisons so that a new version
of hal can be used with an old g-p-m.
Description: Updates all the translations to what 2.16.4 has.
This also includes quite a few new languages.
I hope some of these are useful. David, can you ack/nak some of these
and then I'll add these to a srpm. I've attached all the patches for
review, although all have been upstream in 2-16 for many months.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
Created attachment 157452 [details]
gpm patches from Richard
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release. Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products. This request is not yet committed for inclusion in an Update
Created attachment 157860 [details]
This is a srpm that contains all the patches, and one additional fix:
Which allows gnome-power-manager 2.16.x to build with a new version of
docutils. I'll try to get this build with brew today and then we can get
Appears this is in 2.16.0-8.el5
Tested everything I can with the hardware I have. Everything I tested worked
without any new problems.
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.