http://people.freedesktop.org/~david/PolicyKit-gnome.spec http://people.freedesktop.org/~david/PolicyKit-gnome-0.3-1.fc8.src.rpm Thanks.
Preludes: - should use full source url - why do you need to BR both dbus-glib and dbus-glib-devel ? - might be worthwhile to drop the libgnomeui dependency
Formal checklist: rpmlint: only warns about no docs in the -demo subpackage. I wonder if you want to include the sourcecode in the package, to make the demo actually useful for people looking for example code ? package name: follows tarball name, ok spec file name: ok packaging guidelines: - the source url was already mentioned - the %build section should also have a make, not just a configure license: ok license field: ok license file: ok, American English: yes legibility: excellent upstream sources: ok buildable: yes excludearch: n/a BRs: ok locale handling: n/a (LINGUAS is empty atm) shared libs: n/a relocatable: no directory ownership: - should /usr/share/PolicyKit and /usr/share/PolicyKit/policy be owned by PolicyKit itself ? file list duplicates: none permissions: ok %clean section: ok macro use: ok content: permissable documentation: ok %doc content: ok header files: n/a static libs: n/a pkgconfig files: n/a shared libs: n/a libtool archives: n/a desktop files: ok, I think. maybe you need to put a comment file ownership: ok %install: cleans build root filenames utf8: ok
David did a new release and new srpms here: http://people.freedesktop.org/~david/release-o-rama-july-2007/
Some comments still apply: - why do you need to BR both dbus-glib and dbus-glib-devel ? - might be worthwhile to drop the libgnomeui dependency But both are not blockers, so I'll say APPROVED
New Package CVS Request ======================= Package Name: PolicyKit-gnome Short Description: GNOME auth dialogs for PolicyKit Owners: davidz Branches: InitialCC:
Built in pkg cvs.