Spec URL: https://download.copr.fedorainfracloud.org/results/peterbb/mhwaveedit/srpm-builds/10268021/mhwaveedit.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/peterbb/mhwaveedit/srpm-builds/10268021/mhwaveedit-1.4.24-1.fc43.src.rpm Description: mhWaveEdit is a graphical program for editing sound files. It is completely free (GPL) and written by Magnus Hjorth. It is intended to be user-friendly and robust. OGG and LAME support are available if installed. Fedora Account System Username: peterbb
Reintroducing orphaned package; https://src.fedoraproject.org/rpms/mhwaveedit
Copr build: https://copr.fedorainfracloud.org/coprs/build/10257222 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2450774-mhwaveedit/fedora-rawhide-x86_64/10257222-mhwaveedit/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/mhwaveedit Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/peterbb/mhwaveedit/srpm-builds/10257096/mhwaveedit.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/peterbb/mhwaveedit/srpm-builds/10257096/mhwaveedit-1.4.24-1.fc43.src.rpm
Created attachment 2134713 [details] The .spec file difference from Copr build 10257222 to 10258029
Copr build: https://copr.fedorainfracloud.org/coprs/build/10258029 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2450774-mhwaveedit/fedora-rawhide-x86_64/10258029-mhwaveedit/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/mhwaveedit Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Fedora Review Service from comment #5) > Found issues: > > - A package with this name already exists. Please check > https://src.fedoraproject.org/rpms/mhwaveedit Yes. The package was orphaned 6 years ago. I'm attempting to adopt it.
Hi, I will take this one, review to follow. Regards Phil
Hi, In this episode builds, lint and other things spotted. Builds ====== * Local x86_64: Good. * COPR: Good. RPM Lint ======== * All: Good, canno see anything jumping out at me. Glance at SPEC file =================== * Package does not install its '%license'. * Modernize to use '%autosetup'. * Create an AppStream metainfo file. * Keep '%files'. %files ... %license %doc %{_bindir} %{_libdir} etc. in alphabetical order. While work is ongoing, I will perform install and basic run testing. Regards Phil
Hi, Runs here locally without issue. Things I would think on. * Does this old app have value to be in today's Fedora? * Is adding a GTK 2 app to Fedora the best move if there are GTK 3 or greater alternatives in the distro? Regards Phil
(In reply to Phil Wyett from comment #9) > * Does this old app have value to be in today's Fedora? > * Is adding a GTK 2 app to Fedora the best move if there are GTK 3 or > greater alternatives in the distro? I use this app regularly for polishing up sound tracks ripped from YouTube & CDs. It might well be of interest to others. I'm not aware of any (lightweight, fast and easy to use) equivalents.
Updated package. Thanks for the review. Spec URL: https://download.copr.fedorainfracloud.org/results/peterbb/mhwaveedit/srpm-builds/10267211/mhwaveedit.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/peterbb/mhwaveedit/srpm-builds/10267211/mhwaveedit-1.4.24-1.fc43.src.rpm
Created attachment 2135087 [details] The .spec file difference from Copr build 10258029 to 10267349
Copr build: https://copr.fedorainfracloud.org/coprs/build/10267349 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2450774-mhwaveedit/fedora-rawhide-x86_64/10267349-mhwaveedit/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/mhwaveedit Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi, Adding AppStream can be a difficult task and much learning. Docs: https://www.freedesktop.org/software/appstream/docs/ Metainfo Creator: https://www.freedesktop.org/software/appstream/metainfocreator/ The file name should be 'metainfo' not 'appdata'. In the '%install' section is where you install the metainfo file, similar to the below example. # Install our AppStream metainfo file. install -D -p -m 644 %{SOURCE1} %{buildroot}%{_datadir}/metainfo/me.you.other.metainfo.xml In the '%check' section is where you peform build time validation of the metainfo file. See example below. appstreamcli validate --no-net %{buildroot}%{_datadir}/metainfo/me.you.other.metainfo.xml In the appropriate '%files' section, you install the file. See example below. %{_datadir}/metainfo/me.you.other.metainfo.xml AppStream metainfo files are very important in te providing application data via app stores etc. I hope the above helps you prepare your next upload of 'spec' file and 'srpm'. Regards Phil
(In reply to Phil Wyett from comment #14) > I hope the above helps you prepare your next upload of 'spec' file and > 'srpm'. Yes, it did. Here we go.... Spec URL: https://download.copr.fedorainfracloud.org/results/peterbb/mhwaveedit/srpm-builds/10268021/mhwaveedit.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/peterbb/mhwaveedit/srpm-builds/10268021/mhwaveedit-1.4.24-1.fc43.src.rpm Cheers, Peter
Created attachment 2135093 [details] The .spec file difference from Copr build 10267349 to 10268065
Copr build: https://copr.fedorainfracloud.org/coprs/build/10268065 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2450774-mhwaveedit/fedora-rawhide-x86_64/10268065-mhwaveedit/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/mhwaveedit Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
So what happens next? Anything else I need to do? Regards, Peter
Hi, Your last linking to spec and rpm are both 404 (not found). Could you make the available again, so I a further review. Regards Phil
Hi Phil, It seems packages on cpor are getting automatically deleted. I've submitted a new build, 10403045 https://copr.fedorainfracloud.org/coprs/peterbb/mhwaveedit/package/mhwaveedit/ Link to the spec here https://download.copr.fedorainfracloud.org/results/peterbb/mhwaveedit/fedora-43-x86_64/10403045-mhwaveedit/mhwaveedit.spec I'm just getting "Internal Server Error" trying to link to the sprm
Source package here; https://packages.redhat.com/api/pulp-content/public-copr/peterbb/mhwaveedit/fedora-43-x86_64/Packages/m/mhwaveedit-1.4.24-1.fc43.src.rpm
Spec URL: https://download.copr.fedorainfracloud.org/results/peterbb/mhwaveedit/srpm-builds/10403045/mhwaveedit.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/peterbb/mhwaveedit/srpm-builds/10403045/mhwaveedit-1.4.24-1.fc43.src.rpm
Hi, Got the files, thanks. Builds local and on COPR are good except for failure on s390x. You may wish to investigate, fix or exclude from the build system. Build log: https://download.copr.fedorainfracloud.org/results/kathenas/generic-fedora-rawhide-all-with-review-not-production/fedora-rawhide-s390x/10404486-mhwaveedit/builder-live.log.gz The version requirement is not needed here. BuildRequires: pkgconfig(jack) >= 0.98.0 BuildRequires: pkgconfig(libpulse) >= 0.9.10 The below section needs to be above %changelog %files -f %{name}.lang %{_bindir}/%{name} %{_datadir}/applications/%{name}.desktop %{_datadir}/metainfo/%{name}.metainfo.xml %{_iconsdir}/hicolor/*/apps/%{name}.png %{_mandir}/man1/%{name}.1* The below section needs to be above your %files %check desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop appstream-util validate-relax --nonet %{buildroot}/%{_datadir}/metainfo/%{name}.metainfo.xml The below section needs to be inserted int the files section, right at the top. %doc AUTHORS BUGS ChangeLog NEWS README TODO %license COPYING Example of complete file below. Summary: WAV Editing Package Name: mhwaveedit Version: 1.4.24 Release: 1%{?dist} Url: https://github.com/magnush/mhwaveedit License: GPL-2.0-or-later %global forgeurl https://github.com/magnush/mhwaveedit %forgemeta Source0: %{forgesource} Source1: mhwaveedit.metainfo.xml BuildRequires: gcc BuildRequires: autoconf BuildRequires: automake BuildRequires: libtool BuildRequires: make BuildRequires: ladspa-devel BuildRequires: lame-devel BuildRequires: desktop-file-utils BuildRequires: hicolor-icon-theme BuildRequires: libappstream-glib BuildRequires: pkgconfig(alsa) BuildRequires: pkgconfig(gthread-2.0) BuildRequires: pkgconfig(gtk+-2.0) BuildRequires: pkgconfig(jack) >= 0.98.0 BuildRequires: pkgconfig(libpulse) >= 0.9.10 BuildRequires: pkgconfig(ogg) BuildRequires: pkgconfig(sdl) BuildRequires: pkgconfig(sndfile) BuildRequires: pkgconfig(portaudio-2.0) BuildRequires: pkgconfig(samplerate) Requires: hicolor-icon-theme # For default mixer (alsamixer) Requires: alsa-utils %description mhWaveEdit is a graphical program for editing sound files. It is completely free (GPL) and written by Magnus Hjorth. It is intended to be user-friendly and robust. OGG and LAME support are available if installed. %prep %autosetup %build %global _pkg_extra_cflags -std=gnu17 %configure --prefix=/usr \ --without-arts \ --without-esound \ --without-oss \ --without-sun \ --with-double-samples %make_build %install %make_install %find_lang %{name} install -D -p -m 644 %{SOURCE1} %{buildroot}%{_datadir}/metainfo/%{name}.metainfo.xml %check desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop appstream-util validate-relax --nonet %{buildroot}/%{_datadir}/metainfo/%{name}.metainfo.xml %files -f %{name}.lang %license COPYING %doc AUTHORS BUGS ChangeLog NEWS README TODO %{_bindir}/%{name} %{_datadir}/applications/%{name}.desktop %{_datadir}/metainfo/%{name}.metainfo.xml %{_iconsdir}/hicolor/*/apps/%{name}.png %{_mandir}/man1/%{name}.1* %changelog * Fri Mar 27 2026 peterbb <peter.com> - 1.4.24-1 - Reintroduce to Fedora Regards Phil
Copr build: https://copr.fedorainfracloud.org/coprs/build/10405254 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2450774-mhwaveedit/fedora-rawhide-x86_64/10405254-mhwaveedit/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/mhwaveedit Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10405271 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2450774-mhwaveedit/fedora-rawhide-x86_64/10405271-mhwaveedit/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/mhwaveedit Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi, You may wish to create package specific COPR builder and target only rawhide. This may retain the srpm files. You may also wish to share a location you have where you can drop the files. Regards Phil
Package updated as suggested. Thanks for the review. Spec URL: https://download.copr.fedorainfracloud.org/results/peterbb/mhwaveedit/srpm-builds/10408561/mhwaveedit.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/peterbb/mhwaveedit/srpm-builds/10408561/mhwaveedit-1.4.24-1.fc44.src.rpm
Created attachment 2138754 [details] The .spec file difference from Copr build 10405271 to 10408858
Copr build: https://copr.fedorainfracloud.org/coprs/build/10408858 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2450774-mhwaveedit/fedora-rawhide-x86_64/10408858-mhwaveedit/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/mhwaveedit Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi, Many thanks for the work you have put in on this package. Marking as '+'. You can now follow the rest of this he unretirement process[1] and hopefully the package can me its way back into the distro soon. [1] https://docs.fedoraproject.org/en-US/package-maintainers/Package_Retirement_Process/#claiming Regards Phil
(In reply to Phil Wyett from comment #30) > > Marking as '+'. Thanks Phil. Hopefully this will raise its visibility with potential sponsors. Re: "You may wish to create package specific COPR builder and target only rawhide." I've updated the settings on COPR to build only for Rawhide. I'm not sure what you mean by "create package specific COPR builder". (I'm already submitting COPR builds for the review). Re: "Builds ... good except for failure on s390x. You may wish to investigate, fix or exclude from the build system." Noted. s390x is big endian. Not resolvable via packaging. I'll exclude it from the build. Cheers, Peter
Hi Peter, No need to exclude s390x. It seems on COPR many packages are failing on s390x but many like mhwaveedit are fine doing a 'scratch' build. `Sorry for failing to mention this in my last comment. Regards Phil
Noted (In reply to Phil Wyett from comment #32) > Hi Peter, > > No need to exclude s390x. It seems on COPR many packages are failing on > s390x but many like mhwaveedit are fine doing a 'scratch' build. > > `Sorry for failing to mention this in my last comment. > > Regards > > Phil Noted, thanks.