Bug 2452763 - Review Request: rust-lz4_flex - Fastest LZ4 implementation in Rust, no unsafe by default
Summary: Review Request: rust-lz4_flex - Fastest LZ4 implementation in Rust, no unsafe...
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/lz4_flex
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-03-28 23:22 UTC by Jonathan Steffan
Modified: 2026-08-16 20:59 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
decathorpe: fedora-review?


Attachments (Terms of Use)

Description Jonathan Steffan 2026-03-28 23:22:42 UTC
Spec URL: https://jsteffan.fedorapeople.org/xrizer/rust-lz4_flex.spec
SRPM URL: https://jsteffan.fedorapeople.org/xrizer/rust-lz4_flex-0.13.0-1.fc45.src.rpm
Description: Fastest LZ4 implementation in Rust, no unsafe by default
Fedora Account System Username:

Comment 1 Jonathan Steffan 2026-04-05 22:17:57 UTC
Changelog:

- Add rust2rpm toml, incorporate any feedback

Spec URL: https://jsteffan.fedorapeople.org/xrizer/rust-lz4_flex.spec
SRPM URL: https://jsteffan.fedorapeople.org/xrizer/rust-lz4_flex-0.13.0-1.fc43.src.rpm
rust2rpm.toml URL: https://jsteffan.fedorapeople.org/xrizer/rust-lz4_flex-rust2rpm.toml

Comment 2 Fedora Review Service 2026-04-06 14:50:08 UTC
There seems to be some problem with the following file.
SRPM URL: https://jsteffan.fedorapeople.org/xrizer/rust-lz4_flex-0.13.0-1.fc43.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Jonathan Steffan 2026-05-07 15:38:53 UTC
Changelog:

- Add rust2rpm toml, incorporate any feedback

Spec URL: https://jsteffan.fedorapeople.org/xrizer/rust-lz4_flex.spec
SRPM URL: https://jsteffan.fedorapeople.org/xrizer/rust-lz4_flex-0.13.0-1.fc45.src.rpm
rust2rpm.toml URL: https://jsteffan.fedorapeople.org/xrizer/rust-lz4_flex-rust2rpm.toml

Comment 4 Fabio Valentini 2026-06-23 08:59:56 UTC
It would be great if we could run at least *some* tests. In my experience, libraries that do low-level byte fiddling (like compression) sometimes have bitness or endianness bugs ...

It looks like all dev-dependencies except three (more-asserts, proptest, serde_json) are not referenced by any code in the published crate (only by benchmark code or integration tests, neither of which are included in the published .crate archive) - dropping all dev-dependencies but those should make the package build and let tests run.

Comment 6 Fedora Review Service 2026-08-16 20:59:35 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10870530
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2452763-rust-lz4_flex/fedora-rawhide-x86_64/10870530-rust-lz4_flex/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.