Spec URL: https://jsteffan.fedorapeople.org/xrizer/rust-quad-url.spec SRPM URL: https://jsteffan.fedorapeople.org/xrizer/rust-quad-url-0.1.2-1.fc45.src.rpm Description: Plugin for macro-, mini-quad (quads) to do anything with url Fedora Account System Username: jsteffan
You should explain/justify what is happening in the metadata patch. Something like this, in rust2rpm.toml, would do nicely: [package] cargo-toml-patch-comments = [ "Update webbrowser to 1.0 (upstream wants 0.5)", ] Ideally, you would also suggest the change upstream. Fortunately, someone already has, so you can just link that PR: cargo-toml-patch-comments = [ """\ Update webbrowser to 1.0 (upstream wants 0.5): https://github.com/optozorax/quad-url/pull/2\ """, ] Similarly, tests shouldn’t be disabled without an explanation, something like: [tests] run = false comments = [ "Unpackaged dev-dependencies egui-macroquad, macroquad, and egui", ] Although it’s not really hurting anything, you could choose to exclude js/quad-url.js in your metadata patch since it’s only for WASM.
Changelog: - Add rust2rpm toml, incorporate feedback Spec URL: https://jsteffan.fedorapeople.org/xrizer/rust-quad-url.spec SRPM URL: https://jsteffan.fedorapeople.org/xrizer/rust-quad-url-0.1.2-1.fc43.src.rpm rust2rpm.toml URL: https://jsteffan.fedorapeople.org/xrizer/rust-quad-url-rust2rpm.toml
There seems to be some problem with the following file. SRPM URL: https://jsteffan.fedorapeople.org/xrizer/rust-quad-url-0.1.2-1.fc43.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Changelog: - Add rust2rpm toml, incorporate feedback Spec URL: https://jsteffan.fedorapeople.org/xrizer/rust-quad-url.spec SRPM URL: https://jsteffan.fedorapeople.org/xrizer/rust-quad-url-0.1.2-1.fc45.src.rpm rust2rpm.toml URL: https://jsteffan.fedorapeople.org/xrizer/rust-quad-url-rust2rpm.toml
Package APPROVED. You might still consider excluding the JavaScript source, which would only be needed for WASM, but this isn’t terribly important. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is exactly as generated by rust2rpm with the provided rust2rpm.toml, greatly simplifying the review. The tests are disabled. This is unfortunate, but adequately justified by the several missing dependencies, and the disablement is appropriately documented. The patch to update the webbrowser dependency is reasonable, well-documented, and has an upstream status link. Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/quad- url-0.1.2/LICENSE-APACHE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files OK: not a serious problem; due to reasonable rust2rpm design decisions - Although it’s not really hurting anything, you could choose to exclude js/quad-url.js in your metadata patch since it’s only for WASM. This doesn’t block approval. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* MIT License". 8 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2452765-rust-quad- url/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- quad-url-devel , rust-quad-url+default-devel [?]: Package functions as described. (Tests are disabled, with adequate justification.) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=145250189 (s390x tested by emulated local mockbuild due to current builder outage) [!]: %check is present and all tests pass. (Tests are disabled, with adequate justification.) [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-quad-url-devel-0.1.2-1.fc45.noarch.rpm rust-quad-url+default-devel-0.1.2-1.fc45.noarch.rpm rust-quad-url-0.1.2-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpbb4801xl')] checks: 32, packages: 3 rust-quad-url-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/quad-url-0.1.2/src/lib.rs rust-quad-url-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/quad-url-0.1.2/README.md 3 packages and 0 specfiles checked; 1 errors, 1 warnings, 13 filtered, 1 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 rust-quad-url-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/quad-url-0.1.2/src/lib.rs rust-quad-url-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/quad-url-0.1.2/README.md 2 packages and 0 specfiles checked; 1 errors, 1 warnings, 9 filtered, 1 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/quad-url/0.1.2/download#/quad-url-0.1.2.crate : CHECKSUM(SHA256) this package : 1843b2c8bd2cf5c43fa99dc53bc9f977bd032d386c54491ceeee2499c2d5020f CHECKSUM(SHA256) upstream package : 1843b2c8bd2cf5c43fa99dc53bc9f977bd032d386c54491ceeee2499c2d5020f Requires -------- rust-quad-url-devel (rpmlib, GLIBC filtered): (crate(webbrowser/default) >= 1.0.6 with crate(webbrowser/default) < 2.0.0~) cargo rust-quad-url+default-devel (rpmlib, GLIBC filtered): cargo crate(quad-url) Provides -------- rust-quad-url-devel: crate(quad-url) rust-quad-url-devel rust-quad-url+default-devel: crate(quad-url/default) rust-quad-url+default-devel Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2452765 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: PHP, R, SugarActivity, C/C++, Ocaml, Haskell, Java, Perl, fonts, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-quad-url Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
FEDORA-2026-709472585b (rust-quad-url-0.1.2-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-709472585b
FEDORA-2026-709472585b (rust-quad-url-0.1.2-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.