Created attachment 2135551 [details] Configuration file for rust2rpm Spec URL: https://music.fedorapeople.org/rust-cargo-cyclonedx.spec SRPM URL: https://music.fedorapeople.org/rust-cargo-cyclonedx-0.5.9-1.fc43.src.rpm Description: CycloneDX Software Bill of Materials (SBOM) for Rust Crates. Fedora Account System Username: music This cargo subcommand is likely to be useful in its own right, but it is also a dependency for default-enabled SBOM support the latest version of maturin. (Surprisingly, maturin depends on the crate interface of this command, pinned to an exact version, rather than on the cyclonedx-bom crate.)
Copr build: https://copr.fedorainfracloud.org/coprs/build/10280937 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2453357-rust-cargo-cyclonedx/fedora-rawhide-x86_64/10280937-rust-cargo-cyclonedx/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10280938 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2453357-rust-cargo-cyclonedx/fedora-rawhide-x86_64/10280938-rust-cargo-cyclonedx/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Overall lgtm, just one license issue to resolve - Please check and verify with upstream what the license state of this crate is. Here is what licensecheck reported ``` *No copyright* Apache License 2.0 --------------------------------- rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/LICENSE rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/src/config.rs rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/src/generator.rs rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/src/lib.rs rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/tests/fixtures/root_package.json rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/tests/fixtures/workspace_package.json *No copyright* BSD 2-Clause License ----------------------------------- rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/tests/fixtures/git_package_with_branch.json *No copyright* MIT License -------------------------- rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/tests/fixtures/git_package.json *No copyright* The Unlicense ---------------------------- rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/tests/fixtures/crates_io_package.json Apache License 2.0 ------------------ rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/README.md rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/src/format.rs Apache License 2.0 and/or MIT License ------------------------------------- rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/src/main.rs Unknown or generated -------------------- rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/.cargo_vcs_info.json rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/CHANGELOG.md rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/Cargo.lock rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/Cargo.toml rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/Cargo.toml.orig rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/src/cli.rs rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/src/platform.rs rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/src/purl.rs rust-cargo-cyclonedx-0.5.9-build/cargo-cyclonedx-0.5.9/tests/cli.rs ``` The `.json` files can be ignored, but the `src/main.rs` is valid. - (non-blocker) `rust-cargo_metadata0.18` compat package is being picked up
Thanks for the review! I filed https://github.com/CycloneDX/cyclonedx-rust-cargo/issues/864 about the MIT attribution in src/main.rs. If upstream doesn’t respond reasonably promptly, then I’ll go ahead and patch in an MIT license file and adjust the SPDX expression downstream. > - (non-blocker) `rust-cargo_metadata0.18` compat package is being picked up I did notice this. The cargo_metadata crate has been through some rather drastic API changes over time, and migrating to the latest version is not a casual task.
As discussed in https://github.com/CycloneDX/cyclonedx-rust-cargo/issues/864, upstream is going to try to get https://github.com/sensorfu/cargo-bom to relicense any portion of cargo-bom that may be present in cargo-cyclonedx to Apache-2.0, but in the interim I have patched in the cargo-bom attribution and license text from src/main.rs in its own file, and adjusted the license from “Apache-2.0” to “Apache-2.0 AND MIT”. Spec URL: https://music.fedorapeople.org/20260415/rust-cargo-cyclonedx.spec SRPM URL: https://music.fedorapeople.org/20260415/rust-cargo-cyclonedx-0.5.9-1.fc43.src.rpm
Cool, all lgtm then --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0", "Apache License 2.0 and/or MIT License", "*No copyright* The Unlicense", "*No copyright* MIT License", "*No copyright* BSD 2-Clause License". 9 files have unknown license. Detailed output of licensecheck in /home/cle/FedoraRPMs/2453357-rust- cargo-cyclonedx/srpm/review-rust-cargo-cyclonedx/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [-]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 16259 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cargo- cyclonedx , rust-cargo-cyclonedx-devel , rust-cargo-cyclonedx+default- devel [?]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. (relevant issue linked and being resolved, the original license was copied) [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: cargo-cyclonedx-0.5.9-1.fc45.x86_64.rpm rust-cargo-cyclonedx-devel-0.5.9-1.fc45.noarch.rpm rust-cargo-cyclonedx+default-devel-0.5.9-1.fc45.noarch.rpm rust-cargo-cyclonedx-0.5.9-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp96tlb20_')] checks: 32, packages: 4 cargo-cyclonedx.x86_64: W: no-manual-page-for-binary cargo-cyclonedx 4 packages and 0 specfiles checked; 0 errors, 1 warnings, 16 filtered, 0 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "rust-cargo-cyclonedx+default-devel". (none): E: there is no installed rpm "rust-cargo-cyclonedx-devel". ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s (none): E: there is no installed rpm "cargo-cyclonedx". There are no files to process nor additional arguments. Nothing to do, aborting. Source checksums ---------------- https://crates.io/api/v1/crates/cargo-cyclonedx/0.5.9/download#/cargo-cyclonedx-0.5.9.crate : CHECKSUM(SHA256) this package : 5d162f67705f0f5038759d73bf546a083bf30e8677c2e944b416bca48d9d69a8 CHECKSUM(SHA256) upstream package : 5d162f67705f0f5038759d73bf546a083bf30e8677c2e944b416bca48d9d69a8 Requires -------- cargo-cyclonedx (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) rtld(GNU_HASH) rust-cargo-cyclonedx-devel (rpmlib, GLIBC filtered): (crate(anyhow/default) >= 1.0.75 with crate(anyhow/default) < 2.0.0~) (crate(cargo-lock/default) >= 11.0.1 with crate(cargo-lock/default) < 12.0.0~) (crate(cargo_metadata/default) >= 0.18.1 with crate(cargo_metadata/default) < 0.19.0~) (crate(clap/default) >= 4.4.11 with crate(clap/default) < 5.0.0~) (crate(clap/derive) >= 4.4.11 with crate(clap/derive) < 5.0.0~) (crate(cyclonedx-bom/default) >= 0.8.1 with crate(cyclonedx-bom/default) < 0.9.0~) (crate(env_logger/default) >= 0.11.0 with crate(env_logger/default) < 0.12.0~) (crate(log/default) >= 0.4.20 with crate(log/default) < 0.5.0~) (crate(once_cell/default) >= 1.18.0 with crate(once_cell/default) < 2.0.0~) (crate(pathdiff/camino) >= 0.2.1 with crate(pathdiff/camino) < 0.3.0~) (crate(pathdiff/default) >= 0.2.1 with crate(pathdiff/default) < 0.3.0~) (crate(percent-encoding/default) >= 2.3.1 with crate(percent-encoding/default) < 3.0.0~) (crate(purl) >= 0.1.3 with crate(purl) < 0.2.0~) (crate(purl/package-type) >= 0.1.3 with crate(purl/package-type) < 0.2.0~) (crate(regex/default) >= 1.9.3 with crate(regex/default) < 2.0.0~) (crate(serde/default) >= 1.0.193 with crate(serde/default) < 2.0.0~) (crate(serde/derive) >= 1.0.193 with crate(serde/derive) < 2.0.0~) (crate(thiserror/default) >= 2.0.0 with crate(thiserror/default) < 3.0.0~) (crate(time/default) >= 0.3.36 with crate(time/default) < 0.4.0~) (crate(validator/default) >= 0.20.0 with crate(validator/default) < 0.21.0~) cargo rust rust-cargo-cyclonedx+default-devel (rpmlib, GLIBC filtered): cargo crate(cargo-cyclonedx) Provides -------- cargo-cyclonedx: cargo-cyclonedx cargo-cyclonedx(x86-64) rust-cargo-cyclonedx-devel: crate(cargo-cyclonedx) rust-cargo-cyclonedx-devel rust-cargo-cyclonedx+default-devel: crate(cargo-cyclonedx/default) rust-cargo-cyclonedx+default-devel Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -n rust-cargo-cyclonedx --prebuilt Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Haskell, fonts, PHP, C/C++, Ocaml, Python, Perl, R, SugarActivity, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thank you for the review! https://release-monitoring.org/project/389295/
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cargo-cyclonedx
FEDORA-2026-ada06d388a (rust-cargo-cyclonedx-0.5.9-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-ada06d388a
FEDORA-2026-ada06d388a (rust-cargo-cyclonedx-0.5.9-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.