Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://download.copr.fedorainfracloud.org/results/kmarinos/amdgpu_top/srpm-builds/10279620/amdgpu_top.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/kmarinos/amdgpu_top/srpm-builds/10279620/amdgpu_top-0.11.3-1.fc45.src.rpm Description: Written in Rust, amdgpu_top is a tool that displays AMDGPU usage. It gathers information from performance counters (GRBM, GRBM2), sensors, fdinfo, gpu_metrics, and the AMDGPU driver to provide real-time monitoring of AMD graphics cards. Fedora Account System Username: kmarinos
Copr build: https://copr.fedorainfracloud.org/coprs/build/10280944 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2453438-amdgpu_top/fedora-rawhide-x86_64/10280944-amdgpu_top/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Tested amdgpu_top v0.11.3 (installed from upstream GitHub RPM) on Fedora 44 Beta, kernel 7.0.0 vanilla, KDE Plasma 6.6.3, Wayland. Hardware: AMD Radeon RX 9070 XT (GFX1201/RDNA4). The tool correctly identifies the GPU, reports VRAM usage (16304 MiB total), per-process GPU memory breakdown, clock speeds (500-2570 MHz), and all GRBM/GRBM2 performance counters. Media engine activity also visible. Everything works correctly on Wayland. Note: the gcc/gcc-c++ BuildRequires flag from the review service is expected — this is a Rust project and does not require gcc.
SPEC URL: https://download.copr.fedorainfracloud.org/results/kmarinos/amdgpu_top/fedora-rawhide-x86_64/10427719-amdgpu_top/amdgpu_top.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/kmarinos/amdgpu_top/fedora-rawhide-x86_64/10427719-amdgpu_top/amdgpu_top-0.11.4-1.fc45.src.rpm Changes: Updated to v0.11.4
Spec URL: https://download.copr.fedorainfracloud.org/results/kmarinos/amdgpu_top/fedora-rawhide-x86_64/10427719-amdgpu_top/amdgpu_top.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/kmarinos/amdgpu_top/fedora-rawhide-x86_64/10427719-amdgpu_top/amdgpu_top-0.11.4-1.fc45.src.rpm Changes: Updated to v0.11.4
I tried it out, it works! This is my first rust package to review so bear with me as I look at. https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/ This looks like it may have come from rust2rpm. The src vendor package looked custom, so i did a rust2rpm -t fedora -V auto amdgpu_top and it automagically created the source and vendor. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* Apache License 2.0", "BSD 0-Clause License", "*No copyright* MIT License", license just has MIT now. The hard part will be going through the licensecheck.txt and identifying possible issues. I was surprised how much vendor things was pulled in for essentially a replacement for btop. could this be pared down? Since so much is bundled, i am wondering about this part of the guidlines 'all bundled crate dependencies MUST be declared with virtual Provides in the format Provides: bundled(crate($crate)) = $version' Is this being done ?
Spec URL: https://download.copr.fedorainfracloud.org/results/kmarinos/amdgpu_top/srpm-builds/10489017/amdgpu_top.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/kmarinos/amdgpu_top/srpm-builds/10489017/amdgpu_top-0.11.4-1.fc45.src.rpm Changes: Fixed and added licenses. > (In reply to Tom.Rix from comment #5) > I was surprised how much vendor things was pulled in for essentially a > replacement for btop. > could this be pared down? I took a look to see if I could pare anything down, but unfortunately was not able to. This seems somewhat common for rust packages within the Fedora ecosystem. > Since so much is bundled, i am wondering about this part of the guidlines > > 'all bundled crate dependencies MUST be declared with virtual Provides in > the format Provides: bundled(crate($crate)) = $version' > > Is this being done ? This is being handled automatically by cargo-rpm-macros. The %{cargo_vendor_manifest} macro in the %build section generates the cargo-vendor.txt file, to which cargo-rpm-acros automatically creates the Provides: bundled(crate(...)) = $version entries from it. I verified it by running: rpm -qp --provides amdgpu_top-0.11.4-*.x86_64.rpm | grep bundled This will show all the vendored crates declared as bundled provides.
Spec URL: https://download.copr.fedorainfracloud.org/results/kmarinos/amdgpu_top/srpm-builds/10826826/amdgpu_top.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/kmarinos/amdgpu_top/srpm-builds/10826826/amdgpu_top-0.11.5-1.fc45.src.rpm Changes: - Fixed discrepancy in git revision - Added thorough comments and documentation within the spec for future maintainer-ship and reproducing.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10832922 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2453438-amdgpu_top/fedora-rawhide-x86_64/10832922-amdgpu_top/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Not a valid SPDX expression 'MIT AND Apache-2.0 AND (MIT OR Apache-2.0) AND (0BSD OR MIT OR Apache-2.0) AND (Apache-2.0 OR BSL-1.0) AND (Apache-2.0 OR GPL-2.0-only) AND (Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT) AND (BSD-2-Clause OR Apache-2.0 OR MIT) AND (BSD-3-Clause OR Apache-2.0) AND (BSD-3-Clause OR MIT OR Apache-2.0) AND BSL-1.0 AND CC0-1.0 AND ISC AND (MIT OR Apache-2.0 OR LGPL-2.1-or-later) AND (MIT OR Apache-2.0 OR Zlib) AND (Unlicense OR MIT) AND Zlib AND Unicode-3.0 AND OFL-1.1 AND Ubuntu-font-1.0'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/kmarinos/amdgpu_top/srpm-builds/10843043/amdgpu_top.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/kmarinos/amdgpu_top/srpm-builds/10843043/amdgpu_top-0.11.5-1.fc45.src.rpm Changes: - Added BuildRequires: gcc: While amdgpu_top is primarily a Rust application, it interfaces with system C libraries (libdrm, libX11, wayland) via FFI. During %cargo_build, the Rust build scripts require a C compiler to parse C headers and generate the bindings. - Simplified and Updated the SPDX License String: Reduced the redundant OR clauses from the generated list (e.g., MIT AND (MIT OR Apache-2.0) which logically reduces to just MIT) to clean up the spec file. String should now accurately reflect the assets pulled in by GUI dependencies and the upstream project.
Created attachment 2154138 [details] The .spec file difference from Copr build 10832922 to 10843155
Copr build: https://copr.fedorainfracloud.org/coprs/build/10843155 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2453438-amdgpu_top/fedora-rawhide-x86_64/10843155-amdgpu_top/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'MIT AND Apache-2.0 AND BSL-1.0 AND CC0-1.0 AND ISC AND OFL-1.1 AND Ubuntu-font-1.0 AND Unicode-3.0 AND Zlib'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/kmarinos/amdgpu_top/srpm-builds/10843881/amdgpu_top.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/kmarinos/amdgpu_top/srpm-builds/10843881/amdgpu_top-0.11.5-1.fc45.src.rpm Changes: - Removed Ubuntu-Font-1.0 as it is now deprecated.
Created attachment 2154201 [details] The .spec file difference from Copr build 10843155 to 10843902
Copr build: https://copr.fedorainfracloud.org/coprs/build/10843902 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2453438-amdgpu_top/fedora-rawhide-x86_64/10843902-amdgpu_top/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Our paths crosss at bit, this was yesterdays specfile. Recent change is for ubuntu font and i mention it below.. yeah great minds! Still some work to do on the licenses and stripping fonts and binaries out of the source. check the arches this is to run on, i suspect its this https://src.fedoraproject.org/rpms/rocm-smi/blob/rawhide/f/rocm-smi.spec#_116 Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Rust application.. - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'MIT AND Apache-2.0 AND (MIT OR Apache-2.0) AND (0BSD OR MIT OR Apache-2.0) AND (Apache-2.0 OR BSL-1.0) AND (Apache-2.0 OR GPL-2.0-only) AND (Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT) AND (BSD-2-Clause OR Apache-2.0 OR MIT) AND (BSD-3-Clause OR Apache-2.0) AND (BSD-3-Clause OR MIT OR Apache-2.0) AND BSL-1.0 AND CC0-1.0 AND ISC AND (MIT OR Apache-2.0 OR LGPL-2.1-or-later) AND (MIT OR Apache-2.0 OR Zlib) AND (Unlicense OR MIT) AND Zlib AND Unicode-3.0 AND OFL-1.1 AND Ubuntu-font-1.0'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ Ubuntu-font-1.0 - not in list ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* Apache License 2.0", "BSD 0-Clause License", "*No copyright* MIT License", "*No copyright* The Unlicense", "Apache License 2.0", "*No copyright* Apache License (v2.0) or MIT license and/or MIT License", "Apache License 2.0 and/or MIT License", "zlib License", "*No copyright* zlib License", "*No copyright* Apache License (v2.0) or MIT license", "*No copyright* BSD 3-Clause License and/or Creative Commons Attribution 3.0 and/or MIT License", "*No copyright* Creative Commons CC0 1.0", "Apache License (v2.0) or MIT license and/or BSD 3-Clause License", "BSD 3-Clause License", "Apache License (v2.0) or MIT license", "*No copyright* Boost Software License 1.0", "Unicode License Agreement - Data Files and Software (2016)", "ISC License", "*No copyright* Apache License 2.0 and/or MIT License", "*No copyright* zlib License [generated file]", "*No copyright* SIL Open Font License", "Apache License 2.0 and/or GNU Lesser General Public License v2.1 or later and/or MIT License", "GNU General Public License, Version 2", "*No copyright* Apache License (v2.0) or GNU General Public License (v2.0)", "*No copyright* Mozilla Public License 2.0", "BSD 2-Clause License", "SIL Open Font License 1.1", "*No copyright* SIL Open Font License 1.1", "*No copyright* W3C License", "Apache License 2.0 and/or Boost Software License 1.0", "*No copyright* Public domain", "GNU Lesser General Public License, Version 2.1", "Creative Commons CC0 1.0", "W3C Software and Document Notice and License (2015-05-13)", "Apache License 2.0 and/or MIT License [generated file]", "Khronos License", "*No copyright* BSD 3-Clause License", "Historical Permission Notice and Disclaimer - sell variant and/or NTP License (legal disclaimer)", "*No copyright* Creative Commons Attribution- ShareAlike 4.0", "*No copyright* GNU General Public License, Version 2", "CMU License". 24990 files have unknown license. Detailed output of licensecheck in /sfs/fedora-review/amd-gpu-top/review- amdgpu_top/licensecheck.txt [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. There are license in the licencecheck.txt ex/ W3C Software and Document Notice and License (2015-05-13) --------------------------------------------------------- amdgpu_top-0.11.5-build/amdgpu_top-0.11.5/vendor/winit-0.30.13/src/keyboard.rs That do not get covered by the general license LICENSE.dependencies like Apache-2.0: winit v0.30.13 So there should be hopefully small section of comments under the License: like # There are some files not covered by the LICENSE or LICENSE.dependencies file # W3C # vendor/winit-0.30.13/src/keyboard.rs # # MPL-2.0 # vendor/uluru-3.1.0/LICENSE # vendor/uluru-3.1.0/src/lib.rs # # Public Domain / LicenseRef-Fedora-Public-Domain # vendor/tiff-0.11.3/tests/COPYRIGHT etc.. Make sure these get added to the License: W3C AND MPL-2.0 AND LicenseRef-Fedora-Public-Domain [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [!]: Sources contain only permissible code or content. Check for fonts installed. A number of *.ttf's show up with find. As well as the licenses above say 'Font ... ' A few other binaries show up I unpacked the tar balls and did find srpm-unpacked -type f -exec file {} + | grep -E 'ELF|Mach-O|PE32|WebAssembly' srpm-unpacked/vendor/wit-component-0.244.0/libdl.so: WebAssembly (wasm) binary version 0x1 (MVP module) srpm-unpacked/vendor/wit-bindgen-0.51.0/src/rt/wit_bindgen_cabi_wasip3.o: WebAssembly (wasm) binary version 0x1 (MVP module) srpm-unpacked/vendor/wit-bindgen-0.51.0/src/rt/wit_bindgen_cabi_realloc.o: WebAssembly (wasm) binary version 0x1 (MVP module) srpm-unpacked/vendor/wit-bindgen-0.51.0/wasi-cli.0.wasm: WebAssembly (wasm) binary version 0x1000d (component) srpm-unpacked/vendor/wit-bindgen-0.57.1/src/rt/wit_bindgen_cabi_wasip3.o: WebAssembly (wasm) binary version 0x1 (MVP module) srpm-unpacked/vendor/wit-bindgen-0.57.1/src/rt/wit_bindgen_cabi_realloc.o: WebAssembly (wasm) binary version 0x1 (MVP module) srpm-unpacked/vendor/wit-bindgen-0.57.1/wasi-cli.0.wasm: WebAssembly (wasm) binary version 0x1000d (component) srpm-unpacked/vendor/libloading-0.8.9/tests/nagisa64.dll: PE32+ executable for MS Windows 6.00 (DLL), x86-64, 3 sections srpm-unpacked/vendor/libloading-0.8.9/tests/nagisa32.dll: PE32 executable for MS Windows 6.00 (DLL), Intel i386, 4 sections srpm-unpacked/vendor/wit-parser-0.244.0/tests/ui/kinds-of-deps/deps/e.wasm: WebAssembly (wasm) binary version 0x1000d (component) remove these in the %prep stage. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 13324 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [!]: Package should compile and build into binary rpms on all supported architectures. Package should depended on amdgpu kernel module. See rocm-smi for likely ExclusiveArch. [-]: %check is present and all tests pass. No tests actually run. check on this. Running `/builddir/build/BUILD/amdgpu_top-0.11.5-build/amdgpu_top-0.11.5/target/rpm/deps/amdgpu_top-6482dc32b641a46e` running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: amdgpu_top-0.11.5-1.fc45.x86_64.rpm amdgpu_top-0.11.5-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpirpsa4xe')] checks: 32, packages: 2 amdgpu_top.src: E: spelling-error ('fdinfo', '%description -l en_US fdinfo -> info') amdgpu_top.x86_64: E: spelling-error ('fdinfo', '%description -l en_US fdinfo -> info') amdgpu_top.x86_64: W: no-manual-page-for-binary amdgpu_top amdgpu_top.spec: W: invalid-url Source1: amdgpu_top-0.11.5-vendor.tar.xz 2 packages and 0 specfiles checked; 2 errors, 2 warnings, 7 filtered, 2 badness; has taken 38.1 s Rpmlint (debuginfo) ------------------- Checking: amdgpu_top-debuginfo-0.11.5-1.fc45.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp5uofhfpp')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 3.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 amdgpu_top.x86_64: E: spelling-error ('fdinfo', '%description -l en_US fdinfo -> info') amdgpu_top.x86_64: W: no-manual-page-for-binary amdgpu_top 2 packages and 0 specfiles checked; 1 errors, 1 warnings, 9 filtered, 1 badness; has taken 0.3 s Source checksums ---------------- https://github.com/Umio-Yasuno/amdgpu_top/archive/v0.11.5/amdgpu_top-0.11.5.tar.gz : CHECKSUM(SHA256) this package : e511ed15a6e0f3ea72321dfc97145ffb85999b37b6b304e9795978945f3f04cd CHECKSUM(SHA256) upstream package : e511ed15a6e0f3ea72321dfc97145ffb85999b37b6b304e9795978945f3f04cd Requires -------- amdgpu_top (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdrm.so.2()(64bit) libdrm_amdgpu.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libm.so.6()(64bit) rtld(GNU_HASH) Provides -------- amdgpu_top: amdgpu_top amdgpu_top(x86-64) bundled(crate(ab_glyph)) bundled(crate(ab_glyph_rasterizer)) bundled(crate(adler2)) bundled(crate(ahash)) bundled(crate(allocator-api2)) bundled(crate(android-activity)) bundled(crate(android-properties)) bundled(crate(android_system_properties)) bundled(crate(arboard)) bundled(crate(arc-swap)) bundled(crate(arrayvec)) bundled(crate(as-raw-xcb-connection)) bundled(crate(ash)) bundled(crate(atomic-waker)) bundled(crate(autocfg)) bundled(crate(base64)) bundled(crate(basic-toml)) bundled(crate(bit-set)) bundled(crate(bit-vec)) bundled(crate(bitflags)) bundled(crate(block-buffer)) bundled(crate(block2)) bundled(crate(bstr)) bundled(crate(bumpalo)) bundled(crate(bytemuck)) bundled(crate(bytemuck_derive)) bundled(crate(byteorder)) bundled(crate(byteorder-lite)) bundled(crate(bytes)) bundled(crate(bytesize)) bundled(crate(calloop)) bundled(crate(calloop-wayland-source)) bundled(crate(castaway)) bundled(crate(cc)) bundled(crate(cfg-if)) bundled(crate(cfg_aliases)) bundled(crate(clipboard-win)) bundled(crate(clru)) bundled(crate(codespan-reporting)) bundled(crate(combine)) bundled(crate(compact_str)) bundled(crate(concurrent-queue)) bundled(crate(core-foundation)) bundled(crate(core-foundation-sys)) bundled(crate(core-graphics)) bundled(crate(core-graphics-types)) bundled(crate(cpufeatures)) bundled(crate(crc32fast)) bundled(crate(crossbeam-channel)) bundled(crate(crossbeam-utils)) bundled(crate(crossterm)) bundled(crate(crossterm_winapi)) bundled(crate(crunchy)) bundled(crate(crypto-common)) bundled(crate(cursive)) bundled(crate(cursive-macros)) bundled(crate(cursive_core)) bundled(crate(cursor-icon)) bundled(crate(darling)) bundled(crate(darling_core)) bundled(crate(darling_macro)) bundled(crate(dashmap)) bundled(crate(deranged)) bundled(crate(digest)) bundled(crate(dispatch)) bundled(crate(displaydoc)) bundled(crate(dlib)) bundled(crate(document-features)) bundled(crate(downcast-rs)) bundled(crate(dpi)) bundled(crate(dunce)) bundled(crate(ecolor)) bundled(crate(eframe)) bundled(crate(egui)) bundled(crate(egui-wgpu)) bundled(crate(egui-winit)) bundled(crate(egui_plot)) bundled(crate(emath)) bundled(crate(encoding_rs)) bundled(crate(enum-map)) bundled(crate(enum-map-derive)) bundled(crate(enumset)) bundled(crate(enumset_derive)) bundled(crate(epaint)) bundled(crate(epaint_default_fonts)) bundled(crate(equivalent)) bundled(crate(errno)) bundled(crate(error-code)) bundled(crate(faster-hex)) bundled(crate(fastrand)) bundled(crate(fax)) bundled(crate(fax_derive)) bundled(crate(fdeflate)) bundled(crate(filetime)) bundled(crate(find-crate)) bundled(crate(find-msvc-tools)) bundled(crate(flate2)) bundled(crate(fluent)) bundled(crate(fluent-bundle)) bundled(crate(fluent-langneg)) bundled(crate(fluent-syntax)) bundled(crate(fnv)) bundled(crate(foldhash)) bundled(crate(foreign-types)) bundled(crate(foreign-types-macros)) bundled(crate(foreign-types-shared)) bundled(crate(form_urlencoded)) bundled(crate(futures-core)) bundled(crate(futures-task)) bundled(crate(futures-util)) bundled(crate(generic-array)) bundled(crate(gethostname)) bundled(crate(getrandom)) bundled(crate(gix)) bundled(crate(gix-actor)) bundled(crate(gix-archive)) bundled(crate(gix-attributes)) bundled(crate(gix-bitmap)) bundled(crate(gix-blame)) bundled(crate(gix-chunk)) bundled(crate(gix-command)) bundled(crate(gix-commitgraph)) bundled(crate(gix-config)) bundled(crate(gix-config-value)) bundled(crate(gix-credentials)) bundled(crate(gix-date)) bundled(crate(gix-diff)) bundled(crate(gix-dir)) bundled(crate(gix-discover)) bundled(crate(gix-error)) bundled(crate(gix-features)) bundled(crate(gix-filter)) bundled(crate(gix-fs)) bundled(crate(gix-glob)) bundled(crate(gix-hash)) bundled(crate(gix-hashtable)) bundled(crate(gix-ignore)) bundled(crate(gix-index)) bundled(crate(gix-lock)) bundled(crate(gix-mailmap)) bundled(crate(gix-negotiate)) bundled(crate(gix-object)) bundled(crate(gix-odb)) bundled(crate(gix-pack)) bundled(crate(gix-packetline)) bundled(crate(gix-path)) bundled(crate(gix-pathspec)) bundled(crate(gix-prompt)) bundled(crate(gix-protocol)) bundled(crate(gix-quote)) bundled(crate(gix-ref)) bundled(crate(gix-refspec)) bundled(crate(gix-revision)) bundled(crate(gix-revwalk)) bundled(crate(gix-sec)) bundled(crate(gix-shallow)) bundled(crate(gix-status)) bundled(crate(gix-submodule)) bundled(crate(gix-tempfile)) bundled(crate(gix-trace)) bundled(crate(gix-transport)) bundled(crate(gix-traverse)) bundled(crate(gix-url)) bundled(crate(gix-utils)) bundled(crate(gix-validate)) bundled(crate(gix-worktree)) bundled(crate(gix-worktree-state)) bundled(crate(gix-worktree-stream)) bundled(crate(gl_generator)) bundled(crate(glow)) bundled(crate(glutin_wgl_sys)) bundled(crate(gpu-alloc)) bundled(crate(gpu-alloc-types)) bundled(crate(gpu-descriptor)) bundled(crate(gpu-descriptor-types)) bundled(crate(half)) bundled(crate(hash32)) bundled(crate(hashbrown)) bundled(crate(heapless)) bundled(crate(hermit-abi)) bundled(crate(hexf-parse)) bundled(crate(home)) bundled(crate(human_format)) bundled(crate(i18n-config)) bundled(crate(i18n-embed)) bundled(crate(i18n-embed-fl)) bundled(crate(i18n-embed-impl)) bundled(crate(icu_collections)) bundled(crate(icu_locale_core)) bundled(crate(icu_normalizer)) bundled(crate(icu_normalizer_data)) bundled(crate(icu_properties)) bundled(crate(icu_properties_data)) bundled(crate(icu_provider)) bundled(crate(ident_case)) bundled(crate(idna)) bundled(crate(idna_adapter)) bundled(crate(image)) bundled(crate(imara-diff)) bundled(crate(indexmap)) bundled(crate(intl-memoizer)) bundled(crate(intl_pluralrules)) bundled(crate(io-close)) bundled(crate(itoa)) bundled(crate(jiff)) bundled(crate(jiff-static)) bundled(crate(jiff-tzdb)) bundled(crate(jiff-tzdb-platform)) bundled(crate(jni)) bundled(crate(jni-macros)) bundled(crate(jni-sys)) bundled(crate(jni-sys-macros)) bundled(crate(jobserver)) bundled(crate(js-sys)) bundled(crate(khronos-egl)) bundled(crate(khronos_api)) bundled(crate(kstring)) bundled(crate(lazy_static)) bundled(crate(libc)) bundled(crate(libdrm_amdgpu_sys)) bundled(crate(libloading)) bundled(crate(libm)) bundled(crate(libredox)) bundled(crate(linux-raw-sys)) bundled(crate(litemap)) bundled(crate(litrs)) bundled(crate(lock_api)) bundled(crate(log)) bundled(crate(malloc_buf)) bundled(crate(maybe-async)) bundled(crate(memchr)) bundled(crate(memmap2)) bundled(crate(miniz_oxide)) bundled(crate(mio)) bundled(crate(moxcms)) bundled(crate(naga)) bundled(crate(ndk)) bundled(crate(ndk-context)) bundled(crate(ndk-sys)) bundled(crate(nix)) bundled(crate(nohash-hasher)) bundled(crate(nonempty)) bundled(crate(num)) bundled(crate(num-complex)) bundled(crate(num-conv)) bundled(crate(num-integer)) bundled(crate(num-iter)) bundled(crate(num-rational)) bundled(crate(num-traits)) bundled(crate(num_enum)) bundled(crate(num_enum_derive)) bundled(crate(num_threads)) bundled(crate(objc)) bundled(crate(objc-sys)) bundled(crate(objc2)) bundled(crate(objc2-app-kit)) bundled(crate(objc2-core-foundation)) bundled(crate(objc2-core-graphics)) bundled(crate(objc2-encode)) bundled(crate(objc2-foundation)) bundled(crate(objc2-ui-kit)) bundled(crate(once_cell)) bundled(crate(orbclient)) bundled(crate(ordered-float)) bundled(crate(owned_ttf_parser)) bundled(crate(parking_lot)) bundled(crate(parking_lot_core)) bundled(crate(percent-encoding)) bundled(crate(pin-project)) bundled(crate(pin-project-internal)) bundled(crate(pin-project-lite)) bundled(crate(pkg-config)) bundled(crate(plain)) bundled(crate(png)) bundled(crate(polling)) bundled(crate(pollster)) bundled(crate(portable-atomic)) bundled(crate(portable-atomic-util)) bundled(crate(potential_utf)) bundled(crate(powerfmt)) bundled(crate(proc-macro-crate)) bundled(crate(proc-macro-error-attr2)) bundled(crate(proc-macro-error2)) bundled(crate(proc-macro2)) bundled(crate(prodash)) bundled(crate(profiling)) bundled(crate(pxfm)) bundled(crate(quick-error)) bundled(crate(quick-xml)) bundled(crate(quote)) bundled(crate(r-efi)) bundled(crate(raw-window-handle)) bundled(crate(redox_syscall)) bundled(crate(regex)) bundled(crate(regex-automata)) bundled(crate(regex-syntax)) bundled(crate(renderdoc-sys)) bundled(crate(ron)) bundled(crate(rust-embed)) bundled(crate(rust-embed-impl)) bundled(crate(rust-embed-utils)) bundled(crate(rustc-hash)) bundled(crate(rustc_version)) bundled(crate(rustix)) bundled(crate(rustversion)) bundled(crate(ryu)) bundled(crate(same-file)) bundled(crate(scoped-tls)) bundled(crate(scopeguard)) bundled(crate(self_cell)) bundled(crate(semver)) bundled(crate(serde)) bundled(crate(serde_core)) bundled(crate(serde_derive)) bundled(crate(serde_json)) bundled(crate(sha1)) bundled(crate(sha1-checked)) bundled(crate(sha2)) bundled(crate(shell-words)) bundled(crate(shlex)) bundled(crate(signal-hook)) bundled(crate(signal-hook-mio)) bundled(crate(signal-hook-registry)) bundled(crate(simd-adler32)) bundled(crate(simd_cesu8)) bundled(crate(simdutf8)) bundled(crate(slab)) bundled(crate(slotmap)) bundled(crate(smallvec)) bundled(crate(smithay-client-toolkit)) bundled(crate(smithay-clipboard)) bundled(crate(smol_str)) bundled(crate(spirv)) bundled(crate(stable_deref_trait)) bundled(crate(static_assertions)) bundled(crate(strsim)) bundled(crate(syn)) bundled(crate(synstructure)) bundled(crate(sys-locale)) bundled(crate(tempfile)) bundled(crate(termsize)) bundled(crate(thiserror)) bundled(crate(thiserror-impl)) bundled(crate(tiff)) bundled(crate(time)) bundled(crate(time-core)) bundled(crate(tinystr)) bundled(crate(tinyvec)) bundled(crate(tinyvec_macros)) bundled(crate(toml)) bundled(crate(toml_datetime)) bundled(crate(toml_edit)) bundled(crate(toml_parser)) bundled(crate(tracing)) bundled(crate(tracing-core)) bundled(crate(ttf-parser)) bundled(crate(type-map)) bundled(crate(typenum)) bundled(crate(uluru)) bundled(crate(unic-langid)) bundled(crate(unic-langid-impl)) bundled(crate(unicode-bom)) bundled(crate(unicode-ident)) bundled(crate(unicode-normalization)) bundled(crate(unicode-segmentation)) bundled(crate(unicode-width)) bundled(crate(url)) bundled(crate(utf8_iter)) bundled(crate(version_check)) bundled(crate(walkdir)) bundled(crate(wasi)) bundled(crate(wasip2)) bundled(crate(wasip3)) bundled(crate(wasm-bindgen)) bundled(crate(wasm-bindgen-futures)) bundled(crate(wasm-bindgen-macro)) bundled(crate(wasm-bindgen-macro-support)) bundled(crate(wasm-bindgen-shared)) bundled(crate(wayland-backend)) bundled(crate(wayland-client)) bundled(crate(wayland-csd-frame)) bundled(crate(wayland-cursor)) bundled(crate(wayland-protocols)) bundled(crate(wayland-protocols-experimental)) bundled(crate(wayland-protocols-misc)) bundled(crate(wayland-protocols-plasma)) bundled(crate(wayland-protocols-wlr)) bundled(crate(wayland-scanner)) bundled(crate(wayland-sys)) bundled(crate(web-sys)) bundled(crate(web-time)) bundled(crate(webbrowser)) bundled(crate(weezl)) bundled(crate(wgpu)) bundled(crate(wgpu-core)) bundled(crate(wgpu-core-deps-emscripten)) bundled(crate(wgpu-core-deps-windows-linux-android)) bundled(crate(wgpu-hal)) bundled(crate(wgpu-types)) bundled(crate(winapi)) bundled(crate(winapi-i686-pc-windows-gnu)) bundled(crate(winapi-util)) bundled(crate(winapi-x86_64-pc-windows-gnu)) bundled(crate(windows)) bundled(crate(windows-core)) bundled(crate(windows-implement)) bundled(crate(windows-interface)) bundled(crate(windows-link)) bundled(crate(windows-result)) bundled(crate(windows-strings)) bundled(crate(windows-sys)) bundled(crate(windows-targets)) bundled(crate(windows_aarch64_gnullvm)) bundled(crate(windows_aarch64_msvc)) bundled(crate(windows_i686_gnu)) bundled(crate(windows_i686_gnullvm)) bundled(crate(windows_i686_msvc)) bundled(crate(windows_x86_64_gnu)) bundled(crate(windows_x86_64_gnullvm)) bundled(crate(windows_x86_64_msvc)) bundled(crate(winit)) bundled(crate(winnow)) bundled(crate(wit-bindgen)) bundled(crate(writeable)) bundled(crate(x11-dl)) bundled(crate(x11rb)) bundled(crate(x11rb-protocol)) bundled(crate(xcursor)) bundled(crate(xi-unicode)) bundled(crate(xkbcommon-dl)) bundled(crate(xkeysym)) bundled(crate(xml-rs)) bundled(crate(yoke)) bundled(crate(yoke-derive)) bundled(crate(zerocopy)) bundled(crate(zerocopy-derive)) bundled(crate(zerofrom)) bundled(crate(zerofrom-derive)) bundled(crate(zerotrie)) bundled(crate(zerovec)) bundled(crate(zerovec-derive)) bundled(crate(zlib-rs)) bundled(crate(zmij)) bundled(crate(zune-core)) bundled(crate(zune-jpeg)) Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -n amdgpu_top Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Ocaml, Perl, Python, Java, Haskell, fonts, SugarActivity, R, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Spec URL: https://download.copr.fedorainfracloud.org/results/kmarinos/amdgpu_top/srpm-builds/10877661/amdgpu_top.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/kmarinos/amdgpu_top/srpm-builds/10877661/amdgpu_top-0.11.5-1.fc45.src.rpm Changes: Licenses: - Added explanatory comments detailing the files governed by the W3C, MPL-2.0, and Public Domain licenses. - Added W3C AND MPL-2.0 AND LicenseRef-Fedora-Public-Domain to License: SPDX string. - Removed Ubuntu-font-1.0 - Stripped Pre-compiled Binaries: Added a "find ... -delete" command to %prep to remove all pre-compiled binary files from the vendored crates before building - Added a sed command to clear the Cargo checksum dictionaries so the build does not fail when checking for those deleted files - Added ExclusiveArch: x86_64 Tests: - Currently the upstream amdgpu_top project does not have any unit tests implemented in its codebase. I have left the %check section so that it will automatically run them if upstream adds them in the future. Compiler Stack: - Added export RUST_MIN_STACK=16777216 to %build to prevent a rustc stack overflow crash when compiling the wayland-protocols-wlr files in Rawhide.
Created attachment 2154968 [details] The .spec file difference from Copr build 10843902 to 10882763
Copr build: https://copr.fedorainfracloud.org/coprs/build/10882763 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2453438-amdgpu_top/fedora-rawhide-x86_64/10882763-amdgpu_top/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks for the changes. Approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/amdgpu_top Monitoring: Anitya project is accessible by this link `https://release-monitoring.org/project/359802` you can modify it manually. Package wasn't created in Anitya, reason: `Bad Request, some necessary arguments were not provided.`.