Fedora Account System
Red Hat Associate
Red Hat Customer
spec: https://suve.fedorapeople.org/review/SDL3_mixer-3.2.0-1/SDL3_mixer.spec srpm: https://suve.fedorapeople.org/review/SDL3_mixer-3.2.0-1/SDL3_mixer-3.2.0-1.fc44.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=143967835 Description: SDL3_mixer is an audio management library addon for SDL3. It provides decoding of many popular audio file formats, mixing, various DSP processing effects and positional audio. Fedora Account System Username: suve
Copr build: https://copr.fedorainfracloud.org/coprs/build/10288801 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2454358-sdl3_mixer/fedora-rawhide-x86_64/10288801-SDL3_mixer/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'Zlib AND Artistic-1.0-Perl'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to v3.2.2. spec: https://suve.fedorapeople.org/review/SDL3_mixer-3.2.2-1/SDL3_mixer.spec srpm: https://suve.fedorapeople.org/review/SDL3_mixer-3.2.2-1/SDL3_mixer-3.2.2-1.fc44.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=145458983
Copr build: https://copr.fedorainfracloud.org/coprs/build/10461257 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2454358-sdl3_mixer/fedora-rawhide-x86_64/10461257-SDL3_mixer/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'Zlib AND Artistic-1.0-Perl'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to v3.2.4. spec: https://suve.fedorapeople.org/review/SDL3_mixer-3.2.4-1/SDL3_mixer.spec srpm: https://suve.fedorapeople.org/review/SDL3_mixer-3.2.4-1/SDL3_mixer-3.2.4-1.fc44.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=146203531
Copr build: https://copr.fedorainfracloud.org/coprs/build/10553900 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2454358-sdl3_mixer/fedora-rawhide-x86_64/10553900-SDL3_mixer/fedora-review/review.txt Found issues: - Not a valid SPDX expression 'Zlib AND Artistic-1.0-Perl'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated the license tag and switched away from run-time loading of dependencies to dynamic linking at compile-time. spec: https://suve.fedorapeople.org/review/SDL3_mixer-3.2.4-2/SDL3_mixer.spec srpm: https://suve.fedorapeople.org/review/SDL3_mixer-3.2.4-2/SDL3_mixer-3.2.4-2.fc45.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=149268993 Benson, would you have some time to look at this?
It looks like you're missing the %conf section? Your %cmake call is in %prep.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10882328 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2454358-sdl3_mixer/fedora-rawhide-x86_64/10882328-SDL3_mixer/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Why did you add "Provides: bundled(timidity)" ? Timidity isn't provided as a stand alone library/executable and I don't think another package would Require: timidity and expect the embdedded version from SDL3_mixer.
> Why did you add "Provides: bundled(timidity)" ? Because the Packaging Guidelines mandate so: > All packages whose upstreams have no mechanism to build against system libraries > MAY opt to carry bundled libraries, but if they do, they MUST include an indication of what they bundle. > [...] > If the bundled package also exists separately in the distribution, use the name of that package. > Otherwise consult the Naming Guidelines to determine an appropriate name for the library > as if it were entering the distribution as a separate package. > [...] > Then at an appropriate place in your spec, add Provides: bundled(<libname>) = <version> > [...] > If it was not possible to determine a version, use Provides: bundled(<libname>) instead. https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling Also, SDL2_mixer does the same thing.
Ah right, thanks for the clarification! I guess the purpose is to provide security and vulnerability tracking, would it make sense to add a version number?
I guess we could use "bundled(timidity) = 0.2i" here, as that's what mentioned in src/timidity/README. However, I don't think that'd be very useful, for two reasons: 1) timidity 0.2i was released in 1995 and the original upstream website is long dead. There is a still-maintained fork, timidity++ (packaged in Fedora) - I assume that if upstream considered it worth the effort, they would've switched a long time ago. 2) Looking at the git repository, the bundled library has been used by SDL_mixer since the very first commit made in 1999. Over the years, it was heavily modified.