Spec URL: https://raw.githubusercontent.com/LadybugDB/ladybug-rpm/refs/heads/main/ladybug.spec SRPM URL: https://github.com/LadybugDB/ladybug-rpm/releases/download/v0.15.3/ladybug-cli-0.15.3-1.el8.src.rpm Description: Embedded graph database command-line client Fedora Account System Username: N/A All of the build artifacts are also available from: https://github.com/LadybugDB/ladybug-rpm https://github.com/LadybugDB/ladybug-rpm/actions/runs/23952555679
Thanks for bringing this to Fedora. Please link to the raw spec file and raw srpm, it should be possible to download them using wget. The shared library should have a soname: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries Please also see guidelines on packaging static libraries: https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Edited the URLs in my previous comment as requested. Please review.
I'm not a reviewer, but I have a few notes: - The spec filename should be %{name}.spec (ladybug.spec -> ladybug-cli.spec). - All of the libraries seem to be vendored upstream (https://github.com/LadybugDB/ladybug/tree/main/third_party) without any indication of this in the spec file. You might want to link against packaged versions of those libraries instead. More info: https://fedoraproject.org/wiki/Bundled_Libraries - The mock build failed on rawhide when I tried it (seemingly due to fixed-width types not being defined in one of the vendored libs). You can test this with "fedpkg mockbuild".
> https://fedoraproject.org/wiki/Bundled_Libraries This is something we inherited from DuckDB which inspired KuzuDB from which LadybugDB is forked. We're taking the same stance as what's in the URL as the north star. But it's going to take time to move. The first step is to prefer the system library if a sufficiently close version is available. Please let us know if there are best practices to follow here. Will fix the other two issues and get back to you.
Made some changes as suggested here. Ally will take it from here: https://github.com/LadybugDB/ladybug-rpm/actions/runs/24172834917/job/70547943932
This run was successful. It include fixes for two instances of missing includes for the fixed width types. https://github.com/LadybugDB/ladybug-rpm/actions/runs/24173830972/job/70550951392
In that spec file, please put liblbug.a in a seperate package if it is needed. liblbug.so should be in the devel package. See: - https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shared_libraries - https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries Many of the bundled third party libraries are packaged: https://github.com/LadybugDB/ladybug/tree/main/third_party Please use Fedora versions where possible https://docs.fedoraproject.org/en-US/fesco/Bundled_Software_policy/
Sorry for the delay. I was involved in some security improvements upstream @benson_muite I have fixed above issues and cut a new release v0.15.3-2 Spec URL: https://raw.githubusercontent.com/LadybugDB/ladybug-rpm/refs/heads/main/ladybug-cli.spec SRPM URL: https://github.com/LadybugDB/ladybug-rpm/releases/download/v0.15.3-2/ladybug-cli-0.15.3-2.fc41.src.rpm
Please let us know if this is sufficient to get started. CMake can be configured to prefer the system libs when possible.
Please use system libraries where possible, at present it seems that everything that can be bundled is bundled.
Agreed. However fully moving away from bundling may take some time. Would it be alright if we do it gradually?