Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://ppisar.fedorapeople.org/perl-DBIx-QuickDB/perl-DBIx-QuickDB.spec SRPM URL: https://ppisar.fedorapeople.org/perl-DBIx-QuickDB/perl-DBIx-QuickDB-0.000041-1.fc45.src.rpm Description: This library makes it easy to spin up a temporary database server for any supported driver. PostgreSQL, MySQL and SQLite are the initially supported drivers. Fedora Account System Username: ppisar
Copr build: https://copr.fedorainfracloud.org/coprs/build/10304079 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2456523-perl-dbix-quickdb/fedora-rawhide-x86_64/10304079-perl-DBIx-QuickDB/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The %check phase fails on postgresql tests when run as root: # Failed test 'use_it' # at t/Drivers/PostgreSQL.t line 69. # Caught exception in subtest: Timed out waiting for server to start # at /builddir/build/BUILD/perl-DBIx-QuickDB-0.000041-build/DBIx-QuickDB-0.000041/blib/lib/DBIx/QuickDB/Driver.pm line 322. # DBIx::QuickDB::Driver::start(DBIx::QuickDB::Driver::PostgreSQL=HASH(0xaaaafc898590)) called at /builddir/build/BUILD/perl-DBIx-QuickDB-0.000041-build/DBIx-QuickDB-0.000041/blib/lib/DBIx/QuickDB/Driver/PostgreSQL.pm line 200 # DBIx::QuickDB::Driver::PostgreSQL::bootstrap(DBIx::QuickDB::Driver::PostgreSQL=HASH(0xaaaafc898590)) called at /builddir/build/BUILD/perl-DBIx-QuickDB-0.000041-build/DBIx-QuickDB-0.000041/blib/lib/DBIx/QuickDB.pm line 73 # DBIx::QuickDB::build_db("DBIx::QuickDB", "db", HASH(0xaaaafc898500)) called at /builddir/build/BUILD/perl-DBIx-QuickDB-0.000041-build/DBIx-QuickDB-0.000041/blib/lib/Test2/Tools/QuickDB.pm line 70 # Test2::Tools::QuickDB::get_db("db", HASH(0xaaaafc898500)) called at t/Drivers/PostgreSQL.t line 24 # main::__ANON__() called at /usr/share/perl5/vendor_perl/Test2/API.pm line 718 # eval {...} called at /usr/share/perl5/vendor_perl/Test2/API.pm line 718 # Test2::API::run_subtest("use_it", CODE(0xaaaafc8933f8), HASH(0xaaaafc8818f8)) called at /usr/share/perl5/vendor_perl/Test2/Tools/Subtest.pm line 34 # Test2::Tools::Subtest::subtest_buffered("use_it", CODE(0xaaaafc8933f8)) called at t/Drivers/PostgreSQL.t line 69 # Failed test 'cleanup' # at t/Drivers/PostgreSQL.t line 94. # Caught exception in subtest: Timed out waiting for server to start # at /builddir/build/BUILD/perl-DBIx-QuickDB-0.000041-build/DBIx-QuickDB-0.000041/blib/lib/DBIx/QuickDB/Driver.pm line 322. # DBIx::QuickDB::Driver::start(DBIx::QuickDB::Driver::PostgreSQL=HASH(0xaaaafdbac890)) called at /builddir/build/BUILD/perl-DBIx-QuickDB-0.000041-build/DBIx-QuickDB-0.000041/blib/lib/DBIx/QuickDB/Driver/PostgreSQL.pm line 200 # DBIx::QuickDB::Driver::PostgreSQL::bootstrap(DBIx::QuickDB::Driver::PostgreSQL=HASH(0xaaaafdbac890)) called at /builddir/build/BUILD/perl-DBIx-QuickDB-0.000041-build/DBIx-QuickDB-0.000041/blib/lib/DBIx/QuickDB.pm line 73 # DBIx::QuickDB::build_db("DBIx::QuickDB", HASH(0xaaaafc8985c0)) called at /builddir/build/BUILD/perl-DBIx-QuickDB-0.000041-build/DBIx-QuickDB-0.000041/blib/lib/Test2/Tools/QuickDB.pm line 70 # Test2::Tools::QuickDB::get_db(HASH(0xaaaafc8985c0)) called at t/Drivers/PostgreSQL.t line 72 # main::__ANON__() called at /usr/share/perl5/vendor_perl/Test2/API.pm line 718 # eval {...} called at /usr/share/perl5/vendor_perl/Test2/API.pm line 718 # Test2::API::run_subtest("cleanup", CODE(0xaaaafdb4b2f0), HASH(0xaaaafc8818f8)) called at /usr/share/perl5/vendor_perl/Test2/Tools/Subtest.pm line 34 # Test2::Tools::Subtest::subtest_buffered("cleanup", CODE(0xaaaafdb4b2f0)) called at t/Drivers/PostgreSQL.t line 94 # Seeded srand with seed '20260430' from local date. t/Drivers/PostgreSQL.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/4 subtests When running the test directly by perl as root: # perl -Ilib t/Drivers/PostgreSQL.t # Seeded srand with seed '20260430' from local date. not ok 1 - use_it { } # Failed test 'use_it' # at t/Drivers/PostgreSQL.t line 68. # Caught exception in subtest: Failed to run command '/usr/bin/initdb -E UTF8 --no-locale -A trust -D /tmp/DB-QUICK-YhtgwTwg/data' (256) # initdb: error: cannot be run as root # initdb: hint: Please log in (using, e.g., "su") as the (unprivileged) user that will own the server process. # at lib/DBIx/QuickDB.pm line 73. not ok 2 - cleanup { } [...] So it is a property of /usr/bin/initdb. I will bring this failure to DBIx-QuickDB upstream.
I updated the package. It fixed running the postrgresql tests under root: Spec URL: https://ppisar.fedorapeople.org/perl-DBIx-QuickDB/perl-DBIx-QuickDB.spec SRPM URL: https://ppisar.fedorapeople.org/perl-DBIx-QuickDB/perl-DBIx-QuickDB-0.000053-1.fc45.src.rpm But now MariaDB suffers from the same problem (<https://github.com/exodist/DBIx-QuickDB/issues/13>).
Copr build: https://copr.fedorainfracloud.org/coprs/build/10714195 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2456523-perl-dbix-quickdb/fedora-rawhide-x86_64/10714195-perl-DBIx-QuickDB/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I updated the package. It fixed running the MySQL tests under root: Spec URL: https://ppisar.fedorapeople.org/perl-DBIx-QuickDB/perl-DBIx-QuickDB.spec SRPM URL: https://ppisar.fedorapeople.org/perl-DBIx-QuickDB/perl-DBIx-QuickDB-0.000054-1.fc45.src.rpm
I updated the package. It added a dependency on en_US locale: Spec URL: https://ppisar.fedorapeople.org/perl-DBIx-QuickDB/perl-DBIx-QuickDB.spec SRPM URL: https://ppisar.fedorapeople.org/perl-DBIx-QuickDB/perl-DBIx-QuickDB-0.000054-1.fc45.src.rpm
Source file is ok Summary is ok License is ok Description is ok TODO: Phrases like "This is an SQLite support for DBIx::QuickDB." feel slightly awkward. Perhaps the a/an can be dropped... URL and Source0 are ok All tests passed TODO: Since you've submitted the package for review, upstream has released several versions. Please update your package. BuildRequires are ok Binary requires are Ok. Binary provides are Ok. $ rpmlint perl-DBIx-QuickDB-*.rpm =============================================================== rpmlint session starts =============================================================== rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 6 perl-DBIx-QuickDB-tests.noarch: W: no-documentation ========================= 6 packages and 0 specfiles checked; 0 errors, 1 warnings, 26 filtered, 0 badness; has taken 0.7 s ========================== The package is in line with Fedora and Perl packaging guide lines. Please consider fixing the 'TODO' item. Resolution: Approved
https://pagure.io/releng/fedora-scm-requests/issue/84775
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-DBIx-QuickDB Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
Thanks for the review. I corrected the grammar. I will rebase the package after building this approved version.