The dsa library in Admin Server still heavily relies on the concept of a server root. This library is used by the Directory Server cgi tasks. The dsa library should try to get paths dynamically from the Directory Server config when possible. Other paths that are not in the config, such as the location of command-line utilities, should be passed in as a define at compilation time.
Created attachment 157833 [details] CVS Diffs - First Pass This is a first pass at cleaning up the paths in dsalib. These changes make the path getter functions use the Directory Server config values where possible.
Created attachment 157834 [details] CVS Commit Message (comment 1 diffs) Checked in changes from comment 1.
Created attachment 157923 [details] CVS Diffs - Second Pass This pass eliminated the usage of a "server root" in the dsa library. I also refactored some of the code that was referring to the "install root" as it did not seem to really represent the directory that it refers to. I renamed it to "instance dir" and adjusted the getter function and variables accordingly. I needed to pass in the DS libdir as a define for being able to find the instance dir in the code. I also found that I was incorrectly using the lockdir config attribute to set the rundir, which was causing problems for the start, stop, and restart CGIs. We don't have the rundir in cn=config by default, but we already have it set as a PIDDIR define, so I opted to use that instead. The start, stop, and restart CGIs now work properly.
Created attachment 157931 [details] CVS Commit Message (comment 3 diffs) Checked in changes from comment 3.
1. Based on discussion with Noriko. Since DS80 doesn't have the concept of "ServerRoot". This bug is more relate to code clean up. 2. As in the past we have many cig script relate testing, and there is no failure relate to "ServerRoot", this bug can be consider as verified.
All Console functionalities depend on this lib. And console automation test will rerun next week. If there are any broken function, I will file a new bug. For now, this bug can be closed.