Fedora Account System
Red Hat Associate
Red Hat Customer
SRPM:https://fedorapeople.org/~limb/review/fzssh/fzssh-1.1.10-1.fc45.src.rpm SPEC:https://fedorapeople.org/~limb/review/fzssh/fzssh.spec Description: fzssh is a SSH/SFTP library based on libfilezilla
Copr build: https://copr.fedorainfracloud.org/coprs/build/10326553 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2458430-fzssh/fedora-rawhide-x86_64/10326553-fzssh/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This seems to require libfilezilla >= 0.55.3, whereas the version currently in Fedora Rawhide is libfilezilla-0.54.1-2.fc45. Upstream has 0.56.1 available.
I can push 0.56.1 but then we should proceed with this quickly as that would be a soname bump and break filezilla in rawhide until this is ready. Sound ok?
Sure thing.
Ok, updated libfilezilla, and pushed latest fzssh. SRPM:https://fedorapeople.org/~limb/review/fzssh/fzssh-1.3.0-1.fc45.src.rpm SPEC:https://fedorapeople.org/~limb/review/fzssh/fzssh.spec
Overall it looks okay, just two issues: 1. The source link (https://download.filezilla-project.org/fzssh/fzssh-1.3.0.tar.xz) does not work; it gives a 307 Temporary Redirect and then moves you to filezilla's website main page. 2. The README mentions some additional restrictions placed on top of AGPLv3: > Additional Terms under AGPLv3 Section 7 (and corresponding sections in > future versions): > > Notwithstanding any other provision of this License, for any material you > use from this library, you must: > > 1. Preserve Attribution: Retain the original copyright notices and author > attributions in the source code. > > 2. Prominent Documentation Notice: If you distribute or convey the work > (or any part of it) in binary or object code form, you must include a > prominent notice in the accompanying documentation and/or "README" files > stating: > This software incorporates components from fzssh, copyright (c) 2025-2026 > Tim Kosse and Business Follows Srl > > 3. Interactive User Interfaces: If the work possesses an interactive user > interface, the "Appropriate Legal Notices" (as defined in Section 0) must > display the copyright attribution to Tim Kosse and Business Follows Srl > in a prominently visible manner (e.g., in an "About" or "Legal" menu). This seems to fall squarely under AGPLv3 Section 7b, but still - might be worth running through legal?
1. The filezilla project uses a cdn and the download url changes with every page refresh. If I specify one cdn host I can get that to work, in this case https://dl3.cdn.filezilla-project.org/fzssh/fzssh-1.3.0.tar.xz. I could go with that. 2. I'll flag legal. Better safe than sorry.
This looks surprisingly okay (given the legacy of abuse of AGPLv3 particularly with respect to the "Appropriate Legal Notices" construct) but it should be submitted for review at fedora-license-data since it is not pure AGPLv3.
Right? Will do, thank you.
https://forge.fedoraproject.org/legal/fedora-license-data/issues/1591