SRPM:https://fedorapeople.org/~limb/review/python-pysmart/python-pysmart-1.4.2-1.fc45.src.rpm SPEC:https://fedorapeople.org/~limb/review/python-pysmart/python-pysmart.spec Description: pySMART is a simple Python wrapper for the smartctl component of smartmontools. It is officially compatible with Linux, Windows and FreeBSD, as long as smartctl is on the system path. Running with administrative rights is strongly recommended, as smartctl cannot accurately detect all device types or parse all SMART information without these permissions.
Copr build: https://copr.fedorainfracloud.org/coprs/build/10339851 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2458964-python-pysmart/fedora-rawhide-x86_64/10339851-python-pysmart/fedora-review/review.txt Found issues: - Documentation size is 1300465 bytes in 4 files. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1300465 bytes in 4 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation It's fine as is. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1", "GNU Lesser General Public License, Version 2.1 and/or GNU Library General Public License v2 or later", "GNU Lesser General Public License v2.1 or later and/or GNU Library General Public License v2 or later", "MIT License", "GNU General Public License, Version 2". 127 files have unknown license. Seems to be some license confusion here, if upstream wants to use LGPLv2.1, license text in files needs to be updated, not merely LICENSE file itself. Related is the use of outdated FSF address. Can you contact upstream about these issues? [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x ]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. See license [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. See above. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Spec file according to URL is the same as in SRPM. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-pysmart-1.4.2-1.fc45.noarch.rpm python-pysmart-1.4.2-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpw0dj794l')] checks: 32, packages: 2 python-pysmart.src: E: spelling-error ('smartctl', 'Summary(en_US) smartctl -> smartly, smartest, smarted') python-pysmart.src: E: spelling-error ('smartmontools', "Summary(en_US) smartmontools -> smartypants, smartypants's, statements") python-pysmart.src: E: spelling-error ('smartctl', '%description -l en_US smartctl -> smartly, smartest, smarted') python-pysmart.src: E: spelling-error ('smartmontools', "%description -l en_US smartmontools -> smartypants, smartypants's, statements") python3-pysmart.noarch: E: spelling-error ('smartctl', 'Summary(en_US) smartctl -> smartly, smartest, smarted') python3-pysmart.noarch: E: spelling-error ('smartmontools', "Summary(en_US) smartmontools -> smartypants, smartypants's, statements") python3-pysmart.noarch: E: spelling-error ('smartctl', '%description -l en_US smartctl -> smartly, smartest, smarted') python3-pysmart.noarch: E: spelling-error ('smartmontools', "%description -l en_US smartmontools -> smartypants, smartypants's, statements") python3-pysmart.noarch: W: package-with-huge-docs 69% python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/__init__.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/device.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/device_list.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/interface/__init__.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/interface/ata/__init__.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/interface/ata/attribute.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/interface/nvme/__init__.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/interface/scsi/__init__.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/interface/scsi/diagnostics.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/smartctl.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/testentry.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/utils.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pysmart-1.4.2.dist-info/licenses/LICENSE 2 packages and 0 specfiles checked; 21 errors, 1 warnings, 7 filtered, 21 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-pysmart.noarch: E: spelling-error ('smartctl', 'Summary(en_US) smartctl -> smartwatch') python3-pysmart.noarch: E: spelling-error ('smartmontools', 'Summary(en_US) smartmontools -> smartphones') python3-pysmart.noarch: E: spelling-error ('smartctl', '%description -l en_US smartctl -> smartwatch') python3-pysmart.noarch: E: spelling-error ('smartmontools', '%description -l en_US smartmontools -> smartphones') python3-pysmart.noarch: W: package-with-huge-docs 69% python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/__init__.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/device.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/device_list.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/interface/__init__.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/interface/ata/__init__.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/interface/ata/attribute.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/interface/nvme/__init__.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/interface/scsi/__init__.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/interface/scsi/diagnostics.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/smartctl.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/testentry.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pySMART/utils.py python3-pysmart.noarch: E: incorrect-fsf-address /usr/lib/python3.14/site-packages/pysmart-1.4.2.dist-info/licenses/LICENSE 1 packages and 0 specfiles checked; 17 errors, 1 warnings, 3 filtered, 17 badness; has taken 0.2 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/p/pysmart/pysmart-1.4.2.tar.gz : CHECKSUM(SHA256) this package : 98878d6e2fd89595866386a1660af8f2619f313a24c3df7b6d80a2cb9c8abc84 CHECKSUM(SHA256) upstream package : 98878d6e2fd89595866386a1660af8f2619f313a24c3df7b6d80a2cb9c8abc84 Requires -------- python3-pysmart (rpmlib, GLIBC filtered): python(abi) python3.14dist(chardet) python3.14dist(humanfriendly) Provides -------- python3-pysmart: python-pysmart python3-pysmart python3.14-pysmart python3.14dist(pysmart) python3dist(pysmart)