Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://download.copr.fedorainfracloud.org/results/sveturi/core-error/fedora-rawhide-x86_64/10340863-rust-core-error/rust-core-error.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sveturi/core-error/srpm-builds/10340863/rust-core-error-0.0.0-1.src.rpm Description: Add rust-core-error to Fedora Build Environment, needed for Rust Projects. This is my first package and need a sponsor. Fedora Account System Username: sveturi
Copr build: https://copr.fedorainfracloud.org/coprs/build/10340976 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2459073-rust-core-error/fedora-rawhide-x86_64/10340976-rust-core-error/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I would rather want to avoid packaging this crate. It looks like it's entirely obsolete since Rust 1.81, when the `Error` trait was moved from `std` to `core`. see https://doc.rust-lang.org/stable/core/error/trait.Error.html It should usually be straightforward to drop this dependency entirely.
I understand, the suggestion makes sense. To confirm, if I am dependent on this package indirectly through package "X", I would use the patching route to apply a patch to use the newer version that is already part of core, right? Thank you for your help with this, I am pretty new to Fedora, and this patch setup would make the publishing would help me to publish one less package.
Right. As far as I can tell, the crate in question here would be aya-obj? In general I think it should be safe to replace the Error trait from core-error with the one in core::error::Error. The only reason why it *might* not be acceptable for aya is if they want to retain support for Rust <1.81, but we could keep this as a Fedora-specific patch for the time being then.
I understand, thank you! I will keep this bug open to retain context in case this needs to be revisited but will continue on the route to using a patch for aya-obj.