Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://decathorpe.fedorapeople.org/rust-slog-extlog.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-slog-extlog-8.1.0-1.fc44.src.rpm Upstream URL: https://crates.io/crates/slog-extlog Description: Object-based logging and statistics tracking through logs. Fedora Account System Username: decathorpe
Copr build: https://copr.fedorainfracloud.org/coprs/build/10343896 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2459296-rust-slog-extlog/fedora-rawhide-x86_64/10343896-rust-slog-extlog/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
It looks like the derive crate is needed as well. Building this in mock with rust-slog-json from bug 2459299: No match for argument: crate(slog-extlog-derive/default) = 8.1.0
Ha, I thought there was a reason why I didn't submit these for review earlier :)
This should be resolved now, the dependency is available.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/10423232 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2459296-rust-slog-extlog/fedora-rawhide-x86_64/10423232-rust-slog-extlog/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hmm, this doesn’t seem to be working: running 5 tests test src/lib.rs - impl_value_wrapper (line 197) ... ignored test src/lib.rs - impl_value_wrapper (line 205) ... ignored test src/slog_test.rs - slog_test (line 13) ... FAILED test src/stats.rs - stats::StatsLoggerBuilder (line 481) ... ok test src/lib.rs - (line 78) ... ok failures: ---- src/slog_test.rs - slog_test (line 13) stdout ---- Test executable failed (exit status: 101). stderr: thread 'main' (775) panicked at src/slog_test.rs:20:37: index out of bounds: the len is 0 but the index is 0 I can reproduce this in a git checkout with "cargo test" if I add "--release", so we should probably just skip this test and note that it only works in debug mode.
Aha, that's annoying. > Note: At compile time slog by default removes trace and debug level statements in release builds, https://docs.rs/slog/latest/slog/#notable-details Let me see if I can work around that for tests. If not, I'll ignore the failures.
Spec URL: https://decathorpe.fedorapeople.org/rust-slog-extlog.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-slog-extlog-8.1.0-1.fc44.src.rpm Turns out, fixing this was relatively straightforward - add a dev-dependency on "slog/release_max_level_debug". All tests pass with this patch. rust2rpm.toml: ``` [package] cargo-toml-patch-comments = [ "enable debug logging during tests also in release mode", ] ``` slog-extlog-fix-metadata.diff: ``` --- slog-extlog-8.1.0/Cargo.toml 1970-01-01T00:00:01+00:00 +++ slog-extlog-8.1.0/Cargo.toml 2026-05-09T13:03:53.794395+00:00 @@ -65,6 +65,10 @@ [dev-dependencies.bencher] version = "0.1.5" +[dev-dependencies.slog] +version = "2.7" +features = ["release_max_level_debug"] + [dev-dependencies.slog-extlog-derive] version = "=8.1.0" ```
Package APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is generated by rust2rpm, simplifying the review. There is a metadata patch to “enable debug logging during tests also in release mode.” The approach is reasonable, and the patch is adequately documented. Ideally there might be an upstream status, and in theory this might be upstreamable (but perhaps there might be concern about it affecting benchmarks too). It hardly seems worthwhile, though. Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/slog- extlog-8.1.0/CHANGELOG.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files OK: not a serious problem; due to reasonable rust2rpm design decisions. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* Apache License". 15 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2459296-rust-slog-extlog/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- slog-extlog-devel , rust-slog-extlog+default-devel , rust-slog- extlog+derive-devel , rust-slog-extlog+interval_logging-devel , rust- slog-extlog+slog-extlog-derive-devel , rust-slog-extlog+tokio-devel [x]: Package functions as described. (tests pass) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. See free-form discussion at the beginning of the review. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=145448124 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-slog-extlog-devel-8.1.0-1.fc45.noarch.rpm rust-slog-extlog+default-devel-8.1.0-1.fc45.noarch.rpm rust-slog-extlog+derive-devel-8.1.0-1.fc45.noarch.rpm rust-slog-extlog+interval_logging-devel-8.1.0-1.fc45.noarch.rpm rust-slog-extlog+slog-extlog-derive-devel-8.1.0-1.fc45.noarch.rpm rust-slog-extlog+tokio-devel-8.1.0-1.fc45.noarch.rpm rust-slog-extlog-8.1.0-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp51gfpnd3')] checks: 32, packages: 7 7 packages and 0 specfiles checked; 0 errors, 0 warnings, 37 filtered, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 6 6 packages and 0 specfiles checked; 0 errors, 0 warnings, 33 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/slog-extlog/8.1.0/download#/slog-extlog-8.1.0.crate : CHECKSUM(SHA256) this package : c00caea52ddc6535e015114a7eb1d2483898f14d6f5110755c56c9f0d765fb71 CHECKSUM(SHA256) upstream package : c00caea52ddc6535e015114a7eb1d2483898f14d6f5110755c56c9f0d765fb71 Requires -------- rust-slog-extlog-devel (rpmlib, GLIBC filtered): (crate(erased-serde/default) >= 0.3.0 with crate(erased-serde/default) < 0.4.0~) (crate(iobuffer/default) >= 0.2.0 with crate(iobuffer/default) < 0.3.0~) (crate(serde/default) >= 1.0.0 with crate(serde/default) < 2.0.0~) (crate(serde/derive) >= 1.0.0 with crate(serde/derive) < 2.0.0~) (crate(serde_json/default) >= 1.0.0 with crate(serde_json/default) < 2.0.0~) (crate(slog-json/default) >= 2.6.0 with crate(slog-json/default) < 3.0.0~) (crate(slog-json/nested-values) >= 2.6.0 with crate(slog-json/nested-values) < 3.0.0~) (crate(slog/default) >= 2.7.0 with crate(slog/default) < 3.0.0~) (crate(slog/nested-values) >= 2.7.0 with crate(slog/nested-values) < 3.0.0~) cargo rust-slog-extlog+default-devel (rpmlib, GLIBC filtered): cargo crate(slog-extlog) rust-slog-extlog+derive-devel (rpmlib, GLIBC filtered): cargo crate(slog-extlog) crate(slog-extlog/slog-extlog-derive) rust-slog-extlog+interval_logging-devel (rpmlib, GLIBC filtered): cargo crate(slog-extlog) crate(slog-extlog/tokio) rust-slog-extlog+slog-extlog-derive-devel (rpmlib, GLIBC filtered): cargo crate(slog-extlog) crate(slog-extlog-derive/default) rust-slog-extlog+tokio-devel (rpmlib, GLIBC filtered): (crate(tokio/default) >= 1.0.0 with crate(tokio/default) < 2.0.0~) (crate(tokio/rt) >= 1.0.0 with crate(tokio/rt) < 2.0.0~) (crate(tokio/time) >= 1.0.0 with crate(tokio/time) < 2.0.0~) cargo crate(slog-extlog) Provides -------- rust-slog-extlog-devel: crate(slog-extlog) rust-slog-extlog-devel rust-slog-extlog+default-devel: crate(slog-extlog/default) rust-slog-extlog+default-devel rust-slog-extlog+derive-devel: crate(slog-extlog/derive) rust-slog-extlog+derive-devel rust-slog-extlog+interval_logging-devel: crate(slog-extlog/interval_logging) rust-slog-extlog+interval_logging-devel rust-slog-extlog+slog-extlog-derive-devel: crate(slog-extlog/slog-extlog-derive) rust-slog-extlog+slog-extlog-derive-devel rust-slog-extlog+tokio-devel: crate(slog-extlog/tokio) rust-slog-extlog+tokio-devel Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2459296 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Perl, Java, Python, Haskell, PHP, R, Ocaml, fonts, C/C++, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thank you for the review!
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-slog-extlog Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2026-88464c98c7 Looks like there's some bugs though, I needed to resubmit two builds because the tests crashed :/ The code for the test that crashed is quite straightforward so the issue might actually be in iobuffer ...