Bug 246020 - Viewlog CGI needs to be modified to work with Console
Viewlog CGI needs to be modified to work with Console
Status: CLOSED CURRENTRELEASE
Product: 389
Classification: Community
Component: Admin (Show other bugs)
1.1.0
All Linux
low Severity low
: ---
: ---
Assigned To: Nathan Kinder
Viktor Ashirov
:
Depends On:
Blocks: 240316 FDS1.1.0
  Show dependency treegraph
 
Reported: 2007-06-27 17:45 EDT by Nathan Kinder
Modified: 2015-12-07 12:04 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2015-12-07 12:04:27 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
CVS Diffs (10.76 KB, patch)
2007-06-27 17:45 EDT, Nathan Kinder
no flags Details | Diff

  None (edit)
Description Nathan Kinder 2007-06-27 17:45:59 EDT
The current viewlog CGI needs to be modified to be able to work properly with
the Console.

The CGI currently only supports the GET request method.  This works for Admin
Express, but Console expects it to support the POST request method.

The output of the CGI currently includes a log selection combo box as well as
other HTML elements that make for a nice useful log viewer page in Admin
Express.  The Console needs to be able to get get the raw log content that it
requests.

The attached diffs address the above issues.  With these changes, the CGI will
work with both the GET and POST request methods.  I've added a new CGI parameter
called "nohtml".  This optional parameter is a flag that allows the caller to
ask for only the raw content to be sent back.  This satisfies the needs of the
Console while keeping the behavior the same for Admin Express.
Comment 1 Nathan Kinder 2007-06-27 17:45:59 EDT
Created attachment 158068 [details]
CVS Diffs
Comment 2 Noriko Hosoi 2007-06-27 18:18:53 EDT
Your diffs look good.
Comment 3 Nathan Kinder 2007-06-27 18:25:44 EDT
Checked into HEAD.  Thanks for the review Noriko!

Checking in admserv/cgi-src40/viewlog.c;
/cvs/dirsec/adminserver/admserv/cgi-src40/viewlog.c,v  <--  viewlog.c
new revision: 1.9; previous revision: 1.8
done
Checking in admserv/cgi-src40/viewlog.properties;
/cvs/dirsec/adminserver/admserv/cgi-src40/viewlog.properties,v  <-- 
viewlog.properties
new revision: 1.5; previous revision: 1.4
done
Checking in admserv/schema/ldif/11dstasks.ldif.tmpl;
/cvs/dirsec/adminserver/admserv/schema/ldif/11dstasks.ldif.tmpl,v  <-- 
11dstasks.ldif.tmpl
new revision: 1.3; previous revision: 1.2
done

Note You need to log in before you can comment on or make changes to this bug.