Bug 246020 - Viewlog CGI needs to be modified to work with Console
Summary: Viewlog CGI needs to be modified to work with Console
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: 389
Classification: Retired
Component: Admin
Version: 1.1.0
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Nathan Kinder
QA Contact: Viktor Ashirov
URL:
Whiteboard:
Depends On:
Blocks: 240316 FDS1.1.0
TreeView+ depends on / blocked
 
Reported: 2007-06-27 21:45 UTC by Nathan Kinder
Modified: 2015-12-07 17:04 UTC (History)
0 users

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-12-07 17:04:27 UTC
Embargoed:


Attachments (Terms of Use)
CVS Diffs (10.76 KB, patch)
2007-06-27 21:45 UTC, Nathan Kinder
no flags Details | Diff

Description Nathan Kinder 2007-06-27 21:45:59 UTC
The current viewlog CGI needs to be modified to be able to work properly with
the Console.

The CGI currently only supports the GET request method.  This works for Admin
Express, but Console expects it to support the POST request method.

The output of the CGI currently includes a log selection combo box as well as
other HTML elements that make for a nice useful log viewer page in Admin
Express.  The Console needs to be able to get get the raw log content that it
requests.

The attached diffs address the above issues.  With these changes, the CGI will
work with both the GET and POST request methods.  I've added a new CGI parameter
called "nohtml".  This optional parameter is a flag that allows the caller to
ask for only the raw content to be sent back.  This satisfies the needs of the
Console while keeping the behavior the same for Admin Express.

Comment 1 Nathan Kinder 2007-06-27 21:45:59 UTC
Created attachment 158068 [details]
CVS Diffs

Comment 2 Noriko Hosoi 2007-06-27 22:18:53 UTC
Your diffs look good.

Comment 3 Nathan Kinder 2007-06-27 22:25:44 UTC
Checked into HEAD.  Thanks for the review Noriko!

Checking in admserv/cgi-src40/viewlog.c;
/cvs/dirsec/adminserver/admserv/cgi-src40/viewlog.c,v  <--  viewlog.c
new revision: 1.9; previous revision: 1.8
done
Checking in admserv/cgi-src40/viewlog.properties;
/cvs/dirsec/adminserver/admserv/cgi-src40/viewlog.properties,v  <-- 
viewlog.properties
new revision: 1.5; previous revision: 1.4
done
Checking in admserv/schema/ldif/11dstasks.ldif.tmpl;
/cvs/dirsec/adminserver/admserv/schema/ldif/11dstasks.ldif.tmpl,v  <-- 
11dstasks.ldif.tmpl
new revision: 1.3; previous revision: 1.2
done


Note You need to log in before you can comment on or make changes to this bug.