Spec URL: https://pnemade.fedorapeople.org/rust-font-test-data.spec SRPM URL: https://pnemade.fedorapeople.org/rust-font-test-data-0.6.2-1.fc44.src.rpm Upstream URL: https://crates.io/crates/font-test-data Description: Test data for the fontations crates. Fedora Account System Username: pnemade
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=144732215
Copr build: https://copr.fedorainfracloud.org/coprs/build/10359122 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2461078-rust-font-test-data/fedora-rawhide-x86_64/10359122-rust-font-test-data/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The file test_data/rebuild.sh has a /usr/bin/env shebang and generates an unwanted dependency on bash. Try something like this in rust2rpm.toml: [scripts.prep] pre = [ """\ # Do not generate a dependency on the bash shell chmod a-x test_data/rebuild.sh # Remove the shebang because we unset the execute bit and because it uses env, # https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shebang_lines. sed -r -i '1{/^#!/d}' test_data/rebuild.sh\ """, ] Upstream has assigned an “overall” license of (MIT OR Apache-2.0), but this does not account for all of the licenses of test data fonts, and we must do so: https://docs.fedoraproject.org/en-US/legal/license-field/#_no_effective_license_analysis, https://docs.fedoraproject.org/en-US/legal/identify/. Fortunately, test_data/README.md does attempt to account for all of these licenses. Since it looks thorough, I haven’t attempted to second-guess this accounting, but I spot-checked and didn’t find any obvious gaps or errors. I think we can safely take test_data/README.md at face value. Try something like this, in rust2rpm.toml: [package] cargo-toml-patch-comments = [ """\ Add OFL-1.1, Apache-2.0 and Unicode-3.0 terms to the SPDX license expression to \ account for fonts in test_data/; see test_data/README.md for an accounting of \ which licenses apply to which fonts.\ """, ] Then, using “rust2rpm -p”, change the line license = "MIT OR Apache-2.0" to license = "(MIT OR Apache-2.0) AND Apache-2.0 AND OFL-1.1 AND Unicode-3.0" Otherwise, this looks sensible. While https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/ generally prohibits packaging fonts bundled in other packages, I think this package is fine because the fonts are to be used solely as binary test data files.