Bug 246186 - Review Request: dtc - Device Tree Compiler
Review Request: dtc - Device Tree Compiler
Status: CLOSED DUPLICATE of bug 234484
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jima
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-06-28 22:31 EDT by Josh Boyer
Modified: 2007-11-30 17:12 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-07-09 21:59:40 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
jima: fedora‑review+
kevin: fedora‑cvs-


Attachments (Terms of Use)

  None (edit)
Description Josh Boyer 2007-06-28 22:31:19 EDT
Spec URL: http://jdub.homelinux.org/pub/dtc.spec
SRPM URL: http://jdub.homelinux.org/pub/dtc-0-0.1.20070628gitd9d679fb9.fc7.src.rpm
Description:

The Device Tree Compiler generates flattened Open Firmware style device trees
for use with PowerPC machines that lack an Open Firmware implementation
Comment 1 Jima 2007-06-29 10:52:35 EDT
Picking up for review...
Comment 2 Josh Boyer 2007-06-29 11:47:42 EDT
the spec file has the wrong instructions for recreating the source.  I'll fix
that in the next revision.  For now, use:

git clone git://www.jdl.com/software/dtc.git; cd dtc; git checkout d9d679fb9; cd
..; mv dtc dtc-20070628; tar -czvf dtc-20070628.tar.gz dtc-20070628;
Comment 3 Josh Boyer 2007-06-29 12:20:56 EDT
Ok, fixed up the spec file and uploaded a new SRPM:

Spec URL: http://jdub.homelinux.org/pub/dtc.spec
SRPM URL: http://jdub.homelinux.org/pub/dtc-0-0.2.20070628gitd9d679fb9.fc7.src.rpm
Comment 4 Jima 2007-06-29 12:49:03 EDT
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
tar -zxf dtc-20070628.tar.gz
git clone git://www.jdl.com/software/dtc.git
cd dtc
git checkout d9d679fb9 
rm -rf .git
cd ..
diff -urN dtc-20070628/ dtc/
(nada!)

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
Documentation is a little thin, but that's upstream's problem to resolve.
OK - Package compiles and builds on at least one arch. (i386, ppc)
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
no - No rpmlint output.
W: dtc no-version-in-last-changelog

OK - final provides and requires are sane:
Requires:
libc.so.6
libc.so.6(GLIBC_2.0)
libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.3)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1   
rtld(GNU_HASH)

Provides:
dtc = 0-0.1.20070628gitd9d679fb9.fc6

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
My x86_64 builder is out of commission ATM, but I'll assume it works there.
OK - Should function as described.
As far as I can tell. :-)
OK - Should have dist tag
OK - Should package latest version
Well, sort of.  Close enough, I think.

In closing, I have a bit of issue with the lack of an EVR on your changelog
entries, but as long as this gets resolved at some point, I think we can let it
slide.  (Cue screams of bloody murder... ;-)

I think we can call dtc APPROVED.
Comment 5 Josh Boyer 2007-06-29 14:23:47 EDT
New Package CVS Request
=======================
Package Name: dtc
Short Description: Device Tree Compiler
Owners: jwboyer@jdub.homelinux.org
Branches: F-7
InitialCC: 
Comment 6 Kevin Fenzi 2007-06-29 17:01:00 EDT
This package already seems to be setup in cvs/owners.list.
However, it doesn't look like it was every imported or built...

See: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234484

Perhaps you could talk to the maintainer about taking it over or co-maintaining it? 
Comment 7 Josh Boyer 2007-07-09 21:59:40 EDT

*** This bug has been marked as a duplicate of 234484 ***

Note You need to log in before you can comment on or make changes to this bug.