Spec URL: http://www.nosuchhost.net/~cheese/fedora/packages/libopensync-plugin-gnokii.spec SRPM URL: http://www.nosuchhost.net/~cheese/fedora/packages/libopensync-plugin-gnokii-0.22-1.fc7.src.rpm Description: plugin for using gnokii with opensync my second package; i need a sponsor
i forgot to set the correct summary
I see that you are looking for someone to sponsor you, and as it happens I'm allowed to sponsor people. Here is what I would like to do: I see that you've submitted 3 packages for review, I will review all 3 of them and then after one or two iterations the can hopefully be approved, assuming that process go well I'll sponsor you when all 3 are approved, if you agree with this "procedure", please let me know and I'll start reviewing all 3.
Full review done. Must Fix: -License field is wrong. Its GPL version 2 or any later verison, which the new license guideline requires you to state as GPLv2+ -Description must end with a "." -drop the ldconfig scripts, this is a plugin not a lib, so they are not needed. -Must have "Requires: libopensync" for %{_libdir}/opensync/plugins and %{_libdir}/opensync/formats dir ownership -doesn't compile on F-8: gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/include/opensync-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libxml2 -Wall -Werror -O2 -I/usr/include/opensync-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libxml2 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -MT gnokii_contact_format.lo -MD -MP -MF .deps/gnokii_contact_format.Tpo -c gnokii_contact_format.c -fPIC -DPIC -o .libs/gnokii_contact_format.o cc1: warnings being treated as errors gnokii_contact_format.c: In function 'conv_gnokii_contact_to_xml': gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_Location' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_Image' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_UserID' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_PTTAddress' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_FirstName' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_LastName' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_PostalAddress' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_ExtendedAddress' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_Street' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_City' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_StateProvince' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_ZipCode' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_Country' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_FormalName' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_JobTitle' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_Company' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_Nickname' not handled in switch gnokii_contact_format.c:109: warning: enumeration value 'GN_PHONEBOOK_ENTRY_Birthday' not handled in switch make[2]: *** [gnokii_contact_format.lo] Error 1 make[2]: Leaving directory `/usr/src/redhat/BUILD/libopensync-plugin-gnokii-0.22
fresh rebuild http://www.nosuchhost.net/~cheese/fedora/packages/8/libopensync-plugin-gnokii-0.22-3.fc8.i386.rpm http://www.nosuchhost.net/~cheese/fedora/packages/8/libopensync-plugin-gnokii-0.22-3.fc8.src.rpm http://www.nosuchhost.net/~cheese/fedora/packages/8/libopensync-plugin-gnokii.spec
Looks good, approved. I'm ready to sponsor you now, please create an account in the Fedora account system (if you haven't done so already), sign the CLA and apply for CVS extras membership. Once you've done that please add a comment to any of your 3 reviews saying that you've done so, and include your Fedora account login name, then I'll sponsor you and after that is done you can ask for creation of the necessary modules in CVS and start importing and building your packages.
New Package CVS Request ======================= Package Name: libopensync-plugin-gnokii Short Description: gnokii plugin for libopensync Owners: cheese Branches: devel F-7 F-8 InitialCC: cheese Cvsextras Commits: yes
cvs done.