Spec URL: http://rubenkerkhof.com/packages/perl-Gearman-Client-Async.spec SRPM URL: http://rubenkerkhof.com/packages/perl-Gearman-Client-Async-0.94-1.fc7.src.rpm Description: Asynchronous Client for the Gearman distributed job system
This doesn't build; you'll need at least a build dependency on perl(ExtUtils::MakeMaker). There's also a test suite, but you'll need many more modules to run it (at least perl(Test::More), perl(Danga::Socket), perl(Gearman::Objects) and perl(Gearman::Server). (The last one isn't yet available.) Even then I'm not sure it's possible to run the test in mock or within the buildsys.
I added a BuildRequires for perl-Gearman-Server (#245697, will build that one toninght for rawhide) and enabled the tests, and all test pass in mock for devel. New version: http://rubenkerkhof.com/packages/perl-Gearman-Client-Async.spec http://rubenkerkhof.com/packages/perl-Gearman-Client-Async-0.94-2.fc7.src.rpm
Hmm, this fails to build for me, due to one of the tests failing: t/err8............Can't call method "watch_read" on an undefined value at t/err8.t line 57. # Looks like your test died before it could output anything. dubious Test returned status 255 (wstat 65280, 0xff00) DIED. FAILED tests 1-3 Failed 3/3 tests, 0.00% okay
Hi Jason, I think Danga::Socket was missing in the BR. Does this version fix it for you? http://rubenkerkhof.com/packages/perl-Gearman-Client-Async.spec http://rubenkerkhof.com/packages/perl-Gearman-Client-Async-0.94-3.fc7.src.rpm
Unfortunately not; it still fails in the same manner. I'm thinking that test is simply broken; my $socket = Danga::Socket->DescriptorMap->{3}; returns undef, but it's making an assumption about which file descriptor is being wrapped. I note that this is the only test which calls Danga::Docket::DescriptorMap. I don't really know why it would consistently fail for me and work for you. I'm building on x86_64; the host is running FC5 and mock is pointed at the development repository.
Strange, my mock is pointed to devel as well, host is running F-7 on i686. I've asked for help on the upstream mailinglist yesterday, I hope someone can reproduce/fix this. Do you consider this as a blocker? The alternative is for me to disable that test, it doesn't seem to really test the functionality of Gearman and Danga::Socket.
Well, if it doesn't build in the buildsys then you'll have bigger problems. But if you're confident that it's a bug in the test then I'd say just delete t/err8.t in the %check section and add a comment explaining why you're doing it and I'd say it's fine.
Ok, I disabled the test in err8.t New version: http://rubenkerkhof.com/packages/perl-Gearman-Client-Async.spec http://rubenkerkhof.com/packages/perl-Gearman-Client-Async-0.94-3.fc7.src.rpm
OK, looks good to me. * source files match upstream: 8f8fa7722c82a27130224828629b8c680eb99e15e562d17e02d57c3f097826ea Gearman-Client-Async-0.94.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(Gearman::Client::Async) = 0.94 perl(Gearman::Client::Async::Connection) perl(Gearman::ResponseParser::Async) perl-Gearman-Client-Async = 0.94-3.fc8 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Danga::Socket) >= 1.52 perl(Gearman::Client::Async::Connection) perl(Gearman::JobStatus) perl(Gearman::Objects) perl(Gearman::ResponseParser) perl(Gearman::Task) perl(Gearman::Util) perl(IO::Handle) perl(List::Util) perl(Scalar::Util) perl(Socket) perl(base) perl(constant) perl(fields) perl(strict) perl(vars) perl(warnings) * %check is present and all tests pass: All tests successful. Files=11, Tests=32, 26 wallclock secs ( 1.48 cusr + 0.55 csys = 2.03 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED
New Package CVS Request ======================= Package Name: perl-Gearman-Client-Async Short Description: Asynchronous Client for the Gearman distributed job system Owners: ruben Branches: FC-6 F-7 EL-4 EL-5
cvs done.
Package Change Request ====================== Package Name: perl-Gearman-Client-Async Branches: f15 f14 New InitialCC: perl-sig Please add `perl-sig' to CC list for all Fedora branches as this is Perl package.
This is now done via pkgdb.