Bug 2463755 - Review Request: rust-abol-util - Utilities and runtime implementations for the Abol RADIUS framework
Summary: Review Request: rust-abol-util - Utilities and runtime implementations for th...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2463742
Blocks: 2463809
TreeView+ depends on / blocked
 
Reported: 2026-04-29 09:42 UTC by Andreas Schneider
Modified: 2026-07-03 00:55 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-06-24 09:40:14 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Andreas Schneider 2026-04-29 09:42:57 UTC
Spec URL: https://asn.fedorapeople.org/rust-abol-util.spec
SRPM URL: https://asn.fedorapeople.org/rust-abol-util-0.1.0-1.fc45.src.rpm
Description: Utilities and runtime implementations for the Abol RADIUS framework.
Fedora Account System Username: asn

Comment 1 Andreas Schneider 2026-04-29 09:43:11 UTC
cat rust2rpm.toml
[package]
extra-sources = [
    { number = 2, file = "LICENSE", comments = [
        "See https://github.com/Abel981/abol/blob/main/LICENSE",
        "Merge Request: https://github.com/Abel981/abol/pull/3",
    ] },
    { number = 3, file = "LICENSE-APACHE", comments = [
        "See https://github.com/Abel981/abol/blob/main/LICENSE-APACHE",
        "Merge Request: https://github.com/Abel981/abol/pull/3",
    ] },
    { number = 4, file = "README.md", comments = [
        "See https://github.com/Abel981/abol/blob/main/README.md",
        "Merge Request: https://github.com/Abel981/abol/pull/3",
    ] },
]
license-files = ["LICENSE", "LICENSE-APACHE"]
doc-files = ["README.md"]

[scripts]
prep.pre = [
    "cp %{SOURCE2} .",
    "cp %{SOURCE3} .",
    "cp %{SOURCE4} ."
]
install.post = [
    "install -m 0644 LICENSE %{buildroot}%{crate_instdir}/LICENSE",
    "install -m 0644 LICENSE %{buildroot}%{crate_instdir}/LICENSE-APACHE"
]

Comment 2 Fedora Review Service 2026-04-29 09:44:58 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10405585
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2463755-rust-abol-util/fedora-rawhide-x86_64/10405585-rust-abol-util/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2026-06-23 09:18:48 UTC
Package looks mostly OK. Two minor things:

- You shouldn't need to "install" the license files in %install manually.
  The "%cargo_install" macro should already handle this.

- It would be nice if the Sources for LICENSE, LICENSE-APACHE, and README.md were actual URLs - that would make it obvious where they come from. They're correctly documented in the .spec file, but that's not machine-readable (and "spectool -g" can't download them if they're not URLs).

In this case, the URLs would be:

https://github.com/Abel981/abol/raw/83bbd1c/LICENSE
https://github.com/Abel981/abol/raw/83bbd1c/LICENSE-APACHE
https://github.com/Abel981/abol/raw/83bbd1c/README.md

(Where 83bbd1c is the commit that was git HEAD when abol-util 0.1.0 was published.)

Comment 6 Fabio Valentini 2026-06-23 11:28:57 UTC
Not sure why you picked different URLs than the ones I posted above?
They correspond to the head of the "main" branch, not the sources at the point at which abol-util 0.1.0 was published.

Comment 8 Fabio Valentini 2026-06-23 21:27:28 UTC
Looks good to me now. Thanks!

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
🫤 license files are included with %license in %files:
   temporarily manually included from upstream,
   this workaround can be dropped as soon as the files are included in published crates.
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 9 Fedora Admin user for bugzilla script actions 2026-06-24 09:25:00 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-abol-util
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 10 Fedora Update System 2026-06-24 09:35:00 UTC
FEDORA-2026-4206129ef6 (rust-abol-util-0.1.0-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-4206129ef6

Comment 11 Fedora Update System 2026-06-24 09:40:14 UTC
FEDORA-2026-4206129ef6 (rust-abol-util-0.1.0-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2026-06-24 14:06:04 UTC
FEDORA-2026-8f68e6bff7 (rust-abol-util-0.1.0-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-8f68e6bff7

Comment 13 Fedora Update System 2026-06-25 16:31:11 UTC
FEDORA-2026-8f68e6bff7 has been pushed to the Fedora 44 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-8f68e6bff7 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-8f68e6bff7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2026-07-03 00:55:41 UTC
FEDORA-2026-8f68e6bff7 (rust-abol-util-0.1.0-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.