*** Bug 2143315 has been marked as a duplicate of this bug. ***

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10406146
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2463801-rubygem-gtk4/fedora-rawhide-x86_64/10406146-rubygem-gtk4/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-gtk4.spec
https://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-gtk4-4.3.9-1.fc46.src.rpm

Updated to 4.3.9.
Note that currently (as of 2026-09-06) other dependency packages related to ruby-gnome 4.3.9 are currently available on F46 buildroot.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Pure Ruby package must be built as noarch
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.


===== MUST items =====

C/C++:
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. Licenses found: "Unknown or generated", "GNU Lesser
     General Public License v2.1 or later". 13 files have unknown license.
     Detailed output of licensecheck in
     /home/luk/fedora/FedoraReview/2463801-rubygem-gtk4/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
     independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Package does not contain Requires: ruby(abi).
[x]: Gem package does not contain Requires: ruby(release).

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Ruby:
[x]: Specfile should use macros from rubygem-devel package.
     Note: The specfile doesn't use these macros: %exclude %{gem_cache}
[x]: Gem package should exclude cached Gem.
[x]: Gem should use %gem_install macro.
[x]: gems should not require rubygems package
[x]: Test suite should not be run by rake.
[x]: Test suite of the library should be run.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rubygem-gtk4-4.3.9-1.fc46.x86_64.rpm
          rubygem-gtk4-doc-4.3.9-1.fc46.noarch.rpm
          rubygem-gtk4-4.3.9-1.fc46.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.9.0
configuration:
    /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp08rzx4kv')]
checks: 32, packages: 3

rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/action-namespace.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application1/exampleapp.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application2/exampleapp.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application3/exampleapp.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application4/exampleapp.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application5/exampleapp.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application6/exampleapp.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application7/exampleapp.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application8/exampleapp.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application9/exampleapp.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/builder.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/drawing.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/grid_packing.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/hello_world.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/menubar.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/window_default.rb 644 /usr/bin/env ruby
rubygem-gtk4.spec: W: invalid-url Source1: gtk4-4.3.9-test-missing-files.tar.gz
rubygem-gtk4.x86_64: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/COPYING.LIB
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application1/exampleapp.rb
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application2/exampleapp.rb
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application3/exampleapp.rb
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application4/exampleapp.rb
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application5/exampleapp.rb
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application6/exampleapp.rb
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application7/exampleapp.rb
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application8/exampleapp.rb
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application9/exampleapp.rb
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/window_default.rb
 3 packages and 0 specfiles checked; 27 errors, 1 warnings, 23 filtered, 27 badness; has taken 0.4 s 




Rpmlint (debuginfo)
-------------------
Checking: rubygem-gtk4-debuginfo-4.3.9-1.fc46.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.9.0
configuration:
    /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp4ddcejul')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 4 filtered, 0 badness; has taken 0.1 s 





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.10.0
configuration:
    /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 33, packages: 3

rubygem-gtk4.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/ruby/gtk4-4.3.9/gtk4.so rbgobj_register_mark_func	(/usr/lib64/gems/ruby/gtk4-4.3.9/gtk4.so)
rubygem-gtk4.x86_64: W: undefined-non-weak-symbol /usr/lib64/gems/ruby/gtk4-4.3.9/gtk4.so rbgobj_gc_mark_instance	(/usr/lib64/gems/ruby/gtk4-4.3.9/gtk4.so)
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/action-namespace.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application1/exampleapp.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application2/exampleapp.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application3/exampleapp.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application4/exampleapp.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application5/exampleapp.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application6/exampleapp.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application7/exampleapp.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application8/exampleapp.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application9/exampleapp.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/builder.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/drawing.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/grid_packing.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/hello_world.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/menubar.rb 644 /usr/bin/env ruby
rubygem-gtk4-doc.noarch: E: non-executable-script /usr/share/gems/gems/gtk4-4.3.9/sample/examples/window_default.rb 644 /usr/bin/env ruby
rubygem-gtk4.x86_64: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/COPYING.LIB
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application1/exampleapp.rb
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application2/exampleapp.rb
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application3/exampleapp.rb
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application4/exampleapp.rb
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application5/exampleapp.rb
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application6/exampleapp.rb
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application7/exampleapp.rb
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application8/exampleapp.rb
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/application9/exampleapp.rb
rubygem-gtk4-doc.noarch: E: incorrect-fsf-address /usr/share/gems/gems/gtk4-4.3.9/sample/examples/window_default.rb
 3 packages and 0 specfiles checked; 27 errors, 2 warnings, 25 filtered, 27 badness; has taken 0.5 s 



Unversioned so-files
--------------------
rubygem-gtk4: /usr/lib64/gems/ruby/gtk4-4.3.9/gtk4.so

Source checksums
----------------
https://rubygems.org/gems/gtk4-4.3.9.gem :
  CHECKSUM(SHA256) this package     : 3e749542e347ef703e6691552047254612ef54d430b308264e96f330fd3e453b
  CHECKSUM(SHA256) upstream package : 3e749542e347ef703e6691552047254612ef54d430b308264e96f330fd3e453b


Requires
--------
rubygem-gtk4 (rpmlib, GLIBC filtered):
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-4.so.1()(64bit)
    libruby.so.4.0()(64bit)
    rtld(GNU_HASH)
    ruby(rubygems)
    rubygem(atk)
    rubygem(gdk4)

rubygem-gtk4-doc (rpmlib, GLIBC filtered):
    /usr/bin/ruby
    rubygem-gtk4



Provides
--------
rubygem-gtk4:
    rubygem(gtk4)
    rubygem-gtk4
    rubygem-gtk4(x86-64)

rubygem-gtk4-doc:
    rubygem-gtk4-doc

RE: issues

>Pure Ruby package must be built as noarch

not sure why it thinks it's a pure ruby package, looks like a false positive to me.

>Package installs a %{name}.desktop using desktop-file-install or desktop-
>file-validate if there is such a file.

false positive since doc package ships with an example .desktop file.

I didn't check if it builds on non-x86_64, hopefully it does.

>I didn't check if it builds on non-x86_64, hopefully it does.

verified it just now, aarch64/i386/ppc64le/s390x build fine.

===== SHOULD items =====

Generic:
[x]: Package should compile and build into binary rpms on all supported
     architectures.

Okay, thank you for review!

The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-gtk4
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

FEDORA-2026-31f2bbe960 (rubygem-gtk4-4.3.9-1.fc46) has been submitted as an update to Fedora 46.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-31f2bbe960

FEDORA-2026-31f2bbe960 (rubygem-gtk4-4.3.9-1.fc46) has been pushed to the Fedora 46 stable repository.
If problem still persists, please make note of it in this bug report.