Bug 2463833 - Review Request: python-bayesml - Your First Library for Bayesian Machine Learning
Summary: Review Request: python-bayesml - Your First Library for Bayesian Machine Lear...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Daniel Milnes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2026-04-29 15:16 UTC by Benson Muite
Modified: 2026-07-11 15:42 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
daniel: fedora-review+


Attachments (Terms of Use)

Description Benson Muite 2026-04-29 15:16:35 UTC
spec: https://fed500.fedorapeople.org/python-bayesml.spec
srpm: https://fed500.fedorapeople.org/python-bayesml-0.4.1%5E20260429gitae8bcdd-1.fc43.src.rpm

description:
BayesML contributes to wide society thourgh promoting education, research, and
application of machine learning based on Bayesian statistics and Bayesian
decision theory.

Characteristics
Easy-to-use:
You can use pre-defined Bayesian statistical models by simply importing it. You
don't need to define models yourself like PyMC or Stan.

Bayesian Decision Theoretic API:
BayesML's API corresponds to the structure of decision-making based on Bayesian
decision theory. Bayesian decision theory is a unified framework for handling
various decision-making processes, such as parameter estimation and prediction
of new data. Therefore, BayesML enables intuitive operations for a wider range
of decision-making compared to the fit-predict type API adopted in libraries
like scikit-learn. Moreover, many of our models also implement fit-predict
functions.

Model Visualization Functions:
All packages have methods to visualize the probabilistic data generative model,
generated data from that model, and the posterior distribution learned from the
data in 2~3 dimensional space. Thus, you can effectively understand the
characteristics of probabilistic data generative models and algorithms through
the generation of synthetic data and learning from them.

Fast Algorithms Using Conjugate Prior Distributions:
Many of our learning algorithms adopt exact calculation methods or variational
Bayesian methods that effectively use the conjugacy between probabilistic data
generative models and prior distributions. Therefore, they are much faster than
general-purpose MCMC methods and are also suitable for online learning.
Although some algorithms adopt MCMC methods, but they use MCMC methods
specialized for each model, taking advantage of conjugacy.

fas: fed500

Reproducible: Always

Comment 1 Fedora Review Service 2026-04-29 15:21:52 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10406650
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2463833-python-bayesml/fedora-rawhide-x86_64/10406650-python-bayesml/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Daniel Milnes 2026-07-11 15:42:16 UTC
Approved.

I don't really love the approach to building the docs there, but I can't come up with anything better.

You should add %license LICENSE.txt, but happy for you to do that during import.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 3-Clause License", "MIT License",
     "SIL Open Font License 1.1". 338 files have unknown license. Detailed
     output of licensecheck in /var/lib/copr-rpmbuild/results/python-
     bayesml/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.15,
     /usr/lib/python3.15/site-packages
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 12739 bytes in 1 files.

I don't think there's enough here to need a separate -doc package.

[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[-]: Uses parallel make %{?_smp_mflags} macro.
[!]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.


Note You need to log in before you can comment on or make changes to this bug.