Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://gist.github.com/xanderlent/1407bdcf1789c38c42795fcdfe0b9c88/raw/d8a72026562373402fd1a6f3dcda06415edec36c/rust-daachorse.spec SRPM URL: https://gist.github.com/xanderlent/1407bdcf1789c38c42795fcdfe0b9c88/raw/d8a72026562373402fd1a6f3dcda06415edec36c/rust-daachorse-1.0.1-1.fc44.src.rpm Description: Daachorse: Double-Array Aho-Corasick Fedora Account System Username: xanderlent This is a review of the rust-daachorse package, which is a new dependency of rust-tokenizers 0.23.1; it is intentionally at an old version of 1.0.1 since tokenizers is not ready to upgrade to newer versions (3.0.0 was published last week).
Copr build: https://copr.fedorainfracloud.org/coprs/build/10431160 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2467560-rust-daachorse/fedora-rawhide-x86_64/10431160-rust-daachorse/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
No issues found; the package is APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is generated with rust2rpm, simplifying the review. The only manual change is the addition of %doc %{crate_instdir}/figures/ which was an excellent idea. (I confirm that the contents of figures/ are not used as test data or anything else that would preclude treating them as documentation.) If you haven’t already done so, you can add this to rust2rpm.toml: [package] doc-files.include = ["figures/"] I see that you’ve packaged version 1.0.1, rather than the latest 3.0.0. This is justifiable since safetensors wants 1.x, and 2.x/3.x are only a few weeks old. If other packages end up depending on rust-daachorse before safetensors upgrades their dependency, you may eventually have to help them upgrade, or provide a compat package for safetensors. For now, packaging 1.0.1 seems fine. Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/daachorse-1.0.1/CONTRIBUTING.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files OK: not a serious problem; due to reasonable rust2rpm design decisions. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* MIT License", "*No copyright* Apache License 2.0". 29 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2467560-rust-daachorse/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- daachorse-devel , rust-daachorse+default-devel , rust-daachorse+alloc- devel [x]: Package functions as described. (tests pass) [!]: Latest version is packaged. An older version is packaged to support safetensors; this appears to be justifiable. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. Since s390x builders are down, I did a scratch build on the other architectures, https://koji.fedoraproject.org/koji/taskinfo?taskID=145210649, and verified s390x with a local mock build using qemu-user-static emulation. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-daachorse-devel-1.0.1-1.fc45.noarch.rpm rust-daachorse+default-devel-1.0.1-1.fc45.noarch.rpm rust-daachorse+alloc-devel-1.0.1-1.fc45.noarch.rpm rust-daachorse-1.0.1-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpzgnfljib')] checks: 32, packages: 4 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 19 filtered, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 15 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/daachorse/1.0.1/download#/daachorse-1.0.1.crate : CHECKSUM(SHA256) this package : 6f55d7153ba3b507595872a3874803f07a8a81d1e888abed8e5db7da0597d6e2 CHECKSUM(SHA256) upstream package : 6f55d7153ba3b507595872a3874803f07a8a81d1e888abed8e5db7da0597d6e2 Requires -------- rust-daachorse-devel (rpmlib, GLIBC filtered): cargo rust rust-daachorse+default-devel (rpmlib, GLIBC filtered): cargo crate(daachorse) crate(daachorse/alloc) rust-daachorse+alloc-devel (rpmlib, GLIBC filtered): cargo crate(daachorse) Provides -------- rust-daachorse-devel: crate(daachorse) rust-daachorse-devel rust-daachorse+default-devel: crate(daachorse/default) rust-daachorse+default-devel rust-daachorse+alloc-devel: crate(daachorse/alloc) rust-daachorse+alloc-devel Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2467560 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: fonts, Ocaml, Java, Perl, SugarActivity, Python, R, PHP, C/C++, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
As a follow-up, I confirmed that the daachorse dependency can be updated in tokenizers without source-code changes, and I suggested this upstream in https://github.com/huggingface/tokenizers/pull/2050. You might consider patching the dependency in python-tokenizers and updating rust-daachorse to 3.0.0. Or you could just wait for the next tokenizers release, which will hopefully contain my PR.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-daachorse Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
Thanks for the patch! I'll take a look at integrating it!
FEDORA-2026-cb88ca11b0 (rust-daachorse-1.0.1-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-cb88ca11b0
FEDORA-2026-cb88ca11b0 (rust-daachorse-1.0.1-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.