Spec URL: http://developer.postgresql.org/~devrim/rpms/other/plr/postgresql-plr.spec SRPM URL: http://developer.postgresql.org/~devrim/rpms/other/plr/postgresql-plr-8.2.0.5-1.fc7.src.rpm Description: Procedural Language Handler for the "R software environment for statistical computing and graphics".
The following comments are based on the Package Review Guidelines and the Packaging Guidelines. But I'm not a sponsor of the Fedora project, so these are not official review comments. - You should post the result of rpmlint command. Just I tried to run rpmlint for the binary package which I built, so it generate no errors/warnnings. - You should confirm the license of the package. "BSD" is put on the License: tag in the specfile, but plr/README.plr in the source tree says this software distributed under GPLv2 or later. - You should own the directories on which this package creates, such as % {_datadir}/%{name} and %{_docdir}/%{name}-%{version} - You should use -p option with install command to preserve timestamps. - You should add the R package into BuildRequires: tag, because the package obviously uses /usr/lib/R/include/R.h to build. - You should apply common compiler flags defined as $RPM_OPT_FLAGS or % {optflags}. (See, http://fedoraproject.org/wiki/Packaging/Guidelines#head- 8b14098227aebff1cf6188939e9d0877295ac448) - [Package Review Guidelines] http://fedoraproject.org/wiki/Packaging/ReviewGuidelines [The Packaging Guidelines] http://fedoraproject.org/wiki/Packaging/Guidelines)
Hi Devrim, Could you please update the package according to comments #1? I'll do a formal review after that.
This ticket has been set to needinfo for over three months now. Is it time to close it?
Yes. This package works only for 8.2, so let's skip it.