Bug 246984 - Initscript Review
Summary: Initscript Review
Alias: None
Product: Fedora
Classification: Fedora
Component: mimedefang
Version: 9
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Robert Scheck
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: InitscriptStatus
TreeView+ depends on / blocked
Reported: 2007-07-05 13:53 UTC by Harald Hoyer
Modified: 2008-05-26 17:22 UTC (History)
1 user (show)

Clone Of:
Last Closed: 2008-05-26 17:22:51 UTC

Attachments (Terms of Use)
LSB init.d patch, preliminary (1.16 KB, patch)
2008-04-02 22:07 UTC, James Ralston
no flags Details | Diff

Description Harald Hoyer 2007-07-05 13:53:59 UTC
Please have a look at the wikipage 
and change your initscripts to comply with the LSB standard.
Especially check the exit status and add a LSB Header.
E.g. starting a service should return with 0, if the service is already running and stopping a stopped service should also return with 0.

Also check, if your service has to be _on_ per default, and turn it off in the old chkconfig line, if not.

Thank you.

Comment 1 Robert Scheck 2007-07-26 19:02:44 UTC
Harald, do these problems realy apply to mimedefang? Finally the initscript is 
upstream one, not mine.

Comment 2 James Ralston 2007-08-01 18:45:50 UTC
It's been my experience that upstream (David Skoll) is pretty reasonable about
accepting patches, if you can provide a rationale for the patch.  I don't know
how familiar he is with the LSB in terms of initscripts, so the best way to
bring the mimedefang init script into LSB compliance is probably to do it
yourself and send him the patch.

Comment 3 Robert Scheck 2007-08-01 18:51:48 UTC
James, and how familiar are you regarding this? I would try to get the script 
LSB compatible but somebody has to review it first, before I blame myself at 
upstream, accepted? ;-)

Comment 4 Harald Hoyer 2007-08-02 09:01:22 UTC
well, just try to get the LSB Header in... these are just comment lines, which
should not hurt.

Comment 5 James Ralston 2007-08-02 18:12:07 UTC
Robert, if you want, I can throw together an LSB initscript patch for you, and
send it to upstream.  Let me know.

Comment 6 Robert Scheck 2008-02-10 00:24:17 UTC
James, are you still interested in helping me? If yes, can you please try to 
figgure out such a patch? Thank you.

Comment 7 James Ralston 2008-04-02 22:07:01 UTC
Created attachment 300142 [details]
LSB init.d patch, preliminary

Sorry; I lost track of this bug.

At a minimum, here's a patch that adds the LSB header, and ensures that
mimedefang doesn't automatically run at start.

Comment 9 Bug Zapper 2008-05-14 03:02:53 UTC
Changing version to '9' as part of upcoming Fedora 9 GA.
More information and reason for this action is here:

Comment 10 Robert Scheck 2008-05-26 17:22:51 UTC
Response by upstream: "I've applied the patch; it will be in the next release."

Note You need to log in before you can comment on or make changes to this bug.