Bug 247038 - Initscript Review
Initscript Review
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: qemu (Show other bugs)
8
All Linux
low Severity low
: ---
: ---
Assigned To: David Woodhouse
Fedora Extras Quality Assurance
bzcl34nup
:
Depends On:
Blocks: InitscriptStatus
  Show dependency treegraph
 
Reported: 2007-07-05 09:57 EDT by Harald Hoyer
Modified: 2008-04-04 10:14 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-04-04 10:14:20 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)
patch for qemu-initscript to correctly register the binary handler (1.92 KB, patch)
2007-11-19 14:25 EST, Christian Nolte
no flags Details | Diff

  None (edit)
Description Harald Hoyer 2007-07-05 09:57:35 EDT
Please have a look at the wikipage 
http://fedoraproject.org/wiki/FCNewInit/Initscripts
and change your initscripts to comply with the LSB standard.
Especially check the exit status and add a LSB Header.
E.g. starting a service should return with 0, if the service is already running and stopping a stopped service should also return with 0.

Also check, if your service has to be _on_ per default, and turn it off in the old chkconfig line, if not.

Thank you.
Comment 1 Christian Nolte 2007-11-19 14:04:04 EST
I don't know if that has been considered yet, but as the initscript registers a
binary handler for .exe files: How do we handle the situation where wine is
installed too. The initscript from wine also registers a binary handler for .exe
files. Which one shall the kernel use?
Comment 2 Christian Nolte 2007-11-19 14:24:28 EST
Furthermore the initscript does not work. The architecture test is wrong and the
package qemu-0.9.0-5.fc8 does not contain directories like /usr/qemu-*. I attach
a patch to correct this issue.
Comment 3 Christian Nolte 2007-11-19 14:25:20 EST
Created attachment 263861 [details]
patch for qemu-initscript to correctly register the binary handler
Comment 4 Bug Zapper 2008-04-04 09:14:22 EDT
Based on the date this bug was created, it appears to have been reported
during the development of Fedora 8. In order to refocus our efforts as
a project we are changing the version of this bug to '8'.

If this bug still exists in rawhide, please change the version back to
rawhide.
(If you're unable to change the bug's version, add a comment to the bug
and someone will change it for you.)

Thanks for your help and we apologize for the interruption.

The process we're following is outlined here:
http://fedoraproject.org/wiki/BugZappers/F9CleanUp

We will be following the process here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping to ensure this
doesn't happen again.
Comment 5 Hans de Goede 2008-04-04 10:14:20 EDT
According to the new SYSV initscripts packaging guidelines LSB headers are
optional -> closing.


Note You need to log in before you can comment on or make changes to this bug.